Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2565323003: Move gif image decoder to SkCodec (Closed)

Created:
4 years ago by cblume
Modified:
3 years, 4 months ago
CC:
blink-reviews, ccameron, chromium-reviews, msarett1, aelias_OOO_until_Jul13
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SkCodec internally in GIFImageDecoder Previously, GIFImageDecoder used GIFImageReader internally. SkCodec uses a modified version of that class (SkGifImageReader; adapted in crrev.com/2045293002). SkCodec provides the following benefits: - SIMD optimized code for writing pixels - an API that allows the client to handle caching - flexibility regarding the required frame to use - the ability to decode scaled versions of images - subset decoding (i.e. issue 468914) (not fully implemented for GIF) - the ability to decode to half-width float format In addition, this patch enables sharing code between Android, Skia, and Chromium. This means that new features/bug fixes in Android benefit Chromium and vice versa. For larger images (above ~60x60), the SIMD optimizations show a much bigger benefit (up to 24% in one case). For most images, decoding speed is about the same. Images with many frames that contain tiny update regions are a hair slower. The mean decode time across all tested images showed an improvement. Raw performance numbers can be found here: https://docs.google.com/spreadsheets/d/1JqCPdYmbasOwKRdvuG6ZI4gwq9dPvnJA9oDquh7SxOQ/edit?usp=sharing GIFImageDecoder still handles the cached frames currently, but this change will allow future changes in Blink to make wiser caching Decisions (such as keeping all frames of a 3-frame animation if those frames are small). Full road map: https://docs.google.com/a/chromium.org/document/d/1T06pxiff3oy8KDqWGqWL-_nZqUJ8AMppouPQ_DLrvpk/edit?usp=sharing This results in some behavior changes: - SkCodec does not check the alpha of each pixel during decode (for speed and simplicity). As a result, GIFImageDecoder no longer corrects opacity or the required frame after decoding a frame. No performance penalty has been observed for incorrectly leaving a frame marked as having transparency. - SkCodec guesses transparency based on the presence of a transparent index (in addition to being subset) and uses this to potentially determine an earlier required frame. BUG=715812 Review-Url: https://codereview.chromium.org/2565323003 Cr-Commit-Position: refs/heads/master@{#495230} Committed: https://chromium.googlesource.com/chromium/src/+/4fed3346549a90c0de40c02f6388e19e8151e92a

Patch Set 1 #

Total comments: 46

Patch Set 2 : Addressing code review comments. #

Patch Set 3 : Removing impossible branch and old comment. #

Total comments: 14

Patch Set 4 : Add incremental decode, address code review comments. #

Total comments: 22

Patch Set 5 : Address code review comments. #

Patch Set 6 : Adding color correction info. #

Patch Set 7 : Fix formatting #

Patch Set 8 : Handle incomplete frame info, look into reusing the existing frame buffer. #

Patch Set 9 : Updating Skia build files #

Total comments: 1

Patch Set 10 : Fix BUILD.gn -- now builds #

Total comments: 8

Patch Set 11 : Add the ability to reuse previous buffers rather than copy them. #

Total comments: 4

Patch Set 12 : Fix failing CHECK()s. #

Patch Set 13 : Rebase #

Total comments: 2

Patch Set 14 : Refactoring #

Patch Set 15 : Fixing build. #

Total comments: 2

Patch Set 16 : Peek now loops over a corrected offset. #

Patch Set 17 : Adding move() to SkStream subclass. #

Patch Set 18 : Fixing cast to size_t #

Patch Set 19 : fix peek() reading the wrong size -- now passing GIFImageDecoderTest.progressiveDecode #

Total comments: 1

Patch Set 20 : Fixing the alpha, not changing frame between init and decode. #

Total comments: 5

Patch Set 21 : Remove invalid disposal method test #

Total comments: 1

Patch Set 22 : Handling invalid data #

Patch Set 23 : Don't initialize the frame until we know the frame exists. #

Patch Set 24 : Set the frame status after marking that pixels have changed #

Patch Set 25 : Lock / unlock pixels when copying and decoding. #

Patch Set 26 : Now parsing what we can -- don't need to trigger parse #

Patch Set 27 : Override frameStatusSufficientForSuccessors since we now need the completed frame #

Patch Set 28 : Only call setSizeAndColorSpace when we won't be copying from a previous frame #

Patch Set 29 : Remove lockPixels() / unlockPixels() #

Patch Set 30 : Only set frame to partial for frame 0 #

Total comments: 3

Patch Set 31 : Removing temporary test rigging #

Patch Set 32 : Rebasing #

Patch Set 33 : Accidentally left in some relics from printf-style debugging #

Patch Set 34 : Allocate frames as needed instead of in advance #

Patch Set 35 : Fixing build. Cleaning up frame allocation #

Patch Set 36 : Fixing GIFImageDecoderTest.verifyRepetitionCount test to reflect new behavior #

Patch Set 37 : Fix GIFImageDecoderTest.randomFrameDecode -- possibly fixing animated images but I cannot see from … #

Patch Set 38 : Rebasing -- include orders are now changed #

Total comments: 42

Patch Set 39 : Rebasing #

Patch Set 40 : Addressing code review comments #

Patch Set 41 : Fixing setFailed() on incomplete frame 0 #

Total comments: 12

Patch Set 42 : Fixing code review comments #

Patch Set 43 : Fix dereferencing nullptr errors #

Total comments: 26

Patch Set 44 : Fixing code review comments (DCHECK, remove dead branch, clarify comments) #

Total comments: 5

Patch Set 45 : Add setSizeAndColorSpaceWithoutZeroFilling. Check incomplete frames #

Patch Set 46 : Fix DeferredImageDecoderTestWoPlatform.mixImagesGif by tracking onSetData(nullptr) #

Total comments: 10

Patch Set 47 : Rebasing #

Patch Set 48 : Store frame info. Try to not keep track of whether the SegmentStream was cleared #

Patch Set 49 : Rebasing #

Patch Set 50 : Fixing build issue #

Patch Set 51 : Rebasing #

Patch Set 52 : Use new allocatePixelData() #

Patch Set 53 : Adding isCleared() back #

Patch Set 54 : Zero fill pixel data when allocating #

Total comments: 6

Patch Set 55 : Fix zero init -- it is an enum, not a bool #

Patch Set 56 : Fix include order #

Patch Set 57 : Fix potential memory leak #

Total comments: 1

Patch Set 58 : Move SegmentStream out of GIFImageDecoder #

Patch Set 59 : Add SegmentStream to BUILD.gn #

Patch Set 60 : Fixing unknown identifier #

Patch Set 61 : Fix build, mixImagesGif test, and verifyRepetitionCount test #

Total comments: 3

Patch Set 62 : Adding SegmentStreamTest.cpp, more null checks, and updating m_hasReadAllContents more. #

Total comments: 1

Patch Set 63 : Rebase #

Patch Set 64 : Fix Windows build #

Patch Set 65 : Rebase with new Blink naming scheme #

Patch Set 66 : Rebase with new Blink naming scheme #

Patch Set 67 : Rebase #

Patch Set 68 : Adding per-frame alpha #

Patch Set 69 : Fix GIFImageDecoderTest.externalAllocator and DeferredImageDecoderTest.frameOpacity #

Patch Set 70 : Update naming of Size() #

Patch Set 71 : Setting has alpha on a partial decode. #

Total comments: 63

Patch Set 72 : General code clean-up #

Patch Set 73 : Rebasing #

Patch Set 74 : Fixing Windows build #

Patch Set 75 : Fix gif fill color not being transparent #

Patch Set 76 : Fix DeferredImageDecoderTestWoPlatform.mixImagesGif #

Total comments: 12

Patch Set 77 : Fixing dependent frames not setting status to allocated. #

Patch Set 78 : Code review comment changes #

Patch Set 79 : Only delete the SegmentStream pointer if the SkCodec wasn't created. #

Patch Set 80 : Fixing GIFImageDecoderTest.verifyRepetitionCount in the case where there is no animation. #

Patch Set 81 : Handling 1-frame images returning no animation. #

Total comments: 5

Patch Set 82 : Code review comments #

Total comments: 22

Patch Set 83 : More code review comments #

Total comments: 35

Patch Set 84 : Cleaning up SegmentStream tests #

Total comments: 2

Patch Set 85 : Rebasing #

Patch Set 86 : Make SegmentStream movable, clean naming #

Total comments: 1

Patch Set 87 : Fixing missing array include, cleaning up the tests #

Patch Set 88 : Using a long instead of a size_t for the offset #

Patch Set 89 : Fixing wrong literal being used #

Patch Set 90 : Rebase & format #

Patch Set 91 : Add libjpeg-turbo to list of Skia library configs #

Total comments: 2

Patch Set 92 : Rebase #

Patch Set 93 : Use Chromium's libjpeg-turb and not Skia's #

Patch Set 94 : Fix build after rebase #

Patch Set 95 : See build errors for libjpeg_turbo on iOS #

Patch Set 96 : See the linker errors when iOS doesn't have libjpeg_turbo #

Patch Set 97 : Only include SkCodec for non-iOS targets #

Total comments: 22

Patch Set 98 : Simplify frame allocation code inside ImageFrame::CopyBitmapData #

Patch Set 99 : Use SkCodec::getFrameInfo(index) instead of copying a vector #

Patch Set 100 : Create SkImageInfo using desired color space #

Patch Set 101 : Call SetFailed() after zeroing extra lines on partially-decoded first frame #

Patch Set 102 : Use ImageDecoder::Size() instead of ImageFrame::OriginalFrameRect() for clarity #

Patch Set 103 : Only zero fill the first frame when the frame is incomplete #

Patch Set 104 : Simplify setting alpha back to its pre-zeroed value #

Patch Set 105 : Rebase #

Patch Set 106 : Add SkBmpBaseCodec.cpp to the build #

Patch Set 107 : Rebase #

Patch Set 108 : Fill image with alpha after an error is encountered #

Total comments: 11

Patch Set 109 : Provide previous frame #

Patch Set 110 : Remove dead code #

Patch Set 111 : Use disposal method for frame reuse #

Patch Set 112 : Fix build #

Total comments: 5

Patch Set 113 : Allow frames after a DisposePrevious to be reused #

Patch Set 114 : Only zero-fill the first frame #

Patch Set 115 : Mark error-in-input frames as empty, so they are not displayed #

Total comments: 1

Patch Set 116 : Always zero-initialize every frame completely #

Total comments: 4

Patch Set 117 : Rebase #

Patch Set 118 : Only zero-fill independent frames. Don't call SetPixelsChanged() until after decode #

Patch Set 119 : Preserve frame alpha beyond zero filling #

Patch Set 120 : Fix gif alpha errors #

Patch Set 121 : Correct misleading comment #

Patch Set 122 : Initialize new frames with empty status. Sufficient frames should not include the allocated state #

Patch Set 123 : Override ClearCacheExceptFrame to handle SkCodec-specific behavior #

Patch Set 124 : Decode previous frame if incomplete. Make sure we don't search past kNotFound #

Patch Set 125 : Support SkCodec::NewFromStream finding an error in the input #

Total comments: 61

Patch Set 126 : Add default initialization to SegmentStream's members. Explicitly default the default ctor. Add mis… #

Patch Set 127 : Remove unnecessary peek_position variable #

Patch Set 128 : SegmentStream::move now DCHECKs against negative offsets #

Patch Set 129 : Simplify & clarify cache clearing #

Patch Set 130 : Remove duplicated variable assignments #

Patch Set 131 : Clarify code with mo'bettah comments #

Total comments: 40

Patch Set 132 : Rebase #

Patch Set 133 : Fix rebase mistake #

Patch Set 134 : Improve comments #

Patch Set 135 : Remove redundant parameter names from header. Utilize blink namespace #

Patch Set 136 : Improve readability #

Patch Set 137 : Only fill in frame info if we could get it #

Patch Set 138 : Clean decode-needed-frame code #

Patch Set 139 : Rebase #

Patch Set 140 : Remove SegmentStream test to check negative move clamps to 0 #

Total comments: 7

Patch Set 141 : Remove unused constant #

Patch Set 142 : DCHECK the result of codec_->getFrameInfo() #

Patch Set 143 : Do not specify WTF:: for kNotFound #

Patch Set 144 : Remove useless check for complete frames prior to decoding them #

Total comments: 2

Patch Set 145 : Remove extra calls to SetHasAlpha() #

Total comments: 9

Patch Set 146 : Check if the stream has been cleared before any SkCodec call which might advance. Remove dtor which… #

Total comments: 8

Patch Set 147 : Cache last-seen repetition count for use when buffer cleared #

Patch Set 148 : Remove redundant check for IsCleared() #

Patch Set 149 : Keep a cache of the max fully received frame index #

Total comments: 3

Patch Set 150 : Fix broken if branch #

Patch Set 151 : Rebase #

Patch Set 152 : Updated API call to reflect API change #

Patch Set 153 : Updated API call to reflect API change #

Patch Set 154 : Fix invalid disposal method test #

Patch Set 155 : Correct comments. Better variable names. Better DCHECK. #

Total comments: 20

Patch Set 156 : Using override & default-in-cpp for destructors #

Patch Set 157 : Fix invalid DCHECK #

Patch Set 158 : Move max complete index caching into DecodeFrameCount() #

Patch Set 159 : Only check this and the last frame for completion #

Patch Set 160 : Don't use deprecated PassRefPtr #

Total comments: 6

Patch Set 161 : Rebase #

Patch Set 162 : Simplify code by removing cached values. #

Total comments: 4

Patch Set 163 : Cache repetition count. Use SkCodec's cache of fully received. #

Total comments: 5

Patch Set 164 : Rename variable. Return last-known frame count upon error / clearing #

Total comments: 8

Patch Set 165 : Forward declare SegmentReader in SegmentStream.h #

Patch Set 166 : Don't use deprecated PassRefPtr #

Patch Set 167 : Enforce all calls to GetViableReferenceFrameIndex() to require a valid previous frame #

Patch Set 168 : Replace SegmentStream::SetPositionState() #

Total comments: 11

Patch Set 169 : Rebase #

Patch Set 170 : Compare against previous frame, not status #

Patch Set 171 : Use =default for SegmentStream's move ctor & assignment #

Patch Set 172 : Use =default for SegmentStream's move ctor & assignment #

Patch Set 173 : Remove superfluous variable #

Patch Set 174 : Use DCHECK for IsCleared() inside SegmentStream #

Patch Set 175 : Fix typo #

Patch Set 176 : Explicitly specify move ctor / assignment until required patch lands. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1179 lines, -1533 lines) Patch
M skia/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 3 chunks +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 3 chunks +12 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/platform/image-decoders/SegmentStream.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 1 chunk +702 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 2 chunks +20 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 2 chunks +246 lines, -192 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 6 chunks +10 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 1 chunk +0 lines, -371 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 1 chunk +0 lines, -900 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 601 (433 generated)
cblume
PTAL This is not ready to submit. There are comments in the code that point ...
4 years ago (2016-12-13 03:14:31 UTC) #2
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode45 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:45: m_segmentStream(new SegmentStream{}) {} Why not make m_segmentStream a full ...
4 years ago (2016-12-13 16:57:37 UTC) #3
cblume
https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode45 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:45: m_segmentStream(new SegmentStream{}) {} On 2016/12/13 16:57:36, scroggo_chromium wrote: > ...
4 years ago (2016-12-14 09:16:57 UTC) #4
cblume
+senorblanco@ to review BUILD.gn I need to add Skia as a dependency in BUILD.gn. I ...
4 years ago (2016-12-14 17:11:09 UTC) #6
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode45 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:45: m_segmentStream(new SegmentStream{}) {} On 2016/12/14 09:16:56, cblume wrote: > ...
4 years ago (2016-12-14 17:49:23 UTC) #7
cblume
-Stephen +Florin
4 years ago (2016-12-14 18:02:32 UTC) #9
Stephen White
On 2016/12/14 17:11:09, cblume wrote: > +senorblanco@ to review BUILD.gn > > I need to ...
4 years ago (2016-12-14 18:03:55 UTC) #10
Stephen White
On 2016/12/14 18:03:55, Stephen White wrote: > On 2016/12/14 17:11:09, cblume wrote: > > +senorblanco@ ...
4 years ago (2016-12-14 18:04:46 UTC) #11
f(malita)
On 2016/12/14 17:11:09, cblume wrote: > +senorblanco@ to review BUILD.gn > > I need to ...
4 years ago (2016-12-14 18:16:15 UTC) #12
f(malita)
BUILD.gn lgtm
4 years ago (2016-12-14 18:19:35 UTC) #13
Stephen White
On 2016/12/14 18:16:15, f(malita) wrote: > On 2016/12/14 17:11:09, cblume wrote: > > +senorblanco@ to ...
4 years ago (2016-12-14 18:19:48 UTC) #14
scroggo_chromium
On 2016/12/14 18:19:48, Stephen White wrote: > On 2016/12/14 18:16:15, f(malita) wrote: > > On ...
4 years ago (2016-12-14 18:31:41 UTC) #15
f(malita)
On 2016/12/14 18:31:41, scroggo_chromium wrote: > On 2016/12/14 18:19:48, Stephen White wrote: > > On ...
4 years ago (2016-12-14 20:13:19 UTC) #16
cblume
https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode45 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:45: m_segmentStream(new SegmentStream{}) {} On 2016/12/14 17:49:23, scroggo_chromium wrote: > ...
4 years ago (2016-12-16 02:57:11 UTC) #17
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode182 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:182: frame.copyBitmapData(requiredPreviousFrame); On 2016/12/16 02:57:10, cblume wrote: > On 2016/12/14 ...
4 years ago (2016-12-16 15:03:48 UTC) #18
cblume
https://codereview.chromium.org/2565323003/diff/40001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/40001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h#newcode80 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h:80: m_hasReadAllContents = false; On 2016/12/16 15:03:48, scroggo_chromium wrote: > ...
4 years ago (2016-12-16 17:43:41 UTC) #19
cblume
+ccameron@ and @msarett for the color correction info (inside GIFImageDecoder.cpp's initializeNewFrame() )
4 years ago (2016-12-16 18:24:45 UTC) #20
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: options.fHasPriorFrame = true; On 2016/12/16 17:43:41, cblume wrote: > ...
4 years ago (2016-12-16 18:45:45 UTC) #21
cblume
https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: options.fHasPriorFrame = true; On 2016/12/16 18:45:45, scroggo_chromium wrote: > ...
4 years ago (2016-12-18 17:47:57 UTC) #22
msarett
On 2016/12/16 18:24:45, cblume wrote: > +ccameron@ and @msarett for the color correction info (inside ...
4 years ago (2016-12-18 19:21:14 UTC) #23
cblume
I'm trying a few changes to get Skia building with SkCodec.cpp and family included. So ...
4 years ago (2016-12-18 23:14:30 UTC) #24
cblume
https://codereview.chromium.org/2565323003/diff/160001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/2565323003/diff/160001/skia/BUILD.gn#newcode232 skia/BUILD.gn:232: sources += skia_codec_sources I had put the required .cpp ...
4 years ago (2016-12-19 08:04:03 UTC) #27
cblume
I'll look into the test failures when I get into the office. Right now I'm ...
4 years ago (2016-12-19 13:12:58 UTC) #30
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: options.fHasPriorFrame = true; On 2016/12/18 17:47:57, cblume wrote: > ...
4 years ago (2016-12-19 14:28:54 UTC) #31
cblume
https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: options.fHasPriorFrame = true; On 2016/12/19 14:28:54, scroggo_chromium wrote: > ...
4 years ago (2016-12-19 21:12:40 UTC) #32
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: options.fHasPriorFrame = true; On 2016/12/19 21:12:40, cblume wrote: > ...
4 years ago (2016-12-19 21:16:15 UTC) #33
cblume
https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: options.fHasPriorFrame = true; On 2016/12/19 21:16:15, scroggo_chromium wrote: > ...
4 years ago (2016-12-19 21:21:48 UTC) #34
ccameron
color bits lgtm
4 years ago (2016-12-20 21:09:00 UTC) #36
cblume
https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/60001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode185 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:185: // call startIncrementalDecode again? On 2016/12/19 14:28:54, scroggo_chromium wrote: ...
4 years ago (2016-12-20 21:59:01 UTC) #37
cblume
On 2016/12/14 18:19:35, f(malita) wrote: > BUILD.gn lgtm f(malita) would you mind taking a look ...
4 years ago (2016-12-20 22:02:00 UTC) #40
Noel Gordon
https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode112 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:112: std::vector<SkCodec::FrameInfo> frameInfos = m_codec->getFrameInfo(); Drive by: std:: container types ...
4 years ago (2016-12-21 06:16:56 UTC) #44
cblume
https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode112 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:112: std::vector<SkCodec::FrameInfo> frameInfos = m_codec->getFrameInfo(); On 2016/12/21 06:16:56, noel gordon ...
4 years ago (2016-12-21 08:18:19 UTC) #45
cblume
All of the failed tests are from the CHECK(m_codec) inside: decodeSize(), and decodeFrameCount() decodeSize()'s documentation ...
4 years ago (2016-12-21 10:22:48 UTC) #46
cblume
On 2016/12/21 10:22:48, cblume wrote: > All of the failed tests are from the CHECK(m_codec) ...
4 years ago (2016-12-21 10:27:01 UTC) #47
Noel Gordon
On 2016/12/21 08:18:19, cblume wrote: > https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp > File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp > (right): > > https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode112 ...
4 years ago (2016-12-21 10:36:36 UTC) #50
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode112 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:112: std::vector<SkCodec::FrameInfo> frameInfos = m_codec->getFrameInfo(); On 2016/12/21 06:16:56, noel gordon ...
4 years ago (2016-12-21 21:25:15 UTC) #55
cblume
https://codereview.chromium.org/2565323003/diff/240001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/240001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode61 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:61: if (!m_codec) { I am investigating the error in ...
4 years ago (2016-12-22 08:24:14 UTC) #58
Noel Gordon
x-ing here a bit, sorry. On 2016/12/21 21:25:15, scroggo_chromium wrote: > https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp > File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ...
4 years ago (2016-12-22 12:56:39 UTC) #59
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode112 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:112: std::vector<SkCodec::FrameInfo> frameInfos = m_codec->getFrameInfo(); On 2016/12/22 12:56:39, noel gordon ...
4 years ago (2016-12-22 16:21:31 UTC) #60
cblume
On 2016/12/22 08:24:14, cblume wrote: > I tried some printf debugging and gdb but didn't ...
3 years, 11 months ago (2016-12-29 20:36:56 UTC) #61
cblume
On 2016/12/29 20:36:56, cblume wrote: > in order: > SkGIFType > SkGIFGlobalHeader > SkGIFGlobalColormap > ...
3 years, 11 months ago (2017-01-01 06:08:40 UTC) #62
cblume
On 2017/01/01 06:08:40, cblume wrote: > On 2016/12/29 20:36:56, cblume wrote: > > in order: ...
3 years, 11 months ago (2017-01-03 09:57:47 UTC) #63
scroggo_chromium
On 2016/12/29 20:36:56, cblume wrote: > On 2016/12/22 08:24:14, cblume wrote: > > I tried ...
3 years, 11 months ago (2017-01-03 22:36:58 UTC) #72
cblume
> On 2016/12/29 20:36:56, cblume wrote: > > On 2016/12/22 08:24:14, cblume wrote: > > ...
3 years, 11 months ago (2017-01-04 01:29:59 UTC) #73
cblume
https://codereview.chromium.org/2565323003/diff/280001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/280001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h#newcode98 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h:98: size_t bytesPeeked = m_reader->getSomeData(segment, m_position); On 2017/01/03 22:36:58, scroggo_chromium ...
3 years, 11 months ago (2017-01-04 01:30:28 UTC) #74
cblume
On 2017/01/04 01:29:59, cblume wrote: > > On 2016/12/29 20:36:56, cblume wrote: > > > ...
3 years, 11 months ago (2017-01-04 04:07:03 UTC) #79
cblume
On 2017/01/04 04:07:03, cblume wrote: > On 2017/01/04 01:29:59, cblume wrote: > > > On ...
3 years, 11 months ago (2017-01-04 19:14:57 UTC) #80
cblume
I've figured it out. Boy, that was a doozy. The simple solution was that my ...
3 years, 11 months ago (2017-01-05 12:36:14 UTC) #81
cblume
There is still an issue where pixel values appear to be incorrect. I'll look into ...
3 years, 11 months ago (2017-01-05 12:47:00 UTC) #84
scroggo_chromium
On 2017/01/04 01:29:59, cblume wrote: > > On 2016/12/29 20:36:56, cblume wrote: > > > ...
3 years, 11 months ago (2017-01-05 16:44:04 UTC) #87
cblume
On 2017/01/05 16:44:04, scroggo_chromium wrote: > Sorry, I was unclear. I did not mean the ...
3 years, 11 months ago (2017-01-06 00:01:19 UTC) #92
scroggo_chromium
On 2017/01/06 00:01:19, cblume wrote: > On 2017/01/05 16:44:04, scroggo_chromium wrote: > > Sorry, I ...
3 years, 11 months ago (2017-01-06 14:09:38 UTC) #93
cblume
https://codereview.chromium.org/2565323003/diff/360001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/360001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode68 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:68: SkCodec* temp = SkCodec::NewFromStream(m_segmentStream); "temp" was a bad name. ...
3 years, 11 months ago (2017-01-09 04:11:22 UTC) #100
cblume
https://codereview.chromium.org/2565323003/diff/380001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp (right): https://codereview.chromium.org/2565323003/diff/380001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp#newcode325 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp:325: } SkGifCodec is the one that is now responsible ...
3 years, 11 months ago (2017-01-09 08:06:48 UTC) #103
cblume
https://codereview.chromium.org/2565323003/diff/400001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/400001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode264 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:264: correctAlphaWhenFrameBufferSawNoAlpha(index); Moved this to only happen when the frame ...
3 years, 11 months ago (2017-01-09 09:21:39 UTC) #106
cblume
Just a little update on my bug hunt: inside frame.takeBitmapDataIfWritable(&requiredPreviousFrame) we are hitting DCHECK_EQ(FrameComplete, other->m_status); ...
3 years, 11 months ago (2017-01-12 02:57:29 UTC) #109
cblume
I am printing out the thread IDs each time we generate a frame and am ...
3 years, 11 months ago (2017-01-14 23:56:26 UTC) #110
cblume
I made a mistake when having all those frame-0 decodes interleaved. When Chrome first loads ...
3 years, 11 months ago (2017-01-16 21:29:05 UTC) #113
cblume
I still have a few bits to clean but I wanted to mark this progress. ...
3 years, 10 months ago (2017-01-30 07:35:48 UTC) #123
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (left): https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#oldcode57 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:57: // There are some additional wrinkles here. First, ImageSource::clear() ...
3 years, 10 months ago (2017-02-24 19:04:30 UTC) #157
cblume
https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (left): https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#oldcode73 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:73: if (isAllDataReceived() && parseCompleted() && m_reader->imagesCount() == 1) On ...
3 years, 9 months ago (2017-03-05 19:17:45 UTC) #165
cblume
https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode235 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:235: correctAlphaWhenFrameBufferSawNoAlpha(index); On 2017/03/05 19:17:40, cblume wrote: > On 2017/02/24 ...
3 years, 9 months ago (2017-03-06 03:21:37 UTC) #168
cblume
https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h#newcode79 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h:79: len = std::min(len, m_reader->size()); On 2017/03/05 19:17:42, cblume wrote: ...
3 years, 9 months ago (2017-03-06 08:30:52 UTC) #171
msarett1
https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode235 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:235: correctAlphaWhenFrameBufferSawNoAlpha(index); On 2017/03/06 03:21:36, cblume wrote: > On 2017/03/05 ...
3 years, 9 months ago (2017-03-06 13:54:00 UTC) #175
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode184 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:184: frame.setOriginalFrameRect(IntRect(IntPoint(), frameSize)); On 2017/03/05 19:17:41, cblume wrote: > On ...
3 years, 9 months ago (2017-03-06 16:27:31 UTC) #176
cblume
https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/740001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode184 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:184: frame.setOriginalFrameRect(IntRect(IntPoint(), frameSize)); On 2017/03/06 16:27:31, scroggo_chromium wrote: > On ...
3 years, 9 months ago (2017-03-07 01:18:12 UTC) #177
cblume
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h#newcode77 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h:77: m_hasReadAllContents = reader->size() == m_position; I need some help ...
3 years, 9 months ago (2017-03-07 09:00:12 UTC) #184
msarett1
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp#newcode346 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp:346: EXPECT_EQ(premulFrame->bitmap().alphaType(), kPremul_SkAlphaType); I don't think radient.gif is one of ...
3 years, 9 months ago (2017-03-07 13:27:18 UTC) #187
cblume
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp#newcode346 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp:346: EXPECT_EQ(premulFrame->bitmap().alphaType(), kPremul_SkAlphaType); On 2017/03/07 13:27:18, msarett1 wrote: > I ...
3 years, 9 months ago (2017-03-07 19:36:29 UTC) #188
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode137 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:137: if (!m_codec) I think you can DCHECK(m_codec); This will ...
3 years, 9 months ago (2017-03-07 21:35:08 UTC) #189
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp#newcode346 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp:346: EXPECT_EQ(premulFrame->bitmap().alphaType(), kPremul_SkAlphaType); On 2017/03/07 21:35:08, scroggo_chromium wrote: > On ...
3 years, 9 months ago (2017-03-07 22:06:14 UTC) #190
cblume
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode137 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:137: if (!m_codec) On 2017/03/07 21:35:07, scroggo_chromium wrote: > I ...
3 years, 9 months ago (2017-03-08 11:36:11 UTC) #193
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode242 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:242: // 2.) all data has been received and the ...
3 years, 9 months ago (2017-03-08 16:36:10 UTC) #196
cblume
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode242 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:242: // 2.) all data has been received and the ...
3 years, 9 months ago (2017-03-08 19:49:43 UTC) #197
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/860001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/860001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode235 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:235: // This decoder will not attempt to decode a ...
3 years, 9 months ago (2017-03-08 21:04:11 UTC) #198
cblume
https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/840001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode230 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:230: int rowsDecoded = 0; On 2017/03/08 11:36:11, cblume wrote: ...
3 years, 9 months ago (2017-03-08 23:18:57 UTC) #200
Noel Gordon
https://codereview.chromium.org/2565323003/diff/860001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/860001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode235 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:235: // This decoder will not attempt to decode a ...
3 years, 9 months ago (2017-03-09 04:12:28 UTC) #204
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/900001/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp File third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp (right): https://codereview.chromium.org/2565323003/diff/900001/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp#newcode109 third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp:109: sk_sp<SkColorSpace> colorSpace) { Why not add a boolean (or ...
3 years, 9 months ago (2017-03-13 20:36:41 UTC) #209
cblume
https://codereview.chromium.org/2565323003/diff/900001/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp File third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp (right): https://codereview.chromium.org/2565323003/diff/900001/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp#newcode109 third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp:109: sk_sp<SkColorSpace> colorSpace) { On 2017/03/13 20:36:40, scroggo_chromium wrote: > ...
3 years, 9 months ago (2017-03-13 21:53:12 UTC) #210
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/900001/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp File third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp (right): https://codereview.chromium.org/2565323003/diff/900001/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp#newcode111 third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp:111: // should only be called once. It leaks memory ...
3 years, 9 months ago (2017-03-14 16:08:48 UTC) #211
cblume
https://codereview.chromium.org/2565323003/diff/900001/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp File third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp (right): https://codereview.chromium.org/2565323003/diff/900001/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp#newcode109 third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp:109: sk_sp<SkColorSpace> colorSpace) { On 2017/03/13 21:53:12, cblume wrote: > ...
3 years, 9 months ago (2017-03-16 11:03:30 UTC) #214
cblume
https://codereview.chromium.org/2565323003/diff/1060001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/2565323003/diff/1060001/skia/BUILD.gn#newcode278 skia/BUILD.gn:278: "//third_party/skia/src/codec/SkWbmpCodec.cpp", I want to revisit this. I think I ...
3 years, 9 months ago (2017-03-25 07:54:39 UTC) #233
cblume
https://codereview.chromium.org/2565323003/diff/1120001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1120001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode188 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:188: frame.setStatus(ImageFrame::FrameAllocated); There are a few places where SkCodec::startIncrementalDecode() can ...
3 years, 9 months ago (2017-03-25 08:06:34 UTC) #236
cblume
I believe these two tests: GIFImageDecoderTest.externalAllocator DeferredImageDecoderTest.frameOpacity require this patch to land: https://skia-review.googlesource.com/c/9810/ scroggo@ Is ...
3 years, 8 months ago (2017-03-28 08:35:01 UTC) #255
cblume
https://codereview.chromium.org/2565323003/diff/1200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1200001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode132 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:132: m_frameInfos = m_codec->getFrameInfo(); Oh also, I might need your ...
3 years, 8 months ago (2017-03-28 08:51:40 UTC) #256
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1060001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/2565323003/diff/1060001/skia/BUILD.gn#newcode278 skia/BUILD.gn:278: "//third_party/skia/src/codec/SkWbmpCodec.cpp", On 2017/03/25 07:54:39, cblume wrote: > I want ...
3 years, 8 months ago (2017-04-05 18:06:15 UTC) #257
cblume
https://codereview.chromium.org/2565323003/diff/1060001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/2565323003/diff/1060001/skia/BUILD.gn#newcode278 skia/BUILD.gn:278: "//third_party/skia/src/codec/SkWbmpCodec.cpp", On 2017/04/05 18:06:14, scroggo_chromium wrote: > On 2017/03/25 ...
3 years, 8 months ago (2017-04-08 01:19:20 UTC) #262
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h#newcode389 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:389: // And gif is also treated differently, since it ...
3 years, 8 months ago (2017-04-17 20:04:56 UTC) #285
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode268 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:268: // However, if the current and next frame depend ...
3 years, 8 months ago (2017-04-18 16:18:26 UTC) #286
cblume
https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h#newcode389 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:389: // And gif is also treated differently, since it ...
3 years, 8 months ago (2017-04-20 03:42:27 UTC) #289
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h#newcode389 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:389: // And gif is also treated differently, since it ...
3 years, 8 months ago (2017-04-21 20:09:32 UTC) #302
cblume
https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h#newcode389 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:389: // And gif is also treated differently, since it ...
3 years, 8 months ago (2017-04-21 23:47:38 UTC) #307
cblume
https://codereview.chromium.org/2565323003/diff/1600001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1600001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode99 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:99: if (IsAllDataReceived() && frame_count == 1) I would prefer ...
3 years, 8 months ago (2017-04-23 23:13:53 UTC) #320
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h#newcode389 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:389: // And gif is also treated differently, since it ...
3 years, 8 months ago (2017-04-24 15:06:54 UTC) #323
cblume
https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1400001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode131 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:131: if (!Failed() && !(segment_stream_ && segment_stream_->IsCleared())) On 2017/04/24 15:06:53, ...
3 years, 8 months ago (2017-04-24 18:22:33 UTC) #326
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1620001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/1620001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode75 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:75: // Given those two options, blindly following sounds better. ...
3 years, 8 months ago (2017-04-24 20:25:07 UTC) #327
cblume
https://codereview.chromium.org/2565323003/diff/1620001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/1620001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode75 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:75: // Given those two options, blindly following sounds better. ...
3 years, 8 months ago (2017-04-24 21:35:54 UTC) #330
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1620001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1620001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode181 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:181: // It is a fatal error if all data ...
3 years, 8 months ago (2017-04-25 15:31:41 UTC) #335
cblume
https://codereview.chromium.org/2565323003/diff/1620001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/1620001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode181 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:181: // It is a fatal error if all data ...
3 years, 8 months ago (2017-04-26 10:09:51 UTC) #336
cblume
https://codereview.chromium.org/2565323003/diff/1640001/third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp (right): https://codereview.chromium.org/2565323003/diff/1640001/third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp#newcode123 third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp:123: TEST(SegmentStreamTest, SetReaderShouldSetIsAtEndWhenSetToNull) { On 2017/04/26 10:09:44, cblume wrote: > ...
3 years, 8 months ago (2017-04-26 18:17:52 UTC) #341
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1640001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/1640001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode85 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:85: void SegmentStream::UpdateInternals(size_t new_position) { On 2017/04/26 10:09:42, cblume wrote: ...
3 years, 8 months ago (2017-04-26 19:02:23 UTC) #342
cblume
https://codereview.chromium.org/2565323003/diff/1640001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/1640001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode85 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:85: void SegmentStream::UpdateInternals(size_t new_position) { On 2017/04/26 19:02:22, scroggo_chromium wrote: ...
3 years, 8 months ago (2017-04-26 19:16:06 UTC) #343
cblume
https://codereview.chromium.org/2565323003/diff/1700001/third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp (right): https://codereview.chromium.org/2565323003/diff/1700001/third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp#newcode49 third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp:49: blink::SegmentStream CreatePopulatedSegmentStreamReadable(); Oops. This wasn't supposed to end in ...
3 years, 8 months ago (2017-04-26 21:48:12 UTC) #346
cblume
https://codereview.chromium.org/2565323003/diff/1640001/third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp (right): https://codereview.chromium.org/2565323003/diff/1640001/third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp#newcode123 third_party/WebKit/Source/platform/image-decoders/SegmentStreamTest.cpp:123: TEST(SegmentStreamTest, SetReaderShouldSetIsAtEndWhenSetToNull) { On 2017/04/26 18:17:52, cblume wrote: > ...
3 years, 8 months ago (2017-04-27 03:07:41 UTC) #356
scroggo_chromium
Could you add some more details to the commit message and/or the bug? They mention ...
3 years, 7 months ago (2017-04-27 14:50:49 UTC) #361
cblume
On 2017/04/27 14:50:49, scroggo_chromium wrote: > Could you add some more details to the commit ...
3 years, 7 months ago (2017-04-27 15:37:00 UTC) #362
scroggo_chromium
On 2017/04/27 15:37:00, cblume wrote: > On 2017/04/27 14:50:49, scroggo_chromium wrote: > > Could you ...
3 years, 7 months ago (2017-04-27 17:29:24 UTC) #363
cblume
Is there a Skia config for iOS + libjpeg-turbo?
3 years, 7 months ago (2017-05-18 08:39:05 UTC) #372
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1800001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/2565323003/diff/1800001/skia/BUILD.gn#newcode118 skia/BUILD.gn:118: "//third_party/skia/third_party/libjpeg-turbo", > Is there a Skia config for iOS ...
3 years, 7 months ago (2017-05-18 15:55:56 UTC) #373
cblume
> Could you add some more details to the commit message and/or the bug? They ...
3 years, 6 months ago (2017-06-03 01:11:34 UTC) #397
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/1920001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/2565323003/diff/1920001/skia/BUILD.gn#newcode47 skia/BUILD.gn:47: include_dirs += [ "//third_party/skia/include/codec" ] So we're not using ...
3 years, 6 months ago (2017-06-05 19:00:54 UTC) #399
cblume
https://codereview.chromium.org/2565323003/diff/1920001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/2565323003/diff/1920001/skia/BUILD.gn#newcode47 skia/BUILD.gn:47: include_dirs += [ "//third_party/skia/include/codec" ] On 2017/06/05 19:00:53, scroggo_chromium ...
3 years, 6 months ago (2017-06-06 04:04:36 UTC) #404
cblume
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode219 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:219: options.fPriorFrame = SkCodec::kNone; This is supposed to be set ...
3 years, 5 months ago (2017-07-07 22:11:58 UTC) #411
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode257 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:257: if (!index) { On 2017/07/07 22:11:58, cblume wrote: > ...
3 years, 5 months ago (2017-07-10 17:45:58 UTC) #416
cblume
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode257 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:257: if (!index) { On 2017/07/10 17:45:57, scroggo_chromium wrote: > ...
3 years, 5 months ago (2017-07-11 00:23:37 UTC) #417
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode257 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:257: if (!index) { On 2017/07/11 00:23:37, cblume wrote: > ...
3 years, 5 months ago (2017-07-11 17:41:28 UTC) #422
cblume
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode257 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:257: if (!index) { On 2017/07/11 17:41:28, scroggo_chromium wrote: > ...
3 years, 5 months ago (2017-07-11 18:25:02 UTC) #423
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode257 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:257: if (!index) { On 2017/07/11 18:25:02, cblume wrote: > ...
3 years, 5 months ago (2017-07-11 20:36:39 UTC) #424
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2300001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2300001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode207 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:207: frame.ZeroFillPixelData(); I'd recommend following the example of InitFrameBuffer [1], ...
3 years, 5 months ago (2017-07-12 17:18:03 UTC) #433
cblume
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode257 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:257: if (!index) { On 2017/07/11 20:36:39, scroggo_chromium wrote: > ...
3 years, 5 months ago (2017-07-12 21:22:41 UTC) #434
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode257 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:257: if (!index) { On 2017/07/12 21:22:41, cblume wrote: > ...
3 years, 5 months ago (2017-07-13 12:31:06 UTC) #443
cblume
As we discussed, the code is now handling the cache clearing to keep a frame ...
3 years, 5 months ago (2017-07-14 08:38:18 UTC) #456
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode145 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:145: size_t GIFImageDecoder::ClearCacheExceptFrame(size_t index) { First off, I'll acknowledge that ...
3 years, 5 months ago (2017-07-17 20:07:56 UTC) #462
vmpstr
(drive-by) I mostly have nits. From the other comments, it seems that this patch is ...
3 years, 5 months ago (2017-07-17 21:28:41 UTC) #464
vmpstr
On 2017/07/17 21:28:41, vmpstr wrote: > (drive-by) I mostly have nits. > > From the ...
3 years, 5 months ago (2017-07-17 21:32:07 UTC) #465
cblume
> From the other comments, it seems that this patch is getting close to landing. ...
3 years, 5 months ago (2017-07-18 10:23:49 UTC) #467
cblume
https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode15 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:15: SegmentStream::SegmentStream(SegmentStream&& rhs) On 2017/07/18 10:23:48, cblume wrote: > On ...
3 years, 5 months ago (2017-07-18 10:45:57 UTC) #470
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2140001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode257 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:257: if (!index) { On 2017/07/13 12:31:06, scroggo_chromium wrote: > ...
3 years, 5 months ago (2017-07-18 17:52:42 UTC) #473
vmpstr
https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode15 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:15: SegmentStream::SegmentStream(SegmentStream&& rhs) On 2017/07/18 10:45:57, cblume wrote: > On ...
3 years, 5 months ago (2017-07-18 18:02:48 UTC) #474
scroggo_chromium
> SkCodec provides the following benefits: > - SIMD optimized code for writing pixels > ...
3 years, 5 months ago (2017-07-18 21:10:10 UTC) #479
cblume
https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode15 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:15: SegmentStream::SegmentStream(SegmentStream&& rhs) On 2017/07/18 18:02:48, vmpstr wrote: > On ...
3 years, 5 months ago (2017-07-19 23:27:05 UTC) #481
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/2480001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode93 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:93: absolute_position = std::max(absolute_position, 0l); On 2017/07/19 23:27:04, cblume wrote: ...
3 years, 5 months ago (2017-07-20 13:59:52 UTC) #494
cblume
https://codereview.chromium.org/2565323003/diff/2600001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2600001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode241 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:241: bool oldAlpha = frame.HasAlpha(); On 2017/07/20 13:59:52, scroggo_chromium wrote: ...
3 years, 5 months ago (2017-07-20 21:53:45 UTC) #499
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2780001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2780001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode246 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:246: if (frame_buffer_cache_[previous_frame_index].GetStatus() != On 2017/07/20 21:53:45, cblume wrote: > ...
3 years, 5 months ago (2017-07-21 13:55:28 UTC) #504
cblume
https://codereview.chromium.org/2565323003/diff/2860001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2860001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode285 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:285: frame.SetHasAlpha(!SkAlphaTypeIsOpaque(frame_info.fAlphaType)); On 2017/07/21 13:55:27, scroggo_chromium wrote: > With this ...
3 years, 5 months ago (2017-07-21 16:37:08 UTC) #507
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2880001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2880001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode46 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:46: delete segment_stream_; I don't think we'll ever have a ...
3 years, 5 months ago (2017-07-21 17:49:01 UTC) #508
cblume
https://codereview.chromium.org/2565323003/diff/2880001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2880001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode46 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:46: delete segment_stream_; On 2017/07/21 17:49:01, scroggo_chromium wrote: > I ...
3 years, 5 months ago (2017-07-21 18:29:55 UTC) #509
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/2880001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2880001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode46 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:46: delete segment_stream_; On 2017/07/21 18:29:55, cblume wrote: > On ...
3 years, 5 months ago (2017-07-21 19:01:41 UTC) #512
cblume
https://codereview.chromium.org/2565323003/diff/2900001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2900001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode81 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:81: if (!codec_ || segment_stream_->IsCleared()) On 2017/07/21 19:01:41, scroggo_chromium wrote: ...
3 years, 5 months ago (2017-07-21 22:50:02 UTC) #515
cblume
https://codereview.chromium.org/2565323003/diff/2900001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2900001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode112 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:112: if (!codec_ || segment_stream_->IsCleared()) On 2017/07/21 19:01:41, scroggo_chromium wrote: ...
3 years, 5 months ago (2017-07-24 05:54:47 UTC) #518
scroggo_chromium
Sorry for the slow replies... I am out this week https://codereview.chromium.org/2565323003/diff/2900001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2900001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode112 ...
3 years, 5 months ago (2017-07-25 19:02:01 UTC) #521
cblume
https://codereview.chromium.org/2565323003/diff/2900001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/2900001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode112 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:112: if (!codec_ || segment_stream_->IsCleared()) On 2017/07/25 19:02:00, scroggo_chromium wrote: ...
3 years, 4 months ago (2017-07-26 07:43:30 UTC) #522
vmpstr
(ping) Is there any more progress on this?
3 years, 4 months ago (2017-08-07 23:00:35 UTC) #539
cblume
Leon was on vacation for the last two weeks. I believe he is back now.
3 years, 4 months ago (2017-08-07 23:15:29 UTC) #540
scroggo_chromium
On 2017/08/07 23:00:35, vmpstr wrote: > (ping) > > Is there any more progress on ...
3 years, 4 months ago (2017-08-07 23:24:29 UTC) #541
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode87 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:87: DCHECK_GT(offset, 0); In [1], vmpstr@ suggested that you "DCHECK ...
3 years, 4 months ago (2017-08-08 19:39:25 UTC) #542
cblume
https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode87 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:87: DCHECK_GT(offset, 0); On 2017/08/08 19:39:25, scroggo_chromium wrote: > In ...
3 years, 4 months ago (2017-08-09 17:29:29 UTC) #543
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode87 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:87: DCHECK_GT(offset, 0); On 2017/08/09 17:29:29, cblume wrote: > On ...
3 years, 4 months ago (2017-08-09 17:50:49 UTC) #546
cblume
https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode134 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:134: codec_->getFrameInfo(index, &frame_info); On 2017/08/09 17:50:48, scroggo_chromium wrote: > On ...
3 years, 4 months ago (2017-08-09 22:31:55 UTC) #549
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode134 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:134: codec_->getFrameInfo(index, &frame_info); On 2017/08/09 22:31:54, cblume wrote: > On ...
3 years, 4 months ago (2017-08-10 19:04:41 UTC) #550
cblume
https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode134 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:134: codec_->getFrameInfo(index, &frame_info); On 2017/08/10 19:04:41, scroggo_chromium wrote: > On ...
3 years, 4 months ago (2017-08-10 20:32:17 UTC) #551
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode134 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:134: codec_->getFrameInfo(index, &frame_info); On 2017/08/10 20:32:17, cblume wrote: > On ...
3 years, 4 months ago (2017-08-10 23:31:27 UTC) #552
cblume
https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3080001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode134 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:134: codec_->getFrameInfo(index, &frame_info); On 2017/08/10 23:31:26, scroggo_chromium wrote: > On ...
3 years, 4 months ago (2017-08-11 16:56:23 UTC) #553
cblume
https://codereview.chromium.org/2565323003/diff/3180001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3180001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: max_received_frame_index_ = kNotFound; On 2017/08/11 16:56:23, cblume wrote: > ...
3 years, 4 months ago (2017-08-11 17:33:57 UTC) #554
cblume
https://codereview.chromium.org/2565323003/diff/3180001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3180001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: max_received_frame_index_ = kNotFound; On 2017/08/11 17:33:56, cblume wrote: > ...
3 years, 4 months ago (2017-08-14 17:10:42 UTC) #559
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3180001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3180001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: max_received_frame_index_ = kNotFound; On 2017/08/11 16:56:23, cblume wrote: > ...
3 years, 4 months ago (2017-08-14 18:26:06 UTC) #560
cblume
https://codereview.chromium.org/2565323003/diff/3180001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3180001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode172 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:172: max_received_frame_index_ = kNotFound; On 2017/08/14 18:26:06, scroggo_chromium wrote: > ...
3 years, 4 months ago (2017-08-14 18:52:05 UTC) #561
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3240001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3240001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode165 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:165: return 0; I think this should return frame_buffer_cache_.size(), so ...
3 years, 4 months ago (2017-08-14 20:49:42 UTC) #564
cblume
https://codereview.chromium.org/2565323003/diff/3240001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp (right): https://codereview.chromium.org/2565323003/diff/3240001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp#newcode165 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp:165: return 0; On 2017/08/14 20:49:41, scroggo_chromium wrote: > I ...
3 years, 4 months ago (2017-08-14 23:07:26 UTC) #567
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3240001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h (right): https://codereview.chromium.org/2565323003/diff/3240001/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h#newcode82 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h:82: mutable int cached_repetition_count_ = kAnimationLoopOnce; On 2017/08/14 23:07:26, cblume ...
3 years, 4 months ago (2017-08-15 15:19:44 UTC) #572
cblume
https://codereview.chromium.org/2565323003/diff/3260001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/3260001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode98 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:98: has_read_all_contents_ = position_ >= reader_size; On 2017/08/15 15:19:44, scroggo_chromium ...
3 years, 4 months ago (2017-08-15 18:03:35 UTC) #573
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3340001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/3340001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode14 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:14: : reader_(std::move(rhs.reader_)), position_(rhs.position_) {} Can this just be = ...
3 years, 4 months ago (2017-08-15 19:57:32 UTC) #576
cblume
https://codereview.chromium.org/2565323003/diff/3340001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/3340001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode14 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:14: : reader_(std::move(rhs.reader_)), position_(rhs.position_) {} On 2017/08/15 19:57:31, scroggo_chromium wrote: ...
3 years, 4 months ago (2017-08-16 07:49:16 UTC) #579
scroggo_chromium
https://codereview.chromium.org/2565323003/diff/3340001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/3340001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode34 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:34: if (IsCleared()) On 2017/08/16 07:49:16, cblume wrote: > On ...
3 years, 4 months ago (2017-08-16 13:46:41 UTC) #584
cblume
https://codereview.chromium.org/2565323003/diff/3340001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp File third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp (right): https://codereview.chromium.org/2565323003/diff/3340001/third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp#newcode34 third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp:34: if (IsCleared()) On 2017/08/16 13:46:40, scroggo_chromium wrote: > On ...
3 years, 4 months ago (2017-08-16 17:02:02 UTC) #589
scroggo_chromium
> BTW, the reason I wasn't using =default before is because it requires this patch ...
3 years, 4 months ago (2017-08-16 17:38:09 UTC) #590
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565323003/3500001
3 years, 4 months ago (2017-08-17 17:09:26 UTC) #597
commit-bot: I haz the power
3 years, 4 months ago (2017-08-17 18:20:05 UTC) #601
Message was sent while issue was closed.
Committed patchset #176 (id:3500001) as
https://chromium.googlesource.com/chromium/src/+/4fed3346549a90c0de40c02f6388...

Powered by Google App Engine
This is Rietveld 408576698