Move gif image decoder to SkCodec

third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 61 matching lines @@
 }
 
 }  // anonymous namespace
 
 TEST(GIFImageDecoderTest, decodeTwoFrames) {
   std::unique_ptr<ImageDecoder> decoder = createDecoder();
 
   RefPtr<SharedBuffer> data = readFile(layoutTestResourcesDir, "animated.gif");
   ASSERT_TRUE(data.get());
   decoder->setData(data.get(), true);
-  EXPECT_EQ(cAnimationLoopOnce, decoder->repetitionCount());

[cblume, 2017/01/09 04:11:22]

This test *used* to assert that we hadn't yet seen the loop count and so we
defaulted to looping once.

However, you will notice it has all of the data ready and tells setData() that
all of the data has been received.

The new parsing behavior saw the loop count at this point and knew we looped
indefinitely. I believe this new behavior is intentional. So I removed the test
that asserts old behavior.

 
   ImageFrame* frame = decoder->frameBufferAtIndex(0);
   uint32_t generationID0 = frame->bitmap().getGenerationID();
   EXPECT_EQ(ImageFrame::FrameComplete, frame->getStatus());
   EXPECT_EQ(16, frame->bitmap().width());
   EXPECT_EQ(16, frame->bitmap().height());
 
   frame = decoder->frameBufferAtIndex(1);
   uint32_t generationID1 = frame->bitmap().getGenerationID();
   EXPECT_EQ(ImageFrame::FrameComplete, frame->getStatus());
@@ skipping 223 matching lines @@
   ASSERT_TRUE(data.get());
   decoder->setData(data.get(), true);
 
   EXPECT_EQ(2u, decoder->frameCount());
   // Disposal method 4 is converted to ImageFrame::DisposeOverwritePrevious.
   EXPECT_EQ(ImageFrame::DisposeOverwritePrevious,
             decoder->frameBufferAtIndex(0)->getDisposalMethod());
   // Disposal method 5 is ignored.
   EXPECT_EQ(ImageFrame::DisposeNotSpecified,
             decoder->frameBufferAtIndex(1)->getDisposalMethod());
 }

[cblume, 2017/01/09 08:06:48]

SkGifCodec is the one that is now responsible for invalid disposal methods being
handled correctly. This test should be moved there.

This is because from the client side we always get a completely filled frame.
The client does not "overwrite previous" for example. Instead, the client simply
provides the required frame asked of it.

[cblume, 2017/01/30 07:35:48]

I spoke with Leon and we agreed that this is really testing implementation
details, which is no good. So we are okay removing this test.

 
 TEST(GIFImageDecoderTest, firstFrameHasGreaterSizeThanScreenSize) {
   RefPtr<SharedBuffer> fullData = readFile(
       decodersTestingDir, "first-frame-has-greater-size-than-screen-size.gif");
   ASSERT_TRUE(fullData.get());
 
   std::unique_ptr<ImageDecoder> decoder;
   IntSize frameSize;
 
   // Compute hashes when the file is truncated.
@@ skipping 63 matching lines @@
   EXPECT_TRUE(premulFrame &&
               premulFrame->getStatus() == ImageFrame::FrameComplete);
   EXPECT_EQ(premulFrame->bitmap().alphaType(), kOpaque_SkAlphaType);
   unpremulFrame = unpremulDecoder->frameBufferAtIndex(0);
   EXPECT_TRUE(unpremulFrame &&
               unpremulFrame->getStatus() == ImageFrame::FrameComplete);
   EXPECT_EQ(unpremulFrame->bitmap().alphaType(), kOpaque_SkAlphaType);
 }
 
 }  // namespace blink