Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

Issue 2565323003: Move gif image decoder to SkCodec (Closed)
Patch Set: Explicitly specify move ctor / assignment until required patch lands. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 ImageDecoder::kNoDecodedImageByteLimit)); 52 ImageDecoder::kNoDecodedImageByteLimit));
53 } 53 }
54 54
55 void TestRepetitionCount(const char* dir, 55 void TestRepetitionCount(const char* dir,
56 const char* file, 56 const char* file,
57 int expected_repetition_count) { 57 int expected_repetition_count) {
58 std::unique_ptr<ImageDecoder> decoder = CreateDecoder(); 58 std::unique_ptr<ImageDecoder> decoder = CreateDecoder();
59 RefPtr<SharedBuffer> data = ReadFile(dir, file); 59 RefPtr<SharedBuffer> data = ReadFile(dir, file);
60 ASSERT_TRUE(data.Get()); 60 ASSERT_TRUE(data.Get());
61 decoder->SetData(data.Get(), true); 61 decoder->SetData(data.Get(), true);
62 EXPECT_EQ(kAnimationLoopOnce,
63 decoder->RepetitionCount()); // Default value before decode.
64 62
65 for (size_t i = 0; i < decoder->FrameCount(); ++i) { 63 EXPECT_EQ(expected_repetition_count, decoder->RepetitionCount());
66 ImageFrame* frame = decoder->DecodeFrameBufferAtIndex(i);
67 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
68 }
69
70 EXPECT_EQ(expected_repetition_count,
71 decoder->RepetitionCount()); // Expected value after decode.
72 } 64 }
73 65
74 } // anonymous namespace 66 } // anonymous namespace
75 67
76 TEST(GIFImageDecoderTest, decodeTwoFrames) { 68 TEST(GIFImageDecoderTest, decodeTwoFrames) {
77 std::unique_ptr<ImageDecoder> decoder = CreateDecoder(); 69 std::unique_ptr<ImageDecoder> decoder = CreateDecoder();
78 70
79 RefPtr<SharedBuffer> data = ReadFile(kLayoutTestResourcesDir, "animated.gif"); 71 RefPtr<SharedBuffer> data = ReadFile(kLayoutTestResourcesDir, "animated.gif");
80 ASSERT_TRUE(data.Get()); 72 ASSERT_TRUE(data.Get());
81 decoder->SetData(data.Get(), true); 73 decoder->SetData(data.Get(), true);
82 EXPECT_EQ(kAnimationLoopOnce, decoder->RepetitionCount());
83 74
84 ImageFrame* frame = decoder->DecodeFrameBufferAtIndex(0); 75 ImageFrame* frame = decoder->DecodeFrameBufferAtIndex(0);
85 uint32_t generation_id0 = frame->Bitmap().getGenerationID(); 76 uint32_t generation_id0 = frame->Bitmap().getGenerationID();
86 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus()); 77 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
87 EXPECT_EQ(16, frame->Bitmap().width()); 78 EXPECT_EQ(16, frame->Bitmap().width());
88 EXPECT_EQ(16, frame->Bitmap().height()); 79 EXPECT_EQ(16, frame->Bitmap().height());
89 80
90 frame = decoder->DecodeFrameBufferAtIndex(1); 81 frame = decoder->DecodeFrameBufferAtIndex(1);
91 uint32_t generation_id1 = frame->Bitmap().getGenerationID(); 82 uint32_t generation_id1 = frame->Bitmap().getGenerationID();
92 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus()); 83 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
93 EXPECT_EQ(16, frame->Bitmap().width()); 84 EXPECT_EQ(16, frame->Bitmap().width());
94 EXPECT_EQ(16, frame->Bitmap().height()); 85 EXPECT_EQ(16, frame->Bitmap().height());
95 EXPECT_TRUE(generation_id0 != generation_id1); 86 EXPECT_TRUE(generation_id0 != generation_id1);
96 87
97 EXPECT_EQ(2u, decoder->FrameCount()); 88 EXPECT_EQ(2u, decoder->FrameCount());
98 EXPECT_EQ(kAnimationLoopInfinite, decoder->RepetitionCount()); 89 EXPECT_EQ(kAnimationLoopInfinite, decoder->RepetitionCount());
99 } 90 }
100 91
101 TEST(GIFImageDecoderTest, parseAndDecode) { 92 TEST(GIFImageDecoderTest, parseAndDecode) {
102 std::unique_ptr<ImageDecoder> decoder = CreateDecoder(); 93 std::unique_ptr<ImageDecoder> decoder = CreateDecoder();
103 94
104 RefPtr<SharedBuffer> data = ReadFile(kLayoutTestResourcesDir, "animated.gif"); 95 RefPtr<SharedBuffer> data = ReadFile(kLayoutTestResourcesDir, "animated.gif");
105 ASSERT_TRUE(data.Get()); 96 ASSERT_TRUE(data.Get());
106 decoder->SetData(data.Get(), true); 97 decoder->SetData(data.Get(), true);
107 EXPECT_EQ(kAnimationLoopOnce, decoder->RepetitionCount());
108
109 // This call will parse the entire file.
110 EXPECT_EQ(2u, decoder->FrameCount());
111 98
112 ImageFrame* frame = decoder->DecodeFrameBufferAtIndex(0); 99 ImageFrame* frame = decoder->DecodeFrameBufferAtIndex(0);
113 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus()); 100 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
114 EXPECT_EQ(16, frame->Bitmap().width()); 101 EXPECT_EQ(16, frame->Bitmap().width());
115 EXPECT_EQ(16, frame->Bitmap().height()); 102 EXPECT_EQ(16, frame->Bitmap().height());
116 103
117 frame = decoder->DecodeFrameBufferAtIndex(1); 104 frame = decoder->DecodeFrameBufferAtIndex(1);
118 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus()); 105 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
119 EXPECT_EQ(16, frame->Bitmap().width()); 106 EXPECT_EQ(16, frame->Bitmap().width());
120 EXPECT_EQ(16, frame->Bitmap().height()); 107 EXPECT_EQ(16, frame->Bitmap().height());
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 std::unique_ptr<ImageDecoder> decoder = CreateDecoder(); 301 std::unique_ptr<ImageDecoder> decoder = CreateDecoder();
315 302
316 // The image has 2 frames, with disposal method 4 and 5, respectively. 303 // The image has 2 frames, with disposal method 4 and 5, respectively.
317 RefPtr<SharedBuffer> data = 304 RefPtr<SharedBuffer> data =
318 ReadFile(kDecodersTestingDir, "invalid-disposal-method.gif"); 305 ReadFile(kDecodersTestingDir, "invalid-disposal-method.gif");
319 ASSERT_TRUE(data.Get()); 306 ASSERT_TRUE(data.Get());
320 decoder->SetData(data.Get(), true); 307 decoder->SetData(data.Get(), true);
321 308
322 EXPECT_EQ(2u, decoder->FrameCount()); 309 EXPECT_EQ(2u, decoder->FrameCount());
323 // Disposal method 4 is converted to ImageFrame::DisposeOverwritePrevious. 310 // Disposal method 4 is converted to ImageFrame::DisposeOverwritePrevious.
311 // This is because some specs say method 3 is "overwrite previous", while
312 // others say setting the third bit (i.e. method 4) is.
324 EXPECT_EQ(ImageFrame::kDisposeOverwritePrevious, 313 EXPECT_EQ(ImageFrame::kDisposeOverwritePrevious,
325 decoder->DecodeFrameBufferAtIndex(0)->GetDisposalMethod()); 314 decoder->DecodeFrameBufferAtIndex(0)->GetDisposalMethod());
326 // Disposal method 5 is ignored. 315 // Unknown disposal methods (5 in this case) are converted to
327 EXPECT_EQ(ImageFrame::kDisposeNotSpecified, 316 // ImageFrame::DisposeKeep.
317 EXPECT_EQ(ImageFrame::kDisposeKeep,
328 decoder->DecodeFrameBufferAtIndex(1)->GetDisposalMethod()); 318 decoder->DecodeFrameBufferAtIndex(1)->GetDisposalMethod());
329 } 319 }
330 320
331 TEST(GIFImageDecoderTest, firstFrameHasGreaterSizeThanScreenSize) { 321 TEST(GIFImageDecoderTest, firstFrameHasGreaterSizeThanScreenSize) {
332 const Vector<char> full_data = 322 const Vector<char> full_data =
333 ReadFile(kDecodersTestingDir, 323 ReadFile(kDecodersTestingDir,
334 "first-frame-has-greater-size-than-screen-size.gif") 324 "first-frame-has-greater-size-than-screen-size.gif")
335 ->Copy(); 325 ->Copy();
336 326
337 std::unique_ptr<ImageDecoder> decoder; 327 std::unique_ptr<ImageDecoder> decoder;
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 374
385 // Partially decoded frame => the frame alpha type is unknown and should 375 // Partially decoded frame => the frame alpha type is unknown and should
386 // reflect the requested format. 376 // reflect the requested format.
387 premul_decoder->SetData(partial_data.Get(), false); 377 premul_decoder->SetData(partial_data.Get(), false);
388 ASSERT_TRUE(premul_decoder->FrameCount()); 378 ASSERT_TRUE(premul_decoder->FrameCount());
389 unpremul_decoder->SetData(partial_data.Get(), false); 379 unpremul_decoder->SetData(partial_data.Get(), false);
390 ASSERT_TRUE(unpremul_decoder->FrameCount()); 380 ASSERT_TRUE(unpremul_decoder->FrameCount());
391 ImageFrame* premul_frame = premul_decoder->DecodeFrameBufferAtIndex(0); 381 ImageFrame* premul_frame = premul_decoder->DecodeFrameBufferAtIndex(0);
392 EXPECT_TRUE(premul_frame && 382 EXPECT_TRUE(premul_frame &&
393 premul_frame->GetStatus() != ImageFrame::kFrameComplete); 383 premul_frame->GetStatus() != ImageFrame::kFrameComplete);
394 EXPECT_EQ(premul_frame->Bitmap().alphaType(), kPremul_SkAlphaType); 384 EXPECT_EQ(kPremul_SkAlphaType, premul_frame->Bitmap().alphaType());
395 ImageFrame* unpremul_frame = unpremul_decoder->DecodeFrameBufferAtIndex(0); 385 ImageFrame* unpremul_frame = unpremul_decoder->DecodeFrameBufferAtIndex(0);
396 EXPECT_TRUE(unpremul_frame && 386 EXPECT_TRUE(unpremul_frame &&
397 unpremul_frame->GetStatus() != ImageFrame::kFrameComplete); 387 unpremul_frame->GetStatus() != ImageFrame::kFrameComplete);
398 EXPECT_EQ(unpremul_frame->Bitmap().alphaType(), kUnpremul_SkAlphaType); 388 EXPECT_EQ(kUnpremul_SkAlphaType, unpremul_frame->Bitmap().alphaType());
399 389
400 // Fully decoded frame => the frame alpha type is known (opaque). 390 // Fully decoded frame => the frame alpha type is known (opaque).
401 premul_decoder->SetData(full_data_buffer.Get(), true); 391 premul_decoder->SetData(full_data_buffer.Get(), true);
402 ASSERT_TRUE(premul_decoder->FrameCount()); 392 ASSERT_TRUE(premul_decoder->FrameCount());
403 unpremul_decoder->SetData(full_data_buffer.Get(), true); 393 unpremul_decoder->SetData(full_data_buffer.Get(), true);
404 ASSERT_TRUE(unpremul_decoder->FrameCount()); 394 ASSERT_TRUE(unpremul_decoder->FrameCount());
405 premul_frame = premul_decoder->DecodeFrameBufferAtIndex(0); 395 premul_frame = premul_decoder->DecodeFrameBufferAtIndex(0);
406 EXPECT_TRUE(premul_frame && 396 EXPECT_TRUE(premul_frame &&
407 premul_frame->GetStatus() == ImageFrame::kFrameComplete); 397 premul_frame->GetStatus() == ImageFrame::kFrameComplete);
408 EXPECT_EQ(premul_frame->Bitmap().alphaType(), kOpaque_SkAlphaType); 398 EXPECT_EQ(kOpaque_SkAlphaType, premul_frame->Bitmap().alphaType());
409 unpremul_frame = unpremul_decoder->DecodeFrameBufferAtIndex(0); 399 unpremul_frame = unpremul_decoder->DecodeFrameBufferAtIndex(0);
410 EXPECT_TRUE(unpremul_frame && 400 EXPECT_TRUE(unpremul_frame &&
411 unpremul_frame->GetStatus() == ImageFrame::kFrameComplete); 401 unpremul_frame->GetStatus() == ImageFrame::kFrameComplete);
412 EXPECT_EQ(unpremul_frame->Bitmap().alphaType(), kOpaque_SkAlphaType); 402 EXPECT_EQ(kOpaque_SkAlphaType, unpremul_frame->Bitmap().alphaType());
413 } 403 }
414 404
415 namespace { 405 namespace {
416 // Needed to exercise ImageDecoder::SetMemoryAllocator, but still does the 406 // Needed to exercise ImageDecoder::SetMemoryAllocator, but still does the
417 // default allocation. 407 // default allocation.
418 class Allocator final : public SkBitmap::Allocator { 408 class Allocator final : public SkBitmap::Allocator {
419 bool allocPixelRef(SkBitmap* dst) override { return dst->tryAllocPixels(); } 409 bool allocPixelRef(SkBitmap* dst) override { return dst->tryAllocPixels(); }
420 }; 410 };
421 } 411 }
422 412
(...skipping 11 matching lines...) Expand all
434 EXPECT_EQ(1u, decoder->FrameCount()); 424 EXPECT_EQ(1u, decoder->FrameCount());
435 ImageFrame* frame = decoder->DecodeFrameBufferAtIndex(0); 425 ImageFrame* frame = decoder->DecodeFrameBufferAtIndex(0);
436 decoder->SetMemoryAllocator(nullptr); 426 decoder->SetMemoryAllocator(nullptr);
437 427
438 ASSERT_TRUE(frame); 428 ASSERT_TRUE(frame);
439 EXPECT_EQ(IntRect(IntPoint(), decoder->Size()), frame->OriginalFrameRect()); 429 EXPECT_EQ(IntRect(IntPoint(), decoder->Size()), frame->OriginalFrameRect());
440 EXPECT_FALSE(frame->HasAlpha()); 430 EXPECT_FALSE(frame->HasAlpha());
441 } 431 }
442 432
443 } // namespace blink 433 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698