Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

Issue 2565323003: Move gif image decoder to SkCodec (Closed)
Patch Set: fix peek() reading the wrong size -- now passing GIFImageDecoderTest.progressiveDecode Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "platform/image-decoders/gif/GIFImageDecoder.h" 26 #include "platform/image-decoders/gif/GIFImageDecoder.h"
27 27
28 #include "platform/image-decoders/gif/GIFImageReader.h" 28 #include "third_party/skia/include/core/SkImageInfo.h"
29 #include "wtf/NotFound.h" 29 #include "wtf/NotFound.h"
30 #include "wtf/PtrUtil.h" 30 #include "wtf/PtrUtil.h"
31 #include <limits> 31 #include <limits>
32 32
33 namespace blink { 33 namespace blink {
34 34
35 GIFImageDecoder::GIFImageDecoder(AlphaOption alphaOption, 35 GIFImageDecoder::GIFImageDecoder(AlphaOption alphaOption,
36 const ColorBehavior& colorBehavior, 36 const ColorBehavior& colorBehavior,
37 size_t maxDecodedBytes) 37 size_t maxDecodedBytes)
38 : ImageDecoder(alphaOption, colorBehavior, maxDecodedBytes), 38 : ImageDecoder(alphaOption, colorBehavior, maxDecodedBytes),
39 m_repetitionCount(cAnimationLoopOnce) {} 39 m_codec(),
40 40 m_segmentStream(nullptr) {}
41 GIFImageDecoder::~GIFImageDecoder() {} 41
42 GIFImageDecoder::~GIFImageDecoder() {
43 if (!m_codec) {
44 // if we did not create m_codec and thus did not pass ownership to it
45 if (m_segmentStream) {
46 delete m_segmentStream;
47 }
48 }
49 }
42 50
43 void GIFImageDecoder::onSetData(SegmentReader* data) { 51 void GIFImageDecoder::onSetData(SegmentReader* data) {
44 if (m_reader) 52 if (!data) {
45 m_reader->setData(data); 53 return;
54 }
55
56 if (!m_segmentStream) {
57 m_segmentStream = new SegmentStream();
58 }
59
60 if (!m_segmentStream) {
61 return;
62 }
63
64 m_segmentStream->setReader(data, isAllDataReceived());
65
66 // If we don't have a SkCodec yet, create one from the stream
67 if (!m_codec) {
68 SkCodec* temp = SkCodec::NewFromStream(m_segmentStream);
cblume 2017/01/09 04:11:22 "temp" was a bad name.
69 if (temp) {
70 m_codec.reset(temp);
71 } else {
72 // m_segmentStream's ownership is passed. It is deleted if SkCodec
73 // creation fails. In this case, release our reference so we can create a
74 // new SegmentStream later.
75 m_segmentStream = nullptr;
76 return;
77 }
78
79 // SkCodec::NewFromStream will read enough of the image to get the image
80 // size.
81 SkImageInfo imageInfo = m_codec->getInfo();
82 setSize(imageInfo.width(), imageInfo.height());
83 }
46 } 84 }
47 85
48 int GIFImageDecoder::repetitionCount() const { 86 int GIFImageDecoder::repetitionCount() const {
87 if (!m_codec) {
88 return 0;
89 }
90
49 // This value can arrive at any point in the image data stream. Most GIFs 91 // This value can arrive at any point in the image data stream. Most GIFs
50 // in the wild declare it near the beginning of the file, so it usually is 92 // in the wild declare it near the beginning of the file, so it usually is
51 // set by the time we've decoded the size, but (depending on the GIF and the 93 // set by the time we've decoded the size, but (depending on the GIF and the
52 // packets sent back by the webserver) not always. If the reader hasn't 94 // packets sent back by the webserver) not always.
53 // seen a loop count yet, it will return cLoopCountNotSeen, in which case we
54 // should default to looping once (the initial value for
55 // |m_repetitionCount|).
56 // 95 //
57 // There are some additional wrinkles here. First, ImageSource::clear() 96 // SkCodec will parse forward in the file if the repetition count has not been
58 // may destroy the reader, making the result from the reader _less_ 97 // seen yet.
59 // authoritative on future calls if the recreated reader hasn't seen the 98
60 // loop count. We don't need to special-case this because in this case the 99 int repetitionCount = m_codec->getRepetitionCount();
61 // new reader will once again return cLoopCountNotSeen, and we won't 100 switch (repetitionCount) {
62 // overwrite the cached correct value. 101 case 0:
63 // 102 return cAnimationNone;
64 // Second, a GIF might never set a loop count at all, in which case we 103 case SkCodec::kRepetitionCountInfinite:
65 // should continue to treat it as a "loop once" animation. We don't need 104 return cAnimationLoopInfinite;
66 // special code here either, because in this case we'll never change 105 default:
67 // |m_repetitionCount| from its default value. 106 return repetitionCount;
68 // 107 }
69 // Third, we use the same GIFImageReader for counting frames and we might
70 // see the loop count and then encounter a decoding error which happens
71 // later in the stream. It is also possible that no frames are in the
72 // stream. In these cases we should just loop once.
73 if (isAllDataReceived() && parseCompleted() && m_reader->imagesCount() == 1)
74 m_repetitionCount = cAnimationNone;
75 else if (failed() || (m_reader && (!m_reader->imagesCount())))
76 m_repetitionCount = cAnimationLoopOnce;
77 else if (m_reader && m_reader->loopCount() != cLoopCountNotSeen)
78 m_repetitionCount = m_reader->loopCount();
79 return m_repetitionCount;
80 } 108 }
81 109
82 bool GIFImageDecoder::frameIsCompleteAtIndex(size_t index) const { 110 bool GIFImageDecoder::frameIsCompleteAtIndex(size_t index) const {
83 return m_reader && (index < m_reader->imagesCount()) && 111 if (!m_codec) {
84 m_reader->frameContext(index)->isComplete(); 112 return false;
113 }
114
115 std::vector<SkCodec::FrameInfo> frameInfos = m_codec->getFrameInfo();
116 if (frameInfos.size() <= index) {
117 return false;
118 }
119
120 return frameInfos[index].fFullyReceived;
85 } 121 }
86 122
87 float GIFImageDecoder::frameDurationAtIndex(size_t index) const { 123 float GIFImageDecoder::frameDurationAtIndex(size_t index) const {
88 return (m_reader && (index < m_reader->imagesCount()) && 124 if (!m_codec) {
89 m_reader->frameContext(index)->isHeaderDefined()) 125 return 0;
90 ? m_reader->frameContext(index)->delayTime() 126 }
91 : 0; 127
92 } 128 std::vector<SkCodec::FrameInfo> frameInfos = m_codec->getFrameInfo();
93 129 if (frameInfos.size() <= index) {
94 bool GIFImageDecoder::setFailed() { 130 return 0;
95 m_reader.reset(); 131 }
96 return ImageDecoder::setFailed(); 132
97 } 133 return frameInfos[index].fDuration;
98 134 }
99 bool GIFImageDecoder::haveDecodedRow(size_t frameIndex, 135
100 GIFRow::const_iterator rowBegin, 136 size_t GIFImageDecoder::decodeFrameCount() {
101 size_t width, 137 if (!m_codec) {
102 size_t rowNumber, 138 // We haven't yet successfully created the codec. Assume only 1 frame.
103 unsigned repeatCount, 139 return 1;
104 bool writeTransparentPixels) { 140 }
105 const GIFFrameContext* frameContext = m_reader->frameContext(frameIndex); 141
106 // The pixel data and coordinates supplied to us are relative to the frame's 142 std::vector<SkCodec::FrameInfo> frameInfos = m_codec->getFrameInfo();
107 // origin within the entire image size, i.e. 143 return frameInfos.size();
108 // (frameContext->xOffset, frameContext->yOffset). There is no guarantee 144 }
109 // that width == (size().width() - frameContext->xOffset), so 145
110 // we must ensure we don't run off the end of either the source data or the 146 void GIFImageDecoder::initializeNewFrame(size_t index) {
111 // row's X-coordinates. 147 if (!m_codec) {
112 const int xBegin = frameContext->xOffset(); 148 return;
113 const int yBegin = frameContext->yOffset() + rowNumber; 149 }
114 const int xEnd = std::min(static_cast<int>(frameContext->xOffset() + width), 150
115 size().width()); 151 ImageFrame& frame = m_frameBufferCache[index];
116 const int yEnd = std::min( 152 std::vector<SkCodec::FrameInfo> frameInfos = m_codec->getFrameInfo();
117 static_cast<int>(frameContext->yOffset() + rowNumber + repeatCount), 153
118 size().height()); 154 // FIXME We may not need to fill in all this frame information.
119 if (!width || (xBegin < 0) || (yBegin < 0) || (xEnd <= xBegin) || 155 // SkCodec doesn't need it. Check if Blink uses it at all.
120 (yEnd <= yBegin)) 156 // If Blink does use it, maybe SkCodec can provide it to us.
121 return true; 157 IntSize frameSize = size();
122 158 frame.setOriginalFrameRect(IntRect(IntPoint(), frameSize));
123 const GIFColorMap::Table& colorTable = 159 frame.setSizeAndColorSpace(frameSize.width(), frameSize.height(),
124 frameContext->localColorMap().isDefined() 160 colorSpaceForSkImages());
125 ? frameContext->localColorMap().getTable() 161 frame.setDuration(frameInfos[index].fDuration);
126 : m_reader->globalColorMap().getTable(); 162 // The disposal method is not required any more, but is left in place
127 163 // for the other image decoders that do not yet rely on SkCodec.
128 if (colorTable.isEmpty()) 164 // For now, fill it with DisposeKeep.
129 return true; 165 frame.setDisposalMethod(ImageFrame::DisposeKeep);
130 166 size_t requiredPreviousFrame = frameInfos[index].fRequiredFrame;
131 GIFColorMap::Table::const_iterator colorTableIter = colorTable.begin(); 167 if (requiredPreviousFrame == SkCodec::kNone) {
132 168 requiredPreviousFrame = WTF::kNotFound;
133 // Initialize the frame if necessary. 169 }
134 ImageFrame& buffer = m_frameBufferCache[frameIndex]; 170 frame.setRequiredPreviousFrameIndex(requiredPreviousFrame);
135 if (!initFrameBuffer(frameIndex)) 171 }
136 return false; 172
137 173 void GIFImageDecoder::decode(size_t index) {
138 const size_t transparentPixel = frameContext->transparentPixel(); 174 if (!m_codec) {
139 GIFRow::const_iterator rowEnd = rowBegin + (xEnd - xBegin); 175 return;
140 ImageFrame::PixelData* currentAddress = buffer.getAddr(xBegin, yBegin); 176 }
141 177
142 // We may or may not need to write transparent pixels to the buffer. 178 if (m_frameBufferCache.size() <= index) {
143 // If we're compositing against a previous image, it's wrong, and if 179 // It is a fatal error if all data is received and we have decoded all
144 // we're writing atop a cleared, fully transparent buffer, it's 180 // frames available but the file is truncated.
145 // unnecessary; but if we're decoding an interlaced gif and 181 if (isAllDataReceived()) {
146 // displaying it "Haeberli"-style, we must write these for passes 182 setFailed();
147 // beyond the first, or the initial passes will "show through" the 183 }
148 // later ones. 184
149 // 185 return;
150 // The loops below are almost identical. One writes a transparent pixel 186 }
151 // and one doesn't based on the value of |writeTransparentPixels|. 187
152 // The condition check is taken out of the loop to enhance performance. 188 updateAggressivePurging(index);
153 // This optimization reduces decoding time by about 15% for a 3MB image. 189
154 if (writeTransparentPixels) { 190 SkImageInfo imageInfo = m_codec->getInfo().makeColorType(kN32_SkColorType);
155 for (; rowBegin != rowEnd; ++rowBegin, ++currentAddress) { 191
156 const size_t sourceValue = *rowBegin; 192 ImageFrame& frame = m_frameBufferCache[index];
157 if ((sourceValue != transparentPixel) && 193 size_t requiredPreviousFrameIndex = frame.requiredPreviousFrameIndex();
158 (sourceValue < colorTable.size())) { 194
159 *currentAddress = colorTableIter[sourceValue]; 195 SkCodec::Options options;
160 } else { 196 options.fFrameIndex = index;
161 *currentAddress = 0; 197 options.fHasPriorFrame = false;
162 m_currentBufferSawAlpha = true; 198 if (requiredPreviousFrameIndex != WTF::kNotFound) {
199 options.fHasPriorFrame = true;
200 }
201
202 if (frame.getStatus() == ImageFrame::FrameEmpty) {
203 SkCodec::Result startIncrementalDecodeResult =
204 m_codec->startIncrementalDecode(imageInfo, frame.bitmap().getPixels(),
205 frame.bitmap().rowBytes(), &options,
206 nullptr, nullptr);
207 switch (startIncrementalDecodeResult) {
208 case SkCodec::kSuccess:
209 break;
210 case SkCodec::kIncompleteInput:
211 return;
212 default:
213 setFailed();
214 return;
215 }
216
217 if (requiredPreviousFrameIndex != WTF::kNotFound) {
218 ImageFrame& requiredPreviousFrame =
219 m_frameBufferCache[requiredPreviousFrameIndex];
220
221 // We try to reuse |requiredPreviousFrame| as starting state to avoid
222 // copying. If canReusePreviousFrameBuffer returns false, we must copy
223 // the data since |requiredPreviousFrame| is necessary to decode this
224 // or later frames. In that case copy the data instead.
225 if ((!canReusePreviousFrameBuffer(index) ||
226 !frame.takeBitmapDataIfWritable(&requiredPreviousFrame)) &&
227 !frame.copyBitmapData(requiredPreviousFrame)) {
228 setFailed();
229 return;
163 } 230 }
164 } 231 }
165 } else { 232 }
166 for (; rowBegin != rowEnd; ++rowBegin, ++currentAddress) { 233
167 const size_t sourceValue = *rowBegin; 234 int rowsDecoded = 0;
168 if ((sourceValue != transparentPixel) && 235 SkCodec::Result incrementalDecodeResult =
169 (sourceValue < colorTable.size())) 236 m_codec->incrementalDecode(&rowsDecoded);
170 *currentAddress = colorTableIter[sourceValue]; 237 switch (incrementalDecodeResult) {
171 else 238 case SkCodec::kSuccess:
172 m_currentBufferSawAlpha = true; 239 frame.setStatus(ImageFrame::FrameComplete);
173 } 240 break;
174 } 241 case SkCodec::kIncompleteInput:
175 242 if (frame.getStatus() == ImageFrame::FrameEmpty && index == 0) {
176 // Tell the frame to copy the row data if need be. 243 // We want to display the bit of the frame we have decoded only if it is
177 if (repeatCount > 1) 244 // the first frame of an animation. That means we need to fill the rest
178 buffer.copyRowNTimes(xBegin, xEnd, yBegin, yEnd); 245 // of the image with transparent.
179 246 IntRect remainingRect = frame.originalFrameRect();
180 buffer.setPixelsChanged(true); 247 remainingRect.setHeight(remainingRect.height() - rowsDecoded);
181 return true; 248 frame.zeroFillFrameRect(remainingRect);
182 } 249 }
183 250
184 bool GIFImageDecoder::parseCompleted() const { 251 frame.setStatus(ImageFrame::FramePartial);
185 return m_reader && m_reader->parseCompleted(); 252 break;
186 } 253 default:
187
188 bool GIFImageDecoder::frameComplete(size_t frameIndex) {
189 // Initialize the frame if necessary. Some GIFs insert do-nothing frames,
190 // in which case we never reach haveDecodedRow() before getting here.
191 if (!initFrameBuffer(frameIndex))
192 return false; // initFrameBuffer() has already called setFailed().
193
194 m_frameBufferCache[frameIndex].setStatus(ImageFrame::FrameComplete);
195 if (!m_currentBufferSawAlpha)
196 correctAlphaWhenFrameBufferSawNoAlpha(frameIndex);
197
198 return true;
199 }
200
201 void GIFImageDecoder::clearFrameBuffer(size_t frameIndex) {
202 if (m_reader &&
203 m_frameBufferCache[frameIndex].getStatus() == ImageFrame::FramePartial) {
204 // Reset the state of the partial frame in the reader so that the frame
205 // can be decoded again when requested.
206 m_reader->clearDecodeState(frameIndex);
207 }
208 ImageDecoder::clearFrameBuffer(frameIndex);
209 }
210
211 size_t GIFImageDecoder::decodeFrameCount() {
212 parse(GIFFrameCountQuery);
213 // If decoding fails, |m_reader| will have been destroyed. Instead of
214 // returning 0 in this case, return the existing number of frames. This way
215 // if we get halfway through the image before decoding fails, we won't
216 // suddenly start reporting that the image has zero frames.
217 return failed() ? m_frameBufferCache.size() : m_reader->imagesCount();
218 }
219
220 void GIFImageDecoder::initializeNewFrame(size_t index) {
221 ImageFrame* buffer = &m_frameBufferCache[index];
222 const GIFFrameContext* frameContext = m_reader->frameContext(index);
223 buffer->setOriginalFrameRect(
224 intersection(frameContext->frameRect(), IntRect(IntPoint(), size())));
225 buffer->setDuration(frameContext->delayTime());
226 buffer->setDisposalMethod(frameContext->getDisposalMethod());
227 buffer->setRequiredPreviousFrameIndex(
228 findRequiredPreviousFrame(index, false));
229 }
230
231 void GIFImageDecoder::decode(size_t index) {
232 parse(GIFFrameCountQuery);
233
234 if (failed())
235 return;
236
237 updateAggressivePurging(index);
238
239 Vector<size_t> framesToDecode = findFramesToDecode(index);
240 for (auto i = framesToDecode.rbegin(); i != framesToDecode.rend(); ++i) {
241 if (!m_reader->decode(*i)) {
242 setFailed(); 254 setFailed();
243 return; 255 return;
244 } 256 }
245 257
246 // If this returns false, we need more data to continue decoding. 258 if (!postDecodeProcessing(index)) {
247 if (!postDecodeProcessing(*i)) 259 return;
248 break; 260 }
249 } 261 }
250 262
251 // It is also a fatal error if all data is received and we have decoded all 263 bool GIFImageDecoder::canReusePreviousFrameBuffer(size_t index) const {
252 // frames available but the file is truncated. 264 DCHECK(index < m_frameBufferCache.size());
253 if (index >= m_frameBufferCache.size() - 1 && isAllDataReceived() && 265
254 m_reader && !m_reader->parseCompleted()) 266 // If the current frame and the next frame depend on the same frame, we cannot
255 setFailed(); 267 // reuse the old frame. We must preserve it for the next frame.
256 } 268 //
257 269 // However, if the current and next frame depend on different frames then we
258 void GIFImageDecoder::parse(GIFParseQuery query) { 270 // know the current frame is the last one to use the frame it depends on. That
259 if (failed()) 271 // means the current frame can reuse the previous frame buffer.
260 return; 272 //
261 273 // If we do not have information about the next frame yet, we cannot assume it
262 if (!m_reader) { 274 // is safe to reuse the previous frame buffer.
263 m_reader = WTF::makeUnique<GIFImageReader>(this); 275
264 m_reader->setData(m_data); 276 if (index + 1 >= m_frameBufferCache.size()) {
265 } 277 return false;
266 278 }
267 if (!m_reader->parse(query)) 279
268 setFailed(); 280 const ImageFrame& frame = m_frameBufferCache[index];
269 } 281 size_t requiredFrameIndex = frame.requiredPreviousFrameIndex();
270 282
271 void GIFImageDecoder::onInitFrameBuffer(size_t frameIndex) { 283 const ImageFrame& nextFrame = m_frameBufferCache[index + 1];
272 m_currentBufferSawAlpha = false; 284 size_t nextRequiredFrameIndex = nextFrame.requiredPreviousFrameIndex();
273 } 285
274 286 return requiredFrameIndex != nextRequiredFrameIndex;
275 bool GIFImageDecoder::canReusePreviousFrameBuffer(size_t frameIndex) const {
276 DCHECK(frameIndex < m_frameBufferCache.size());
277 return m_frameBufferCache[frameIndex].getDisposalMethod() !=
278 ImageFrame::DisposeOverwritePrevious;
279 } 287 }
280 288
281 } // namespace blink 289 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698