Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2775063002: Move WEBPImageDecoder to SkCodec

Created:
3 years, 9 months ago by cblume
Modified:
3 years, 4 months ago
Reviewers:
scroggo_chromium
CC:
chromium-reviews, blink-reviews, jzern, kinuko+watch, skal, urvang, vmpstr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WEBPImageDecoder to SkCodec SkCodec is gaining advantages over Blink's image decoders. scroggo@ has a nice summary: - Skia already has some features that Chromium is interested in: - decoding scaled versions of images - decoding subsets (i.e. issue 468914) - SIMD optimizations for writing pixels - In general, sharing code means that new features/bug fixes in Android benefit Chromium and vice versa - Skia's API is designed to allow the client to handle caching, so that the client that knows the bigger picture can make caching decisions in a more informed way than ImageDecoder can. BUG=715821

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix build #

Patch Set 4 : Rebase #

Patch Set 5 : Update WebP code from changes in the GIF decoder. #

Patch Set 6 : Pull in changes from the gif decoder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -482 lines) Patch
M third_party/WebKit/Source/platform/image-decoders/SegmentStream.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h View 1 2 3 4 5 3 chunks +24 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp View 1 2 3 4 5 2 chunks +228 lines, -436 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (10 generated)
cblume
3 years, 4 months ago (2017-08-08 08:31:31 UTC) #11
cblume
3 years, 4 months ago (2017-08-08 08:33:30 UTC) #12
This patch relies on 2 pending Skia patches:
* Allow SkStream-derived classes to move. --
https://skia-review.googlesource.com/c/24580
* Expose blend source for WebP users of SkCodec --
https://bugs.chromium.org/p/skia/issues/detail?id=6928

Powered by Google App Engine
This is Rietveld 408576698