Move gif image decoder to SkCodec

skia/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//printing/features/features.gni")
 import("//testing/test.gni")
 import("//third_party/skia/gn/shared_sources.gni")
@@ skipping 25 matching lines @@
     "//third_party/skia/include/images",
     "//third_party/skia/include/lazy",
     "//third_party/skia/include/pathops",
     "//third_party/skia/include/pdf",
     "//third_party/skia/include/pipe",
     "//third_party/skia/include/ports",
     "//third_party/skia/include/utils",
     "//third_party/skia/third_party/vulkan",
   ]
 
+  if (!is_ios) {
+    include_dirs += [ "//third_party/skia/include/codec" ]

[scroggo_chromium, 2017/06/05 19:00:53]

So we're not using SkCodec on ios? What happens there? We fail to decode?

[cblume, 2017/06/06 04:04:35]

That is correct, we do not use SkCodec on iOS. Nor do we use the Blink decoders,
as far as I can tell.

The iOS app store requires that we do not provide our own browser / javascript
engine and must instead use the platform's WebKit. So Chrome on iOS is a WebKit
skin with other Chrome features such as account sync.

A while ago, I thought we still built all of Chrome for iOS even though we don't
ship it all (we only ship parts). But since I see a lot of build files asserting
that iOS shouldn't include a given part (which includes libjpeg_turbo [1]), I
think the image decoders aren't built for iOS.

[1]
https://cs.chromium.org/chromium/src/build/secondary/third_party/libjpeg_turb...

+  }
+
   defines = skia_for_chromium_defines
   defines += [
     "SK_HAS_PNG_LIBRARY",
     "SK_HAS_WEBP_LIBRARY",
   ]
 
   if (!is_ios) {
     defines += [ "SK_HAS_JPEG_LIBRARY" ]
   }
 
@@ skipping 51 matching lines @@
     "//third_party/skia/src/image",
     "//third_party/skia/src/images",
     "//third_party/skia/src/opts",
     "//third_party/skia/src/pdf",
     "//third_party/skia/src/ports",
     "//third_party/skia/src/shaders",
     "//third_party/skia/src/shaders/gradients",
     "//third_party/skia/src/sfnt",
     "//third_party/skia/src/utils",
     "//third_party/skia/src/lazy",
+    "//third_party/skia/third_party/gif",
   ]
   if (is_mac || is_ios) {
     include_dirs += [ "//third_party/skia/include/utils/mac" ]
   }
   if (is_mac) {
     include_dirs += [ "//third_party/skia/include/utils/ios" ]
   }
 
   # TODO: remove after Skia shader relocation (https://skia-review.googlesource.com/c/17927)
   include_dirs += [ "//third_party/skia/src/effects/gradients" ]
@@ skipping 151 matching lines @@
     "//third_party/skia/src/images/SkJPEGWriteUtility.cpp",
     "//third_party/skia/src/images/SkJpegEncoder.cpp",
     "//third_party/skia/src/images/SkPngEncoder.cpp",
     "//third_party/skia/src/images/SkWebpEncoder.cpp",
     "//third_party/skia/src/ports/SkGlobalInitialization_default.cpp",
     "//third_party/skia/src/ports/SkImageGenerator_none.cpp",
     "//third_party/skia/src/ports/SkOSFile_stdio.cpp",
     "//third_party/skia/src/sfnt/SkOTTable_name.cpp",
     "//third_party/skia/src/sfnt/SkOTUtils.cpp",
   ]
+  if (!is_ios) {
+    sources += [
+      "//third_party/skia/src/codec/SkBmpCodec.cpp",
+      "//third_party/skia/src/codec/SkBmpMaskCodec.cpp",
+      "//third_party/skia/src/codec/SkBmpRLECodec.cpp",
+      "//third_party/skia/src/codec/SkBmpStandardCodec.cpp",
+      "//third_party/skia/src/codec/SkCodec.cpp",
+      "//third_party/skia/src/codec/SkGifCodec.cpp",
+      "//third_party/skia/src/codec/SkIcoCodec.cpp",
+      "//third_party/skia/src/codec/SkJpegCodec.cpp",
+      "//third_party/skia/src/codec/SkJpegDecoderMgr.cpp",
+      "//third_party/skia/src/codec/SkJpegUtility.cpp",
+      "//third_party/skia/src/codec/SkMaskSwizzler.cpp",
+      "//third_party/skia/src/codec/SkMasks.cpp",
+      "//third_party/skia/src/codec/SkPngCodec.cpp",
+      "//third_party/skia/src/codec/SkSampler.cpp",
+      "//third_party/skia/src/codec/SkStreamBuffer.cpp",
+      "//third_party/skia/src/codec/SkSwizzler.cpp",
+      "//third_party/skia/src/codec/SkWbmpCodec.cpp",
+      "//third_party/skia/src/codec/SkWebpCodec.cpp",
+      "//third_party/skia/third_party/gif/SkGifImageReader.cpp",
+    ]
+  }
 
   # This and skia_opts are really the same conceptual target so share headers.
   allow_circular_includes_from = [ ":skia_opts" ]
 
   if (current_cpu == "arm") {
     sources += [ "//third_party/skia/src/core/SkUtilsArm.cpp" ]
   }
 
   # GPU
   if (skia_support_gpu) {
@@ skipping 445 matching lines @@
 
     deps = [
       ":skia",
       "//base",
       "//base/test:test_support",
       "//build/config:exe_and_shlib_deps",
       "//build/win:default_exe_manifest",
     ]
   }
 }