Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2565223003: content: Move shader cache factory singleton into a separate file. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
jam, jbauman
CC:
chromium-reviews, wjmaclean, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Move shader cache factory singleton into a separate file. The shader cache code is going to move into //gpu/ipc/host. However, the singleton is content only. So factor out the code that deals with the singleton instance inside content. BUG=604369 Committed: https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76 Cr-Commit-Position: refs/heads/master@{#438079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -87 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A content/browser/gpu/shader_cache_factory.h View 1 chunk +27 lines, -0 lines 0 comments Download
A content/browser/gpu/shader_cache_factory.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M content/browser/gpu/shader_disk_cache.h View 6 chunks +6 lines, -19 lines 0 comments Download
M content/browser/gpu/shader_disk_cache.cc View 11 chunks +16 lines, -39 lines 0 comments Download
M content/browser/gpu/shader_disk_cache_unittest.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
sadrul
Mind reviewing the factoring out of the singleton? (The CL to move the shader-cache code ...
4 years ago (2016-12-12 04:46:29 UTC) #4
jbauman
lgtm
4 years ago (2016-12-12 07:07:18 UTC) #7
sadrul
+jam@ for code outside of content/browser/gpu/
4 years ago (2016-12-12 18:42:34 UTC) #9
jam
lgtm
4 years ago (2016-12-13 01:24:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565223003/1
4 years ago (2016-12-13 04:31:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 06:15:10 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-13 06:17:37 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75d671b90219f44818a7f328d3a5ca71cf533d76
Cr-Commit-Position: refs/heads/master@{#438079}

Powered by Google App Engine
This is Rietveld 408576698