Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: content/browser/gpu/shader_disk_cache_unittest.cc

Issue 2565223003: content: Move shader cache factory singleton into a separate file. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/shader_disk_cache.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/shader_disk_cache_unittest.cc
diff --git a/content/browser/gpu/shader_disk_cache_unittest.cc b/content/browser/gpu/shader_disk_cache_unittest.cc
index 80629470a316ac7be24d394e26270b2228b82d33..ee6592fd318845823927928d21336583d1f9fa45 100644
--- a/content/browser/gpu/shader_disk_cache_unittest.cc
+++ b/content/browser/gpu/shader_disk_cache_unittest.cc
@@ -4,6 +4,7 @@
#include "base/files/scoped_temp_dir.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/threading/thread.h"
#include "base/threading/thread_task_runner_handle.h"
#include "content/browser/browser_thread_impl.h"
@@ -25,8 +26,7 @@ class ShaderDiskCacheTest : public testing::Test {
public:
ShaderDiskCacheTest()
: thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {
- ShaderCacheFactory::InitInstance(
- base::ThreadTaskRunnerHandle::Get(),
+ factory_ = base::MakeUnique<ShaderCacheFactory>(
BrowserThread::GetTaskRunnerForThread(BrowserThread::CACHE));
}
@@ -36,15 +36,15 @@ class ShaderDiskCacheTest : public testing::Test {
void InitCache() {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
- ShaderCacheFactory::GetInstance()->SetCacheInfo(kDefaultClientId,
- cache_path());
+ factory_->SetCacheInfo(kDefaultClientId, cache_path());
}
+ ShaderCacheFactory* factory() { return factory_.get(); }
+
private:
- void TearDown() override {
- ShaderCacheFactory::GetInstance()->RemoveCacheInfo(kDefaultClientId);
- }
+ void TearDown() override { factory_->RemoveCacheInfo(kDefaultClientId); }
+ std::unique_ptr<ShaderCacheFactory> factory_;
base::ScopedTempDir temp_dir_;
content::TestBrowserThreadBundle thread_bundle_;
@@ -54,8 +54,7 @@ class ShaderDiskCacheTest : public testing::Test {
TEST_F(ShaderDiskCacheTest, ClearsCache) {
InitCache();
- scoped_refptr<ShaderDiskCache> cache =
- ShaderCacheFactory::GetInstance()->Get(kDefaultClientId);
+ scoped_refptr<ShaderDiskCache> cache = factory()->Get(kDefaultClientId);
ASSERT_TRUE(cache.get() != NULL);
net::TestCompletionCallback available_cb;
« no previous file with comments | « content/browser/gpu/shader_disk_cache.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698