Cache GL's viewport on the GPU command buffer client side.

Cache GL's viewport on the GPU command buffer client side.

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently called.

BUG=671872
TEST=
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c95386fb055bd88bc65debba5e9ea817cd272b6b
Cr-Commit-Position: refs/heads/master@{#437702}

[Zhenyao Mo, 2016-12-08 01:11:51]

Description was changed from

==========
Cache GL's viewport on the GPU command buffer client side.

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently
called.

BUG=671872
TEST=
R=kbr@chromium.org
==========

to

==========
Cache GL's viewport on the GPU command buffer client side.

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently
called.

BUG=671872
TEST=
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-12-08 01:13:55]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-12-08 01:14:06]

kbr: PTAL

[commit-bot: I haz the power, 2016-12-08 01:14:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-12-08 01:59:32]

Thanks Mo, that's great. LGTM

https://codereview.chromium.org/2558933003/diff/1/gpu/command_buffer/client/g...
File gpu/command_buffer/client/gles2_implementation_unittest.cc (right):

https://codereview.chromium.org/2558933003/diff/1/gpu/command_buffer/client/g...
gpu/command_buffer/client/gles2_implementation_unittest.cc:473:
capabilities.max_viewport_width = kMaxViewportHeight;
max_viewport_height. Ideally that bug would have been caught with one of the
tests.

[commit-bot: I haz the power, 2016-12-08 02:15:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 02:15:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Zhenyao Mo, 2016-12-09 21:48:57]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-12-09 21:49:33]

kbr: I did a minor fix in the CL to make the bots happy.  Could you take a quick
look again?

[commit-bot: I haz the power, 2016-12-09 21:49:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-12-09 22:00:17]

Still LGTM.

[Zhenyao Mo, 2016-12-09 23:13:54]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2016-12-09 23:14:00]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-12-09 23:14:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 23:49:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481325240214570,
"parent_rev": "2e0796d4abe5580fbcb71d798f7b66de9e09e6d3", "commit_rev":
"cc7ba41bb935de9d6a60fcc581b9a72c0a284831"}

[commit-bot: I haz the power, 2016-12-09 23:49:32]

Description was changed from

==========
Cache GL's viewport on the GPU command buffer client side.

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently
called.

BUG=671872
TEST=
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Cache GL's viewport on the GPU command buffer client side.

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently
called.

BUG=671872
TEST=
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2558933003
==========

[commit-bot: I haz the power, 2016-12-09 23:49:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 14:58:45]

Description was changed from

==========
Cache GL's viewport on the GPU command buffer client side.

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently
called.

BUG=671872
TEST=
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2558933003
==========

to

==========
Cache GL's viewport on the GPU command buffer client side.

This is to tune the perf of a demo where glGetInteger(GL_VIEWPORT) is frequently
called.

BUG=671872
TEST=
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c95386fb055bd88bc65debba5e9ea817cd272b6b
Cr-Commit-Position: refs/heads/master@{#437702}
==========

[commit-bot: I haz the power, 2016-12-12 14:58:46]

Patchset 2 (id:??) landed as
https://crrev.com/c95386fb055bd88bc65debba5e9ea817cd272b6b
Cr-Commit-Position: refs/heads/master@{#437702}