Check layer is valid for framebuffer 3D texture attachments.

Check layer is valid for framebuffer 3D texture attachments.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/dda9c297f9558449c859e2ca73ca9c224d330f73
Cr-Commit-Position: refs/heads/master@{#396883}

[Zhenyao Mo, 2016-05-26 23:24:51]

Description was changed from

==========
Check layer is valid for framebuffer 3D texture attachments.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org
==========

to

==========
Check layer is valid for framebuffer 3D texture attachments.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-05-26 23:25:24]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-26 23:26:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020473002/1

[Zhenyao Mo, 2016-05-26 23:26:32]

piman: PTAL

Some underlying drivers return FRAMEBUFFER_COMPLETE in such cases.  With this
CL, a bunch of deqp's fbocomplete.html cases pass.

[commit-bot: I haz the power, 2016-05-27 00:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 00:20:35]

Dry run: Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[piman, 2016-05-27 01:37:26]

https://codereview.chromium.org/2020473002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/framebuffer_manager.cc (right):

https://codereview.chromium.org/2020473002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/framebuffer_manager.cc:247: return
(texture->GetLevelSize(texture->target(), level_,
I think you need to take the attachment's target, not the texture's, so that it
works correctly for cube maps (see failing tests).

[Zhenyao Mo, 2016-05-27 12:44:35]

piman: please take another look.

https://codereview.chromium.org/2020473002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/framebuffer_manager.cc (right):

https://codereview.chromium.org/2020473002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/framebuffer_manager.cc:247: return
(texture->GetLevelSize(texture->target(), level_,
On 2016/05/27 01:37:25, piman OOO back 2016-5-31 wrote:
> I think you need to take the attachment's target, not the texture's, so that
it
> works correctly for cube maps (see failing tests).

Done.  Added a unitttest to catch this bug.

[Zhenyao Mo, 2016-05-27 12:44:42]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 12:44:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020473002/20001

[commit-bot: I haz the power, 2016-05-27 14:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 14:06:41]

Dry run: This issue passed the CQ dry run.

[piman, 2016-05-31 15:52:54]

lgtm

[Zhenyao Mo, 2016-05-31 16:08:47]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2016-05-31 16:09:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020473002/20001

[commit-bot: I haz the power, 2016-05-31 19:04:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 19:06:36]

Description was changed from

==========
Check layer is valid for framebuffer 3D texture attachments.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Check layer is valid for framebuffer 3D texture attachments.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/dda9c297f9558449c859e2ca73ca9c224d330f73
Cr-Commit-Position: refs/heads/master@{#396883}
==========

[commit-bot: I haz the power, 2016-05-31 19:06:37]

Patchset 2 (id:??) landed as
https://crrev.com/dda9c297f9558449c859e2ca73ca9c224d330f73
Cr-Commit-Position: refs/heads/master@{#396883}

[Zhenyao Mo, 2017-02-09 22:32:56]

Patchset #3 (id:40001) has been deleted