Collect active stylesheets and and apply asynchronously.

Reland: Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021
Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Committed: https://crrev.com/90d4ea3d543f0031769b3aacac2d3e084b95fb7d
Cr-Original-Commit-Position: refs/heads/master@{#438148}
Cr-Commit-Position: refs/heads/master@{#439092}

[rune, 2016-12-07 11:46:32]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 11:46:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 13:39:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 13:39:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rune, 2016-12-08 23:13:15]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 23:13:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:25:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:25:31]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rune, 2016-12-08 23:45:46]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 23:46:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-12-08 23:48:37]

rune@opera.com changed reviewers:
+ esprehn@chromium.org, sashab@chromium.org

[rune, 2016-12-08 23:48:37]

rune@opera.com changed reviewers:
+ esprehn@chromium.org, sashab@chromium.org

[rune, 2016-12-08 23:48:38]

This is the CL that enables async stylesheet update. After landing various other
pieces it's as small as I was able to get this CL now. There is a lot of code
which can be removed if this CL lands. I have prepared those in:

https://codereview.chromium.org/2552353003
https://codereview.chromium.org/2559613002
https://codereview.chromium.org/2557773004
https://codereview.chromium.org/2555083002
https://codereview.chromium.org/2546343006

I should probably trigger a perf job for this, but I don't that should stop
anyone from start reviewing.

[rune, 2016-12-08 23:48:39]

This is the CL that enables async stylesheet update. After landing various other
pieces it's as small as I was able to get this CL now. There is a lot of code
which can be removed if this CL lands. I have prepared those in:

https://codereview.chromium.org/2552353003
https://codereview.chromium.org/2559613002
https://codereview.chromium.org/2557773004
https://codereview.chromium.org/2555083002
https://codereview.chromium.org/2546343006

I should probably trigger a perf job for this, but I don't that should stop
anyone from start reviewing.

[commit-bot: I haz the power, 2016-12-08 23:50:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:50:50]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[esprehn, 2016-12-09 01:36:21]

This looks amazing, but all your bots are red?

Btw I'm curious what cases we would ever actually discard the StyleResolver now?
Ideally we'd never discard the whole resolver anymore if possible?

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right):

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/StyleSheetContents.cpp:628:
document->styleEngine().setNeedsActiveStyleUpdate(node->treeScope());
Should this be a method on TreeScope instead?

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp (left):

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp:88: void
DocumentStyleSheetCollection::updateActiveStyleSheets(
Amazing!

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:1467:
m_frame->document()->setNeedsStyleRecalc(
Ouch, did this code path always force a full document recalc?

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/LocalFrame.cpp (right):

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/LocalFrame.cpp:698:
document()->setNeedsStyleRecalc(
Did this cause a full document recalc before? I didn't think we used to do a
full recalc on every zoom before. I think we're going to use dsf for zoom soon
too which means this case will need to be fast.

[meade_UTC10, 2016-12-09 02:45:34]

On 2016/12/09 01:36:21, esprehn wrote:
> This looks amazing, but all your bots are red?
> 
> Btw I'm curious what cases we would ever actually discard the StyleResolver
now?
> Ideally we'd never discard the whole resolver anymore if possible?
> 
>
https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right):
> 
>
https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/StyleSheetContents.cpp:628:
> document->styleEngine().setNeedsActiveStyleUpdate(node->treeScope());
> Should this be a method on TreeScope instead?
> 
>
https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp
(left):
> 
>
https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp:88: void
> DocumentStyleSheetCollection::updateActiveStyleSheets(
> Amazing!
> 
>
https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/frame/FrameView.cpp (right):
> 
>
https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/frame/FrameView.cpp:1467:
> m_frame->document()->setNeedsStyleRecalc(
> Ouch, did this code path always force a full document recalc?
> 
>
https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/frame/LocalFrame.cpp (right):
> 
>
https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/frame/LocalFrame.cpp:698:
> document()->setNeedsStyleRecalc(
> Did this cause a full document recalc before? I didn't think we used to do a
> full recalc on every zoom before. I think we're going to use dsf for zoom soon
> too which means this case will need to be fast.

This is a really cool CL! Great work Rune!

FWIW the tree was closed when I received this CL, so that's probably why the
bots are red.

[meade_UTC10, 2016-12-09 02:45:41]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 02:46:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 04:53:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 04:53:17]

Dry run: This issue passed the CQ dry run.

[rune, 2016-12-09 08:55:50]

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right):

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/StyleSheetContents.cpp:628:
document->styleEngine().setNeedsActiveStyleUpdate(node->treeScope());
On 2016/12/09 01:36:21, esprehn wrote:
> Should this be a method on TreeScope instead?

We will need to pass the tree-scope on to StyleEngine to add it to the
collection of dirty tree-scopes. Did you mean:

  node->treeScope().setNeedsActiveStyleUpdate()

and then

  TreeScope::setNeedsActiveStyleUpdate() {
    rootNode().document().styleEngine().setNeedsActiveStyleUpdate(*this);
  }

?

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.cpp:1467:
m_frame->document()->setNeedsStyleRecalc(
On 2016/12/09 01:36:21, esprehn wrote:
> Ouch, did this code path always force a full document recalc?

Yes, that is, setMediaType() called from here calls
mediaQueryAffectingValueChanged() which used to cause a full document recalc
regardlessly through resolverChanged(FullStyleUpdate).
mediaQueryAffectingValueChanged() now only has an effect if media queries
actually did change evaluation. If I leave this out, I'll have regressions in
tests for printing and zoom, at least. That is because of [1]. There might be
other switches on document().printing() which currently also requires
recalc/relayout if zoom factor is different from 1. We can surely improve on
this, but I think that could be a separate task.

Perhaps the setNeedsStyleRecalc() call here should be moved to setMediaType? I
looks like we only call setMediaType for switching between print and the other
media type (always screen?).

[1]
https://codesearch.chromium.org/chromium/src/third_party/WebKit/Source/core/c...

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/LocalFrame.cpp (right):

https://codereview.chromium.org/2557533005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/LocalFrame.cpp:698:
document()->setNeedsStyleRecalc(
On 2016/12/09 01:36:21, esprehn wrote:
> Did this cause a full document recalc before? I didn't think we used to do a
> full recalc on every zoom before. I think we're going to use dsf for zoom soon
> too which means this case will need to be fast.

Yes, mediaQueryAffectingValueChanged called resolverChanged(FullStyleUpdate)
which re-collects all stylesheets in all scopes and marks Document
SubtreeStyleChange in the StyleSheetChange analysis in the
StyleSheetCollections. Without this change,
fast/events/mouse-cursor-image-set.html will fail on Mac. That test is expecting
a change in which image from an image set is picked for a given zoom factor.

testRunner.setBackingScaleFactor() seems to use DSF on Mac and
setPageAndTextZoomFactors() on other platforms.

This can probably be improved, but that could be a separate task. This should be
no perf regressions with this CL.

[meade_UTC10, 2016-12-12 09:50:37]

I'm OOO this week. Sasha, would you mind taking a look? You're already on the R
line :)

[rune, 2016-12-12 10:02:41]

On 2016/12/12 09:50:37, Eddy (OOO until 19 Dec) wrote:
> I'm OOO this week. Sasha, would you mind taking a look? You're already on the
R
> line :)

That'd be great!

Also, I've replied to esprehn@'s issues, if you could take another look.

[esprehn, 2016-12-12 22:24:30]

lgtm

[rune, 2016-12-13 08:20:23]

On 2016/12/12 22:24:30, esprehn wrote:
> lgtm

thanks! after running some blink performance tests locally and fixing a
regression with https://codereview.chromium.org/2569733003/ I'm going to try to
land this now.

[rune, 2016-12-13 08:22:24]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-12-13 08:22:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 10:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 10:03:01]

Failed to apply patch for third_party/WebKit/Source/core/BUILD.gn:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/BUILD.gn:1121
  error: third_party/WebKit/Source/core/BUILD.gn: patch does not apply

Patch:       third_party/WebKit/Source/core/BUILD.gn
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn
b/third_party/WebKit/Source/core/BUILD.gn
index
fca1b7e0d804b675e2b421c762c0d372d79b2240..92735f874e19f8ebe8cb8d9d98cc863e0c1c26cd
100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -1121,7 +1121,6 @@ source_set("unit_tests") {
     "dom/StyleElementTest.cpp",
     "dom/StyleEngineTest.cpp",
     "dom/TextTest.cpp",
-    "dom/TreeScopeStyleSheetCollectionTest.cpp",
     "dom/TreeScopeTest.cpp",
     "dom/URLSearchParamsTest.cpp",
     "dom/custom/CustomElementDefinitionTest.cpp",

[rune, 2016-12-13 10:11:15]

The CQ bit was checked by rune@opera.com

[rune, 2016-12-13 10:11:15]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2557533005/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-13 10:11:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 13:03:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481623875078710,
"parent_rev": "15bc37c6f8cac4d014d16b49b0fb5cd08694bf2b", "commit_rev":
"e16caf869ee4afb785c194f7adc91db08bd1af9f"}

[commit-bot: I haz the power, 2016-12-13 13:03:48]

Description was changed from

==========
Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021
==========

to

==========
Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2557533005
==========

[commit-bot: I haz the power, 2016-12-13 13:03:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 13:05:40]

Description was changed from

==========
Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Review-Url: https://codereview.chromium.org/2557533005
==========

to

==========
Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Cr-Commit-Position: refs/heads/master@{#438148}
==========

[commit-bot: I haz the power, 2016-12-13 13:05:41]

Patchset 4 (id:??) landed as
https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Cr-Commit-Position: refs/heads/master@{#438148}

[paulmeyer, 2016-12-13 20:52:31]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2572473006/ by paulmeyer@chromium.org.

The reason for reverting is: Suspected cause of failing WebKit tests on bots.
Example:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...

BUG=673850.

[rune, 2016-12-16 10:01:23]

Description was changed from

==========
Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Cr-Commit-Position: refs/heads/master@{#438148}
==========

to

==========
Reland: Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Cr-Commit-Position: refs/heads/master@{#438148}
==========

[rune, 2016-12-16 10:01:35]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-12-16 10:01:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 10:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 10:03:43]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[rune, 2016-12-16 10:42:58]

The CQ bit was checked by rune@opera.com

[rune, 2016-12-16 10:42:58]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2557533005/#ps80001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-12-16 10:43:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 12:22:16]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481884978106520,
"parent_rev": "7fc211bfdd05bc513ce1b0922600cbdb8847abbc", "commit_rev":
"6d38137142d6ec25b03a2b9ce5d594d917cc9a44"}

[commit-bot: I haz the power, 2016-12-16 12:22:58]

Description was changed from

==========
Reland: Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Cr-Commit-Position: refs/heads/master@{#438148}
==========

to

==========
Reland: Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Cr-Commit-Position: refs/heads/master@{#438148}
Review-Url: https://codereview.chromium.org/2557533005
==========

[commit-bot: I haz the power, 2016-12-16 12:23:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-16 12:25:19]

Description was changed from

==========
Reland: Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Cr-Commit-Position: refs/heads/master@{#438148}
Review-Url: https://codereview.chromium.org/2557533005
==========

to

==========
Reland: Collect active stylesheets and and apply asynchronously.

This CL enables asynchronously updating the lists of active stylesheets
applying any style changes using rule set invalidations. This means we
more often avoid full style recalcs when we add or remove stylesheets
from the document as well as when the evaluation of media queries
change.

In general, we now alway compare new and old stylesheets by comparing
their rulesets and schedule style invalidations for removed and added
rulesets.

When media queries changes, we used to give completely in and
recalculate all style once we discovered a media query changed its
evaluation. With this patch, we clear rule sets for sheets which
contain media queries which means we will invalidate rules for the sets
before and after the query change. This can be further refined by only
clearing rule sets when the sheets has a media query which actually did
change evaluation, and also just schedule invalidations for rules which
are inside @media rules.

TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
ActiveStyleSheetsTest.cpp which landed earlier.

updateActiveStyle() has been added a few places where
ensureStyleResolver() previously caused active stylesheets to be up-to-
date. ensureStyleResolver() is now merely a method which creates the
StyleResolver if necessary and returns it.

There are some cleanups and code removal which needs to be done after
this CL, but I have left those out to make this CL as small as
possible. For instance resolverChanged(), which synchronously updated
the active stylesheets, has an empty implementation instead of
including a lot of removals in this CL. The code for lazy-appending
stylesheets in StyleResolver is still there, but not in use.

R=meade@chromium.org
BUG=567021

Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
Committed: https://crrev.com/90d4ea3d543f0031769b3aacac2d3e084b95fb7d
Cr-Original-Commit-Position: refs/heads/master@{#438148}
Cr-Commit-Position: refs/heads/master@{#439092}
==========

[commit-bot: I haz the power, 2016-12-16 12:25:21]

Patchset 5 (id:??) landed as
https://crrev.com/90d4ea3d543f0031769b3aacac2d3e084b95fb7d
Cr-Commit-Position: refs/heads/master@{#439092}