Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2555083002: Remove ensureResolver before invalidation set scheduling. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10, sashab, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ensureResolver before invalidation set scheduling. ensureResolver() used to make sure the invalidation sets were up-to- date with the currently active stylesheets. This is no longer necessary as ruleset invalidation of changes in active stylesheets will make sure changes are applied correctly. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/2650087b9cb225894d5d4972bd7d32d6e38c9e68 Cr-Commit-Position: refs/heads/master@{#439096}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 8 chunks +2 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
rune
4 years ago (2016-12-13 09:00:22 UTC) #2
esprehn
lgtm
4 years ago (2016-12-13 09:07:38 UTC) #3
sashab
lgtm
4 years ago (2016-12-13 23:14:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555083002/20001
4 years ago (2016-12-16 12:43:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 14:05:14 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 14:07:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2650087b9cb225894d5d4972bd7d32d6e38c9e68
Cr-Commit-Position: refs/heads/master@{#439096}

Powered by Google App Engine
This is Rietveld 408576698