Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2559613002: Removed resolverChanged(). (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10, sashab, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+prerender_chromium.org, rwlbuis, sof, tfarina, webcomponents-bugzilla_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed resolverChanged(). This method was now empty and has been replaced by asynchronous active stylesheet update in updateActiveStyleSheets(). R=meade@chromium.org BUG=567021 Committed: https://crrev.com/461fe03024acd4ae50eb3c4790ba8fd68f0470c3 Cr-Commit-Position: refs/heads/master@{#439142}

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 16 (8 generated)
rune
4 years ago (2016-12-13 08:59:16 UTC) #2
esprehn
lgtm
4 years ago (2016-12-13 09:08:47 UTC) #3
sashab
Omg this is awesome!! \o/ LGTM
4 years ago (2016-12-13 23:12:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559613002/20001
4 years ago (2016-12-16 12:39:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/181909)
4 years ago (2016-12-16 12:56:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2559613002/20001
4 years ago (2016-12-16 15:58:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 17:50:41 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-16 17:53:06 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/461fe03024acd4ae50eb3c4790ba8fd68f0470c3
Cr-Commit-Position: refs/heads/master@{#439142}

Powered by Google App Engine
This is Rietveld 408576698