Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2557773004: Remove unused lazyAppend from StyleResolver. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10, sashab, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused lazyAppend from StyleResolver. Active stylesheet update is now asynchronous and handled from StyleEngine::updateActiveStyleSheets(). R=meade@chromium.org BUG=567021 Committed: https://crrev.com/22928d81b2c3c0b72cf0416819e6c6d41fc0f526 Cr-Commit-Position: refs/heads/master@{#439102}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -95 lines) Patch
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 4 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 4 chunks +0 lines, -59 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
rune
4 years ago (2016-12-13 08:59:46 UTC) #2
esprehn
lgtm
4 years ago (2016-12-13 09:08:08 UTC) #3
sashab
Thanks for doing all these cleanups in separate patches. Lgtm
4 years ago (2016-12-13 23:13:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557773004/20001
4 years ago (2016-12-16 12:47:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 14:39:31 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 14:42:17 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22928d81b2c3c0b72cf0416819e6c6d41fc0f526
Cr-Commit-Position: refs/heads/master@{#439102}

Powered by Google App Engine
This is Rietveld 408576698