Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2552353003: Setting preferred stylesheet simplified. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10, esprehn, sashab
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+prerender_chromium.org, rwlbuis, sof, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Setting preferred stylesheet simplified. With active stylesheets being applied asynchronously, we no longer need to avoid the synchronous stylesheet update during link processing. We can just mark the treeScope dirty to trigger the preferred set to be updated as part of updateActiveStyleSheets(). R=meade@chromium.org BUG=567021 Committed: https://crrev.com/626379c7a2bed66978eb739ee3afcc3df47ac4b2 Cr-Commit-Position: refs/heads/master@{#439115}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -31 lines) Patch
M third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 4 chunks +4 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkStyle.cpp View 1 3 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
rune
ptal
4 years ago (2016-12-13 08:58:40 UTC) #2
esprehn
lgtm
4 years ago (2016-12-13 09:09:34 UTC) #3
rune
I think I'll hold off landing these cleanup CLs until [1] has been a round ...
4 years ago (2016-12-13 09:13:20 UTC) #4
rune
On 2016/12/13 09:13:20, rune wrote: > I think I'll hold off landing these cleanup CLs ...
4 years ago (2016-12-13 18:59:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552353003/1
4 years ago (2016-12-13 19:00:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/122090) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-13 19:03:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552353003/20001
4 years ago (2016-12-16 12:34:45 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-16 15:53:37 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-16 15:55:54 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/626379c7a2bed66978eb739ee3afcc3df47ac4b2
Cr-Commit-Position: refs/heads/master@{#439115}

Powered by Google App Engine
This is Rietveld 408576698