Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329

Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org

Committed: https://crrev.com/e585bac3b48a1fd12eb7a85ad3d94d823306117f
Cr-Commit-Position: refs/heads/master@{#437376}

[scottmg, 2016-12-07 23:27:11]

Description was changed from

==========
Update Crashpad to 6b09b08a22028c4e699f4afdc6c00eef7de8e3fe

Update Crashpad to 6b09b08a22028c4e699f4afdc6c00eef7de8e3fe

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API

BUG=656800
R=mark@chromium.org
==========

to

==========
Update Crashpad to 6b09b08a22028c4e699f4afdc6c00eef7de8e3fe

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org
==========

[scottmg, 2016-12-07 23:28:00]

https://codereview.chromium.org/2555353002/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/build/crashpad.gypi (right):

https://codereview.chromium.org/2555353002/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/build/crashpad.gypi:29: ['OS=="linux" or
OS=="android"', {
I'm not sure about this in GN -- I guess it doesn't matter for now either way,
but do we have a place to add this already? It doesn't seem to be set globally
in Chromium, so I guess we will have to do something
https://cs.chromium.org/search/?q=file:%5C.gn+Wno-multichar&sq=package:chromi....

[Mark Mentovai, 2016-12-07 23:51:07]

LGTM

[scottmg, 2016-12-07 23:51:48]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 23:52:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 00:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:33:15]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[scottmg, 2016-12-08 00:38:09]

Hrm

...
FAILED:
obj/components/browser_watcher/unit_tests/postmortem_minidump_writer_win_unittest.obj

ninja -t msvc -e environment.x64 -- E:\b\c\cipd\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC
@obj/components/browser_watcher/unit_tests/postmortem_minidump_writer_win_unittest.obj.rsp
/c ../../components/browser_watcher/postmortem_minidump_writer_win_unittest.cc
/Foobj/components/browser_watcher/unit_tests/postmortem_minidump_writer_win_unittest.obj
/Fd"obj/components/browser_watcher/unit_tests_cc.pdb"
e:\b\c\b\win\src\components\browser_watcher\postmortem_minidump_writer_win_unittest.cc(36):
error C2039: 'InitializeWithNewTag': is not a member of 'crashpad::UUID'
e:\b\c\b\win\src\third_party\crashpad\crashpad\util\misc\uuid.h(40): note: see
declaration of 'crashpad::UUID'
e:\b\c\b\win\src\components\browser_watcher\postmortem_minidump_writer_win_unittest.cc(36):
error C2065: 'InitializeWithNewTag': undeclared identifier
e:\b\c\b\win\src\components\browser_watcher\postmortem_minidump_writer_win_unittest.cc(37):
error C2039: 'InitializeWithNewTag': is not a member of 'crashpad::UUID'
...

[Mark Mentovai, 2016-12-08 00:45:02]

Gross.

We may need to start thinking about having a separate “public” include
directory.

[scottmg, 2016-12-08 00:50:28]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 00:51:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-12-08 00:58:02]

On 2016/12/08 00:45:02, Mark Mentovai wrote:
> Gross.
> 
> We may need to start thinking about having a separate “public” include
> directory.

Doh, there's more. This is in 14393, but not 10586.

[24671->1076/25796 ~50] CXX
obj/components/browser_watcher/postmortem_minidump_writer/postmortem_minidump_writer_win.obj
FAILED:
obj/components/browser_watcher/postmortem_minidump_writer/postmortem_minidump_writer_win.obj
ninja -t msvc -e environment.x86 --
"c:\src\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64_x86/cl.exe"
/nologo /showIncludes /FC
@obj/components/browser_watcher/postmortem_minidump_writer/postmortem_minidump_writer_win.obj.rsp
/c ../../components/browser_watcher/postmortem_minidump_writer_win.cc
/Foobj/components/browser_watcher/postmortem_minidump_writer/postmortem_minidump_writer_win.obj
/Fd"obj/components/browser_watcher/postmortem_minidump_writer_cc.pdb"
c:\src\cr\src\third_party\crashpad\crashpad\minidump\minidump_extensions.h(174):
error C2065: 'PROCESSOR_ARCHITECTURE_ARM32_ON_WIN64': undeclared identifier

I remember we bailed on updating last time, but I forget why now. Let me check
back.

[Mark Mentovai, 2016-12-08 01:02:21]

On 2016/12/08 00:58:02, scottmg wrote:
> Doh, there's more. This is in 14393, but not 10586.
> 
[…]
>
c:\src\cr\src\third_party\crashpad\crashpad\minidump\minidump_extensions.h(174):
> error C2065: 'PROCESSOR_ARCHITECTURE_ARM32_ON_WIN64': undeclared identifier

Not picking up compat properly in the gn build?
https://chromium.googlesource.com/crashpad/crashpad/+/1382618fbe009d489c81194...

[scottmg, 2016-12-08 01:06:44]

On 2016/12/08 00:58:02, scottmg wrote:
> On 2016/12/08 00:45:02, Mark Mentovai wrote:
> > Gross.
> > 
> > We may need to start thinking about having a separate “public” include
> > directory.
> 
> Doh, there's more. This is in 14393, but not 10586.
> 
> [24671->1076/25796 ~50] CXX
>
obj/components/browser_watcher/postmortem_minidump_writer/postmortem_minidump_writer_win.obj
> FAILED:
>
obj/components/browser_watcher/postmortem_minidump_writer/postmortem_minidump_writer_win.obj
> ninja -t msvc -e environment.x86 --
>
"c:\src\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64_x86/cl.exe"
> /nologo /showIncludes /FC
>
@obj/components/browser_watcher/postmortem_minidump_writer/postmortem_minidump_writer_win.obj.rsp
> /c ../../components/browser_watcher/postmortem_minidump_writer_win.cc
>
/Foobj/components/browser_watcher/postmortem_minidump_writer/postmortem_minidump_writer_win.obj
> /Fd"obj/components/browser_watcher/postmortem_minidump_writer_cc.pdb"
>
c:\src\cr\src\third_party\crashpad\crashpad\minidump\minidump_extensions.h(174):
> error C2065: 'PROCESSOR_ARCHITECTURE_ARM32_ON_WIN64': undeclared identifier
> 
> I remember we bailed on updating last time, but I forget why now. Let me check
> back.

We believe it should be fine to switch, and it's already been packaged, so I've
posted https://codereview.chromium.org/2555393003/ to update Windows to 14393,
so I'll wait for this CL until after that.

[scottmg, 2016-12-08 01:08:22]

On 2016/12/08 01:02:21, Mark Mentovai wrote:
> On 2016/12/08 00:58:02, scottmg wrote:
> > Doh, there's more. This is in 14393, but not 10586.
> > 
> […]
> >
>
c:\src\cr\src\third_party\crashpad\crashpad\minidump\minidump_extensions.h(174):
> > error C2065: 'PROCESSOR_ARCHITECTURE_ARM32_ON_WIN64': undeclared identifier
> 
> Not picking up compat properly in the gn build?
>
https://chromium.googlesource.com/crashpad/crashpad/+/1382618fbe009d489c81194...

Oh, sadness. No, it wouldn't because none of the compat shims are in the GN
build files. I'm not sure we really want the fake #include_next in Chrome's
build either. So I guess this is another vote in favour of public/. I'll look
into that if the update isn't easy I guess.

[Mark Mentovai, 2016-12-08 01:13:34]

Well, this problem is exactly what compat’s there for, but if you can update the
SDK easily, no biggie…

[Mark Mentovai, 2016-12-08 01:14:09]

(It’s an omission in the gn build that compat isn’t picked up. We did have it
with the gyp build.)

[commit-bot: I haz the power, 2016-12-08 01:38:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:38:14]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[scottmg, 2016-12-08 16:54:04]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-12-08 16:54:05]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2555353002/#ps40001
(title: "browser_watcher fixes")

[commit-bot: I haz the power, 2016-12-08 16:54:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-12-08 16:57:59]

On 2016/12/08 01:13:34, Mark Mentovai wrote:
> Well, this problem is exactly what compat’s there for, but if you can update
the
> SDK easily, no biggie…

compat seems OK to me internal to Crashpad, but it feels a bit gross for
consumers to need a custom winnt.h. (But on the other hand the consumers are
including "internal" files here.)

Anyway, the SDK update seems to be fine, so I'll not worry about it for now.

[commit-bot: I haz the power, 2016-12-08 17:04:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 17:04:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-12-08 17:05:10]

The CQ bit was unchecked by scottmg@chromium.org

[Mark Mentovai, 2016-12-08 17:13:09]

If we did the “public” thing, we could say “no compat from public.” I’d be fine
with that.

Speaking of #includes, and maybe I‘ve asked this before: do you have any idea
what “um” stands for, as in um/winnt.h?

[scottmg, 2016-12-08 17:37:29]

On 2016/12/08 17:13:09, Mark Mentovai wrote:
> If we did the “public” thing, we could say “no compat from public.” I’d be
fine
> with that.
> 
> Speaking of #includes, and maybe I‘ve asked this before: do you have any idea
> what “um” stands for, as in um/winnt.h?

um, User Mode. shared/ is for things that are shared between um/ and km/. You
can get the km/ directory by installing the Windows Driver Kit.

[Mark Mentovai, 2016-12-08 17:39:04]

Thanks! I feel much better now.

[scottmg, 2016-12-08 17:40:16]

scottmg@chromium.org changed reviewers:
+ manzagop@chromium.org

[scottmg, 2016-12-08 17:40:17]

+manzagop for components/browser_watcher/ OWNERS.

[scottmg, 2016-12-08 17:42:55]

On 2016/12/08 17:39:04, Mark Mentovai wrote:
> Thanks! I feel much better now.

The vocalized pause interpretation is way better though. "include, um, winnt
maybe?" :)

[Mark Mentovai, 2016-12-08 17:44:37]

scottmg wrote:
> The vocalized pause interpretation is way better though. "include, um, winnt
> maybe?" :)

Oh yeah. I’ve said that at least once on each day I’ve done any Windows work
over the past two years.

[scottmg, 2016-12-08 18:05:24]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 18:06:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-12-08 18:12:35]

Description was changed from

==========
Update Crashpad to 6b09b08a22028c4e699f4afdc6c00eef7de8e3fe

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org
==========

to

==========
Update Crashpad to 6b09b08a22028c4e699f4afdc6c00eef7de8e3fe

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org
==========

[scottmg, 2016-12-08 18:12:51]

Description was changed from

==========
Update Crashpad to 6b09b08a22028c4e699f4afdc6c00eef7de8e3fe

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org
==========

to

==========
Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org
==========

[manzagop (departed), 2016-12-08 18:55:26]

lgtm

Sorry about the broken compile.

[scottmg, 2016-12-08 19:05:14]

On 2016/12/08 18:55:26, manzagop wrote:
> lgtm
> 
> Sorry about the broken compile.

Yeah, np, to be expected. We were talking up there ^^^ about what we should do.
I'm sort of going back and forth on whether a public/ directory is a good idea
or not. Fixing little compile errors here and there isn't enough to make public/
worthwhile, but if Crashpad does a larger refactoring (maybe for Android? or
server work?) it might be. On the other hand, having to maintain a public
interface is also going to be a burden, so it's certainly not magic.

Maybe a simpler idea is just to have a bot that builds Chrome against HEAD of
Crashpad so we have early visibility on changes and what they affect.

[commit-bot: I haz the power, 2016-12-08 20:12:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 20:12:12]

Dry run: This issue passed the CQ dry run.

[scottmg, 2016-12-08 20:13:06]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-12-08 20:13:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2555353002/#ps60001
(title: "clang")

[commit-bot: I haz the power, 2016-12-08 20:14:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-12-08 20:16:59]

https://codereview.chromium.org/2555353002/diff/60001/third_party/crashpad/RE...
File third_party/crashpad/README.chromium (right):

https://codereview.chromium.org/2555353002/diff/60001/third_party/crashpad/RE...
third_party/crashpad/README.chromium:5: Revision:
6b09b08a22028c4e699f4afdc6c00eef7de8e3fe
Fix.

[scottmg, 2016-12-08 20:19:07]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2016-12-08 20:21:46]

On 2016/12/08 20:16:59, Mark Mentovai wrote:
>
https://codereview.chromium.org/2555353002/diff/60001/third_party/crashpad/RE...
> File third_party/crashpad/README.chromium (right):
> 
>
https://codereview.chromium.org/2555353002/diff/60001/third_party/crashpad/RE...
> third_party/crashpad/README.chromium:5: Revision:
> 6b09b08a22028c4e699f4afdc6c00eef7de8e3fe
> Fix.

Darn, manually changed the CL title and description, but forgot the readme. (Too
bad the tryjobs don't cache for the CQ.)

[scottmg, 2016-12-08 20:22:25]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-12-08 20:22:26]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
manzagop@chromium.org
Link to the patchset: https://codereview.chromium.org/2555353002/#ps80001
(title: "fix readme")

[commit-bot: I haz the power, 2016-12-08 20:23:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-12-08 20:54:53]

LGTM. Thanks for your patience, and sorry that this has turned out to be the
roll from hell.

[commit-bot: I haz the power, 2016-12-08 22:29:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:29:38]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[scottmg, 2016-12-08 22:30:19]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:31:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:45:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481236219948090,
"parent_rev": "4b94fa6f369df20627face2ef0460587f8a34e6c", "commit_rev":
"3603117eec64d274201a634d94459a388bb2f706"}

[commit-bot: I haz the power, 2016-12-08 22:46:23]

Description was changed from

==========
Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org
==========

to

==========
Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org
==========

[commit-bot: I haz the power, 2016-12-08 22:46:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-08 22:49:42]

Description was changed from

==========
Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org
==========

to

==========
Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329

0c41b1549667 Convert AsciiDoc documentation to Markdown
3830e4e5c145 Update the link to mini_chromium’s README
6753ba5a5a9a catch_exception_tool.md: fix on_demand_service_tool link
             text
05c89beaae4e doc: Another silly follow-up
1f2a2c82c6b2 doc: Small updates after Markdown migration
f5e869c51f4e doc: Check in the man page index instead of generating it
8e3e65178a1d Update Doxyfile to 1.8.12
952f787f4aab doc: Standardize on “macOS” in comments
acabe35928f5 doc: Fix all Doxygen warnings, cleaning up some generated
             documentation
ac2e7cfbb2da doc: Make Doxygen-generated HTML interface documentation
             prettier
f191fff64dd3 doc: Fix bad merge resulting in twin “Man Pages” links
             in nav bar
dd4859965f90 Update compat version of winnt.h to 10.0.14393.0 SDK
             (Windows 10 1607)
5c44f1d14f1c Indicate rdtscp availability in MINIDUMP_SYSTEM_INFO of
             x86_64 minidumps
3abde199a712 minidump: fix tests to expect new rdtscp bit after
             5c44f1d14f1c
741c9cc51ea3 mac: Deal with bootstrap_look_up() race encountered on
             10.12.1
1382618fbe00 Provide backup #defines for things introduced in SDK
             10.0.10240.0
dd85381a32dd GCC fix: Disable -Wmultichar warning throughout Crashpad
5b14b419925f GCC fix: Don’t name a method exactly the same as its
             return type
57b2210ed75d GCC fix: Make UUID POD
f83530bf9a0b GCC fix: Don’t use arraysize() on packed structs
72fbc56e58d3 MSVC++ fix: Don’t declare local[0] arrays for
             ARRAYSIZE_UNSAFE test
b37aa95da79c MSVC++ fix: ALLOW_UNUSED_LOCAL variables only used in
             static_assert
f09d0cde00a1 Improve time handling and error checking
5a21fc157380 Fix Windows build after f09d0cde00a1
8b3eec83e982 win: Add signal handler for SIGABRT to handle abort() calls
68095b6a4e61 Don't LOG(ERROR) for usage, and fix VS2013 build after
             8b3eec8
777634b1ebad Use ADDRESS_SANITIZER instead of
             __has_feature(address_sanitizer)
5b83e58771e2 win: Remove use of rpcrt4 and advapi32 from some util code
f94dd14c45ea win: fix SECURITY_DESCRIPTOR builder on vs2013
556c4e4f5045 Have crashpad call ASan's crash handler if present
f66d5df30cb8 Roll mini_chromium to de1afb0
6b09b08a2202 Update util/file/string_file.cc for new base/numerics API
32981a3ee9d7 win: Fix clang warning in SECURITY_DESCRIPTOR construction

Updated build/secondary GN files to match .gyp changes.

BUG=656800
R=mark@chromium.org

Committed: https://crrev.com/e585bac3b48a1fd12eb7a85ad3d94d823306117f
Cr-Commit-Position: refs/heads/master@{#437376}
==========

[commit-bot: I haz the power, 2016-12-08 22:49:44]

Patchset 5 (id:??) landed as
https://crrev.com/e585bac3b48a1fd12eb7a85ad3d94d823306117f
Cr-Commit-Position: refs/heads/master@{#437376}