Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_extensions.h

Issue 2555353002: Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329 (Closed)
Patch Set: fix readme Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/minidump/minidump_extensions.h
diff --git a/third_party/crashpad/crashpad/minidump/minidump_extensions.h b/third_party/crashpad/crashpad/minidump/minidump_extensions.h
index 68fa6e04a2360bc82306f4498228e025e3ef9451..245ef8b5baa563f4e14a7f64e47a6b94b3765490 100644
--- a/third_party/crashpad/crashpad/minidump/minidump_extensions.h
+++ b/third_party/crashpad/crashpad/minidump/minidump_extensions.h
@@ -162,6 +162,16 @@ enum MinidumpCPUArchitecture : uint16_t {
kMinidumpCPUArchitectureX86Win64 = PROCESSOR_ARCHITECTURE_IA32_ON_WIN64,
kMinidumpCPUArchitectureNeutral = PROCESSOR_ARCHITECTURE_NEUTRAL,
+
+ //! \brief 64-bit ARM.
+ //!
+ //! These systems identify their CPUs generically as “arm64” or “aarch64”, or
+ //! with more specific names such as “armv8”.
+ //!
+ //! \sa #kMinidumpCPUArchitectureARM64Breakpad
+ kMinidumpCPUArchitectureARM64 = PROCESSOR_ARCHITECTURE_ARM64,
+
+ kMinidumpCPUArchitectureARM32Win64 = PROCESSOR_ARCHITECTURE_ARM32_ON_WIN64,
kMinidumpCPUArchitectureSPARC = 0x8001,
//! \brief 64-bit PowerPC.
@@ -170,11 +180,10 @@ enum MinidumpCPUArchitecture : uint16_t {
//! specific names such as “ppc970”.
kMinidumpCPUArchitecturePPC64 = 0x8002,
- //! \brief 64-bit ARM.
+ //! \brief Used by Breakpad for 64-bit ARM.
//!
- //! These systems identify their CPUs generically as “arm64” or “aarch64”, or
- //! with more specific names such as “armv8”.
- kMinidumpCPUArchitectureARM64 = 0x8003,
+ //! \deprecated Use #kMinidumpCPUArchitectureARM64 instead.
+ kMinidumpCPUArchitectureARM64Breakpad = 0x8003,
//! \brief Unknown CPU architecture.
kMinidumpCPUArchitectureUnknown = PROCESSOR_ARCHITECTURE_UNKNOWN,
@@ -209,7 +218,7 @@ enum MinidumpOS : uint32_t {
kMinidumpOSUnix = 0x8000,
- //! \brief Mac OS X, Darwin for traditional systems.
+ //! \brief macOS, Darwin for traditional systems.
kMinidumpOSMacOSX = 0x8101,
//! \brief iOS, Darwin for mobile devices.
@@ -276,7 +285,7 @@ struct ALIGNAS(4) PACKED MinidumpSimpleStringDictionary {
//! #version, so that newer parsers will be able to determine whether the added
//! fields are valid or not.
//!
-//! \sa #MinidumpModuleCrashpadInfoList
+//! \sa MinidumpModuleCrashpadInfoList
struct ALIGNAS(4) PACKED MinidumpModuleCrashpadInfo {
//! \brief The structure’s currently-defined version number.
//!
@@ -423,7 +432,7 @@ struct ALIGNAS(4) PACKED MinidumpCrashpadInfo {
//! This field is present when #version is at least `1`.
MINIDUMP_LOCATION_DESCRIPTOR simple_annotations;
- //! \brief A pointer to a #MinidumpModuleCrashpadInfoList structure.
+ //! \brief A pointer to a MinidumpModuleCrashpadInfoList structure.
//!
//! This field is present when #version is at least `1`.
MINIDUMP_LOCATION_DESCRIPTOR module_list;

Powered by Google App Engine
This is Rietveld 408576698