third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc - Issue 2555353002: Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc

Issue 2555353002: Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329 (Closed)

Patch Set: fix readme Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.h ('k') | third_party/crashpad/crashpad/minidump/minidump_system_info_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc

diff --git a/third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc b/third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc

index c372cd180d5cf6dd726c5027f65f945ad1835cdf..ae8bfabad80c4766c156da84c392c9100636d762 100644

--- a/third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc

+++ b/third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer.cc

@@ -33,8 +33,8 @@ MinidumpSimpleStringDictionaryEntryWriter::

}

const MinidumpSimpleStringDictionaryEntry*

-MinidumpSimpleStringDictionaryEntryWriter::MinidumpSimpleStringDictionaryEntry()

- const {

+MinidumpSimpleStringDictionaryEntryWriter::

+ GetMinidumpSimpleStringDictionaryEntry() const {

DCHECK_EQ(state(), kStateWritable);

return &entry_;

@@ -179,7 +179,7 @@ bool MinidumpSimpleStringDictionaryWriter::WriteObject(

std::vector<WritableIoVec> iovecs(1, iov);

for (const auto& key_entry : entries_) {

- iov.iov_base = key_entry.second->MinidumpSimpleStringDictionaryEntry();

+ iov.iov_base = key_entry.second->GetMinidumpSimpleStringDictionaryEntry();

iov.iov_len = sizeof(MinidumpSimpleStringDictionaryEntry);

iovecs.push_back(iov);

}