Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: third_party/crashpad/crashpad/util/mac/service_management.h

Issue 2555353002: Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329 (Closed)
Patch Set: fix readme Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/crashpad/crashpad/util/mac/mac_util.cc ('k') | third_party/crashpad/crashpad/util/mac/xattr.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/util/mac/service_management.h
diff --git a/third_party/crashpad/crashpad/util/mac/service_management.h b/third_party/crashpad/crashpad/util/mac/service_management.h
index 802e5449e7a4d69dde6ff293e8c0c97d48afcee2..16cb45aaed9aa546e299886af118a0e80ba9e770 100644
--- a/third_party/crashpad/crashpad/util/mac/service_management.h
+++ b/third_party/crashpad/crashpad/util/mac/service_management.h
@@ -28,8 +28,8 @@ namespace crashpad {
//!
//! \return `true` if the job was submitted successfully, otherwise `false`.
//!
-//! \note This function is provided because `SMJobSubmit()` is deprecated in Mac
-//! OS X 10.10. It may or may not be implemented using `SMJobSubmit()` from
+//! \note This function is provided because `SMJobSubmit()` is deprecated in OS
+//! X 10.10. It may or may not be implemented using `SMJobSubmit()` from
//! `ServiceManagement.framework`.
bool ServiceManagementSubmitJob(CFDictionaryRef job_cf);
@@ -42,12 +42,11 @@ bool ServiceManagementSubmitJob(CFDictionaryRef job_cf);
//! \return `true` if the job was removed successfully or if an asynchronous
//! attempt to remove the job was started successfully, otherwise `false`.
//!
-//! \note This function is provided because `SMJobRemove()` is deprecated in Mac
-//! OS X 10.10. On Mac OS X 10.10, observed in DP8 14A361c, it also blocks
-//! for far too long (`_block_until_job_exits()` contains a one-second
-//! `sleep()`, filed as radar 18398683) and does not signal failure via its
-//! return value when asked to remove a nonexistent job (filed as radar
-//! 18268941).
+//! \note This function is provided because `SMJobRemove()` is deprecated in OS
+//! X 10.10. On OS X 10.10, observed in DP8 14A361c, it also blocks for far
+//! too long (`_block_until_job_exits()` contains a one-second `sleep()`,
+//! filed as radar 18398683) and does not signal failure via its return
+//! value when asked to remove a nonexistent job (filed as radar 18268941).
bool ServiceManagementRemoveJob(const std::string& label, bool wait);
//! \brief Determines whether a specified job is loaded in the user launchd
@@ -60,7 +59,7 @@ bool ServiceManagementRemoveJob(const std::string& label, bool wait);
//! \note A loaded job is not necessarily presently running, nor has it
//! necessarily ever run in the past.
//! \note This function is provided because `SMJobCopyDictionary()` is
-//! deprecated in Mac OS X 10.10. It may or may not be implemented using
+//! deprecated in OS X 10.10. It may or may not be implemented using
//! `SMJobCopyDictionary()` from `ServiceManagement.framework`.
bool ServiceManagementIsJobLoaded(const std::string& label);
@@ -72,7 +71,7 @@ bool ServiceManagementIsJobLoaded(const std::string& label);
//! \return The job’s process ID if running, otherwise `0`.
//!
//! \note This function is provided because `SMJobCopyDictionary()` is
-//! deprecated in Mac OS X 10.10. It may or may not be implemented using
+//! deprecated in OS X 10.10. It may or may not be implemented using
//! `SMJobCopyDictionary()` from `ServiceManagement.framework`.
pid_t ServiceManagementIsJobRunning(const std::string& label);
« no previous file with comments | « third_party/crashpad/crashpad/util/mac/mac_util.cc ('k') | third_party/crashpad/crashpad/util/mac/xattr.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698