Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/crashpad/crashpad/util/mach/child_port_handshake.h

Issue 2555353002: Update Crashpad to 32981a3ee9d7c2769fb27afa038fe2e194cfa329 (Closed)
Patch Set: fix readme Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/mach/child_port_handshake.h
diff --git a/third_party/crashpad/crashpad/util/mach/child_port_handshake.h b/third_party/crashpad/crashpad/util/mach/child_port_handshake.h
index 50de118ac70a6596e43291b4a1fd9f8bec3fe2e5..429164a9b53e691381b6d641af7c2bfb374992f5 100644
--- a/third_party/crashpad/crashpad/util/mach/child_port_handshake.h
+++ b/third_party/crashpad/crashpad/util/mach/child_port_handshake.h
@@ -218,6 +218,9 @@ class ChildPortHandshake {
//! - Regardless of return value, destroys the server’s receive right and
//! closes the pipe.
//!
+ //! \param[in] server_write_fd The write side of the pipe shared with the
+ //! client process. This function takes ownership of this file descriptor,
+ //! and will close it prior to returning.
//! \param[in] port_right_type The port right type expected to be received
//! from the client. If the port right received from the client does not
//! match the expected type, the received port right will be destroyed,
@@ -253,9 +256,9 @@ class ChildPortHandshake {
//! `simpleroutine`, and the server does not send a reply. This allows
//! check-in to occur without blocking to wait for a reply.
//!
- //! \param[in] pipe_read The “read” side of the pipe shared with the server
- //! process. This function takes ownership of this file descriptor, and
- //! will close it prior to returning.
+ //! \param[in] client_read_fd The “read” side of the pipe shared with the
+ //! server process. This function takes ownership of this file descriptor,
+ //! and will close it prior to returning.
//! \param[in] port The port right that will be passed to the server by
//! `child_port_check_in()`.
//! \param[in] right_type The right type to furnish the server with. If \a
« no previous file with comments | « third_party/crashpad/crashpad/util/mac/xattr.cc ('k') | third_party/crashpad/crashpad/util/mach/child_port_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698