Remove redundant field initialization in Java code.

Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

NOPRESUBMIT=true

BUG=670001
Committed: https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437
Cr-Commit-Position: refs/heads/master@{#438216}

[agrieve, 2016-12-05 21:35:44]

agrieve@chromium.org changed reviewers:
+ agrieve@chromium.org

[agrieve, 2016-12-05 21:35:45]

lgtm

[estevenson, 2016-12-06 19:05:41]

Description was changed from

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This was completed with Android
Studio (Analyze > Run inspection by name > Redundant field
initialization). This fixes all instances in projects currently
generated by build/android/gradle/generate_gradle.py.

BUG=670001
==========

to

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 7.62 kb.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

BUG=670001
==========

[estevenson, 2016-12-07 16:21:45]

estevenson@chromium.org changed reviewers:
+ brettw@chromium.org

[estevenson, 2016-12-07 16:21:46]

ptal brettw! I thought it'd make sense for you to look at this as opposed to
adding a bunch of other reviewers.

[brettw, 2016-12-07 18:14:32]

I don't know Java details and style guide well enough to feel comfortable
reviewing. If you get a chrome/android reviewer to review the whole thing, I can
give owners stamp for the rest after based on that.

[estevenson, 2016-12-07 18:20:05]

On 2016/12/07 18:14:32, brettw (ping after 24h) wrote:
> I don't know Java details and style guide well enough to feel comfortable
> reviewing. If you get a chrome/android reviewer to review the whole thing, I
can
> give owners stamp for the rest after based on that.

Sounds good, thanks!

[estevenson, 2016-12-07 18:22:33]

estevenson@chromium.org changed reviewers:
+ tedchoc@chromium.org

[estevenson, 2016-12-07 18:22:34]

Can you take a look at the entire CL Ted? If you're okay with the change, then
I'll ask brettw@ to approve the CL instead of adding a whole bunch of reviewers.

[Ted C, 2016-12-07 18:31:20]

On 2016/12/07 18:22:34, estevenson wrote:
> Can you take a look at the entire CL Ted? If you're okay with the change, then
> I'll ask brettw@ to approve the CL instead of adding a whole bunch of
reviewers.

lgtm

[brettw, 2016-12-07 18:39:11]

lgtm

[johnme, 2016-12-07 18:40:26]

There was interesting discussion on
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/ylbLOvLs0bs/dis...
about this being dangerous in some cases.

I'd suggest trying to get agreement on that thread before landing this.

Personally, I also find that removing the initialization makes the code less
readable, since it forces the reader to hunt around for where it is initialized,
whereas e.g. explicitly initializing an object to null helpfully implies that it
is nullable.

[estevenson, 2016-12-07 19:11:20]

On 2016/12/07 18:40:26, johnme wrote:
> There was interesting discussion on
>
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/ylbLOvLs0bs/dis...
> about this being dangerous in some cases.
> 
> I'd suggest trying to get agreement on that thread before landing this.
> 
> Personally, I also find that removing the initialization makes the code less
> readable, since it forces the reader to hunt around for where it is
initialized,
> whereas e.g. explicitly initializing an object to null helpfully implies that
it
> is nullable.

Sure, I'll follow up there before landing this CL.

[Takashi Toyoshima, 2016-12-09 06:06:07]

media/midi lgtm

[mthiesse, 2016-12-09 15:21:24]

mthiesse@chromium.org changed reviewers:
+ mthiesse@chromium.org

[mthiesse, 2016-12-09 15:21:26]

vr_shell/ lgtm

[estevenson, 2016-12-09 15:35:57]

estevenson@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[estevenson, 2016-12-09 15:35:59]

dfalcantara@chromium.org: Please review changes in InfoBarContainer.java

[estevenson, 2016-12-09 15:36:56]

Description was changed from

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 7.62 kb.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

BUG=670001
==========

to

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

BUG=670001
==========

[gone, 2016-12-09 18:29:12]

lgtm

[estevenson, 2016-12-09 18:33:32]

On 2016/12/09 18:29:12, dfalcantara (check my queue) wrote:
> lgtm

Thanks for all the reviews - waiting until next week to land this to give anyone
who's away a chance to chime in!

[estevenson, 2016-12-13 15:41:01]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2016-12-13 15:41:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, toyoshim@chromium.org, mthiesse@chromium.org,
agrieve@chromium.org, brettw@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2548013002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-13 15:41:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 15:52:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 15:52:53]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[estevenson, 2016-12-13 16:50:39]

On 2016/12/13 15:52:53, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Going to try this again with NOPRESUBMIT=true, the presubmit is failing because
printing/android/java/src/org/chromium/printing/PrintDocumentAdapterWrapper.java
is missing javadoc for public methods.

[estevenson, 2016-12-13 16:51:12]

Description was changed from

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

BUG=670001
==========

to

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

NOPRESUBMIT=true

BUG=670001
==========

[estevenson, 2016-12-13 17:46:45]

The CQ bit was checked by estevenson@chromium.org

[commit-bot: I haz the power, 2016-12-13 17:47:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 17:50:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481651205298330,
"parent_rev": "eb50621a24f992a49d019733b6e95d0646a01c1b", "commit_rev":
"0ad1475469d19f5ce65420acb7e2143ab09cf05d"}

[commit-bot: I haz the power, 2016-12-13 17:50:55]

Description was changed from

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

NOPRESUBMIT=true

BUG=670001
==========

to

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

NOPRESUBMIT=true

BUG=670001

Review-Url: https://codereview.chromium.org/2548013002
==========

[commit-bot: I haz the power, 2016-12-13 17:50:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 17:52:44]

Description was changed from

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

NOPRESUBMIT=true

BUG=670001

Review-Url: https://codereview.chromium.org/2548013002
==========

to

==========
Remove redundant field initialization in Java code.

Leaving fields uninitialized results in fewer compiled bytes than
initializing fields to default values. This CL shrinks the uncompressed
size of classes.dex by 8.6 kb for proguarded chrome_public_apk.

Change was made with Android Studio (Analyze > Run inspection by name >
Redundant field initialization), and fixes all instances in projects
currently generated by build/android/gradle/generate_gradle.py.

NOPRESUBMIT=true

BUG=670001

Committed: https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437
Cr-Commit-Position: refs/heads/master@{#438216}
==========

[commit-bot: I haz the power, 2016-12-13 17:52:47]

Patchset 4 (id:??) landed as
https://crrev.com/2b97db470c6419fe4f15daf091789bba251ec437
Cr-Commit-Position: refs/heads/master@{#438216}