Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java

Issue 2548013002: Remove redundant field initialization in Java code. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.webapps; 5 package org.chromium.chrome.browser.webapps;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.content.DialogInterface; 8 import android.content.DialogInterface;
9 import android.graphics.Bitmap; 9 import android.graphics.Bitmap;
10 import android.support.v7.app.AlertDialog; 10 import android.support.v7.app.AlertDialog;
(...skipping 16 matching lines...) Expand all
27 private View mProgressBarView; 27 private View mProgressBarView;
28 private ImageView mIconView; 28 private ImageView mIconView;
29 private EditText mInput; 29 private EditText mInput;
30 30
31 private AddToHomescreenManager mManager; 31 private AddToHomescreenManager mManager;
32 32
33 /** 33 /**
34 * Whether {@link mManager} is ready for {@link AddToHomescreenManager#addSh ortcut()} to be 34 * Whether {@link mManager} is ready for {@link AddToHomescreenManager#addSh ortcut()} to be
35 * called. 35 * called.
36 */ 36 */
37 private boolean mIsReadyToAdd = false; 37 private boolean mIsReadyToAdd;
38 38
39 public AddToHomescreenDialog(AddToHomescreenManager manager) { 39 public AddToHomescreenDialog(AddToHomescreenManager manager) {
40 mManager = manager; 40 mManager = manager;
41 } 41 }
42 42
43 @VisibleForTesting 43 @VisibleForTesting
44 public AlertDialog getAlertDialogForTesting() { 44 public AlertDialog getAlertDialogForTesting() {
45 return mDialog; 45 return mDialog;
46 } 46 }
47 47
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 } 159 }
160 160
161 /** 161 /**
162 * Updates whether the dialog's OK button is enabled. 162 * Updates whether the dialog's OK button is enabled.
163 */ 163 */
164 public void updateAddButtonEnabledState() { 164 public void updateAddButtonEnabledState() {
165 boolean enable = mIsReadyToAdd && !TextUtils.isEmpty(mInput.getText()); 165 boolean enable = mIsReadyToAdd && !TextUtils.isEmpty(mInput.getText());
166 mDialog.getButton(DialogInterface.BUTTON_POSITIVE).setEnabled(enable); 166 mDialog.getButton(DialogInterface.BUTTON_POSITIVE).setEnabled(enable);
167 } 167 }
168 } 168 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698