chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java - Issue 2548013002: Remove redundant field initialization in Java code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

Issue 2548013002: Remove redundant field initialization in Java code. (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindResultBar.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

index 1d5428430e7b7477bcbffe4934c0d135480833e9..1de6c0ecfce2c0c0825bebf3f6f867227d0483f8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java

@@ -62,7 +62,7 @@ public class FindToolbar extends LinearLayout

protected TintedImageButton mFindPrevButton;

protected TintedImageButton mFindNextButton;

- private FindResultBar mResultBar = null;

+ private FindResultBar mResultBar;

private TabModelSelector mTabModelSelector;

private final TabModelSelectorObserver mTabModelSelectorObserver;

@@ -77,12 +77,12 @@ public class FindToolbar extends LinearLayout

private String mLastUserSearch = "";

/** Whether toolbar text is being set automatically (not typed by user). */

- private boolean mSettingFindTextProgrammatically = false;

+ private boolean mSettingFindTextProgrammatically;

/** Whether the search key should trigger a new search. */

- private boolean mSearchKeyShouldTriggerSearch = false;

+ private boolean mSearchKeyShouldTriggerSearch;

- private boolean mActive = false;

+ private boolean mActive;

private Handler mHandler = new Handler();

private Runnable mAccessibleAnnouncementRunnable;

@@ -335,7 +335,7 @@ public class FindToolbar extends LinearLayout

mAccessibilityDidActivateResult = true;

}

- private boolean mShowKeyboardOnceWindowIsFocused = false;

+ private boolean mShowKeyboardOnceWindowIsFocused;

@Override

public void onWindowFocusChanged(boolean hasFocus) {