Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java

Issue 2548013002: Remove redundant field initialization in Java code. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.compositor.layouts.components; 5 package org.chromium.chrome.browser.compositor.layouts.components;
6 6
7 import static org.chromium.chrome.browser.compositor.layouts.ChromeAnimation.Ani matableAnimation.createAnimation; 7 import static org.chromium.chrome.browser.compositor.layouts.ChromeAnimation.Ani matableAnimation.createAnimation;
8 8
9 import android.content.Context; 9 import android.content.Context;
10 import android.content.res.Resources; 10 import android.content.res.Resources;
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 private final RectF mBounds = new RectF(); // Pre-allocated to avoid in-fram e allocations. 107 private final RectF mBounds = new RectF(); // Pre-allocated to avoid in-fram e allocations.
108 private final RectF mClosePlacement = new RectF(); 108 private final RectF mClosePlacement = new RectF();
109 109
110 /** Whether we need to draw the decoration (border, shadow, ..) at all. */ 110 /** Whether we need to draw the decoration (border, shadow, ..) at all. */
111 private float mDecorationAlpha; 111 private float mDecorationAlpha;
112 112
113 /** 113 /**
114 * Whether this tab need to have its title texture generated. As this is not a free operation 114 * Whether this tab need to have its title texture generated. As this is not a free operation
115 * knowing that we won't show it might save a few cycles and memory. 115 * knowing that we won't show it might save a few cycles and memory.
116 */ 116 */
117 private boolean mIsTitleNeeded = false; 117 private boolean mIsTitleNeeded;
118 118
119 /** 119 /**
120 * Whether initFromHost() has been called since the last call to init(). 120 * Whether initFromHost() has been called since the last call to init().
121 */ 121 */
122 private boolean mInitFromHostCalled = false; 122 private boolean mInitFromHostCalled;
123 123
124 /** The animation set specific to this LayoutTab. */ 124 /** The animation set specific to this LayoutTab. */
125 private ChromeAnimation<ChromeAnimation.Animatable<?>> mCurrentAnimations; 125 private ChromeAnimation<ChromeAnimation.Animatable<?>> mCurrentAnimations;
126 private int mInitialThemeColor; 126 private int mInitialThemeColor;
127 private int mFinalThemeColor; 127 private int mFinalThemeColor;
128 128
129 // All the members bellow are initialized from the delayed initialization. 129 // All the members bellow are initialized from the delayed initialization.
130 // 130 //
131 // Begin section -------------- 131 // Begin section --------------
132 132
(...skipping 887 matching lines...) Expand 10 before | Expand all | Expand 10 after
1020 } 1020 }
1021 } 1021 }
1022 1022
1023 @Override 1023 @Override
1024 public void onPropertyAnimationFinished(Property prop) { 1024 public void onPropertyAnimationFinished(Property prop) {
1025 if (mCurrentAnimations != null && mCurrentAnimations.finished()) { 1025 if (mCurrentAnimations != null && mCurrentAnimations.finished()) {
1026 mCurrentAnimations = null; 1026 mCurrentAnimations = null;
1027 } 1027 }
1028 } 1028 }
1029 } 1029 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698