Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/metrics/WebappUma.java

Issue 2548013002: Remove redundant field initialization in Java code. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.metrics; 5 package org.chromium.chrome.browser.metrics;
6 6
7 import android.os.SystemClock; 7 import android.os.SystemClock;
8 8
9 import org.chromium.base.metrics.RecordHistogram; 9 import org.chromium.base.metrics.RecordHistogram;
10 10
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 "Webapp.Splashscreen.Icon.Type"; 44 "Webapp.Splashscreen.Icon.Type";
45 public static final String HISTOGRAM_SPLASHSCREEN_ICON_SIZE = 45 public static final String HISTOGRAM_SPLASHSCREEN_ICON_SIZE =
46 "Webapp.Splashscreen.Icon.Size"; 46 "Webapp.Splashscreen.Icon.Size";
47 public static final String HISTOGRAM_SPLASHSCREEN_THEMECOLOR = 47 public static final String HISTOGRAM_SPLASHSCREEN_THEMECOLOR =
48 "Webapp.Splashscreen.ThemeColor"; 48 "Webapp.Splashscreen.ThemeColor";
49 49
50 private int mSplashScreenBackgroundColor = SPLASHSCREEN_COLOR_STATUS_MAX; 50 private int mSplashScreenBackgroundColor = SPLASHSCREEN_COLOR_STATUS_MAX;
51 private int mSplashScreenIconType = SPLASHSCREEN_ICON_TYPE_MAX; 51 private int mSplashScreenIconType = SPLASHSCREEN_ICON_TYPE_MAX;
52 private int mSplashScreenIconSize = -1; 52 private int mSplashScreenIconSize = -1;
53 private int mSplashScreenThemeColor = SPLASHSCREEN_COLOR_STATUS_MAX; 53 private int mSplashScreenThemeColor = SPLASHSCREEN_COLOR_STATUS_MAX;
54 private long mSplashScreenVisibleTime = 0; 54 private long mSplashScreenVisibleTime;
55 55
56 private boolean mCommitted = false; 56 private boolean mCommitted;
57 57
58 /** 58 /**
59 * Signal that the splash screen is now visible. This is being used to 59 * Signal that the splash screen is now visible. This is being used to
60 * record for how long the splash screen is left visible. 60 * record for how long the splash screen is left visible.
61 */ 61 */
62 public void splashscreenVisible() { 62 public void splashscreenVisible() {
63 assert mSplashScreenVisibleTime == 0; 63 assert mSplashScreenVisibleTime == 0;
64 mSplashScreenVisibleTime = SystemClock.elapsedRealtime(); 64 mSplashScreenVisibleTime = SystemClock.elapsedRealtime();
65 } 65 }
66 66
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 mSplashScreenIconType = SPLASHSCREEN_ICON_TYPE_MAX; 146 mSplashScreenIconType = SPLASHSCREEN_ICON_TYPE_MAX;
147 mSplashScreenIconSize = -1; 147 mSplashScreenIconSize = -1;
148 148
149 assert mSplashScreenThemeColor != SPLASHSCREEN_COLOR_STATUS_MAX; 149 assert mSplashScreenThemeColor != SPLASHSCREEN_COLOR_STATUS_MAX;
150 RecordHistogram.recordEnumeratedHistogram(HISTOGRAM_SPLASHSCREEN_THEMECO LOR, 150 RecordHistogram.recordEnumeratedHistogram(HISTOGRAM_SPLASHSCREEN_THEMECO LOR,
151 mSplashScreenThemeColor, 151 mSplashScreenThemeColor,
152 SPLASHSCREEN_COLOR_STATUS_MAX); 152 SPLASHSCREEN_COLOR_STATUS_MAX);
153 mSplashScreenThemeColor = SPLASHSCREEN_COLOR_STATUS_MAX; 153 mSplashScreenThemeColor = SPLASHSCREEN_COLOR_STATUS_MAX;
154 } 154 }
155 } 155 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698