Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3098)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackTab.java

Issue 2548013002: Remove redundant field initialization in Java code. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackTab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackTab.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackTab.java
index 95936b68d7adc0130a345b00359ac6c604b3170b..dac243e98a57984ab1e6c2ed41987276416e1350 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackTab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackTab.java
@@ -47,18 +47,18 @@ public class StackTab implements ChromeAnimation.Animatable<StackTab.Property> {
private float mYInStackInfluence = 1.0f;
// In stack positioner
- private float mScrollOffset = 0.0f;
- private float mXInStackOffset = 0.0f;
- private float mYInStackOffset = 0.0f;
+ private float mScrollOffset;
+ private float mXInStackOffset;
+ private float mYInStackOffset;
// Out of stack positioner
- private float mXOutOfStack = 0.0f;
- private float mYOutOfStack = 0.0f;
+ private float mXOutOfStack;
+ private float mYOutOfStack;
// Values that get animated
private float mAlpha = 1.0f;
private float mScale = 1.0f;
- private float mDiscardAmount = 0.0f; // This might alter position, rotation and alpha
+ private float mDiscardAmount; // This might alter position, rotation and alpha
// Discard states
private float mDiscardOriginX;
@@ -69,17 +69,17 @@ public class StackTab implements ChromeAnimation.Animatable<StackTab.Property> {
private int mIndex;
// True if the tab is currently being removed (while animating).
- protected boolean mDying = false;
+ protected boolean mDying;
// The visibility sorting value is used to determine the importance of the tab for
// texture allocation. It is computed from the area and its position in the stack.
// Larger values will have more priority for acquiring texture. Negative values "often"
// means that the tab is not visible at all (but there are no guaranty and it's fine).
- private float mCachedVisibleArea = 0; // Intermediate value
- private float mCachedIndexDistance = 0; // Intermediate value
+ private float mCachedVisibleArea; // Intermediate value
+ private float mCachedIndexDistance; // Intermediate value
private float mCacheStackVisibility = 1.0f; // Intermediate value
- private long mVisiblitySortingValue = 0; // Sorting value based on visible area.
- private int mOrderSortingValue = 0; // Sorting value based on distance to selection.
+ private long mVisiblitySortingValue; // Sorting value based on visible area.
+ private int mOrderSortingValue; // Sorting value based on distance to selection.
private LayoutTab mLayoutTab;

Powered by Google App Engine
This is Rietveld 408576698