Remove LauncherItemController::type; use ShelfItems::type.

Remove LauncherItemController::type; use ShelfItem::type.

ShelfItem should contain the info needed for a shelf item.
Reduce reliance on ShelfItemDelegate/LauncherItemController.
(shrink ash<->chrome surface, prep for ShelfWindowWatcher use)

Add ChromeLauncherController::[GetItem|SetItemType] helpers.
Nix unused ash::TYPE_IME_MENU. Inline GetV1ApplicationsFromController

BUG=557406
TEST=No Chrome OS shelf behavior changes or regressions.
R=jamescook@chromium.org

Committed: https://crrev.com/18242dedc63f2b5b095f6a93f04e0dca85de4292
Cr-Commit-Position: refs/heads/master@{#436014}

[msw, 2016-12-02 00:41:41]

Description was changed from

==========
Remove LauncherItemController::type; use ShelfItem::type.

BUG=557406
==========

to

==========
Remove LauncherItemController::type; use ShelfItem::type.

ShelfItem should contain the info needed for a shelf item.
Reduce reliance on ShelfItemDelegate/LauncherItemController.
(shrink ash<->chrome surface, prep for ShelfWindowWatcher use)

Add ChromeLauncherController::[GetItem|SetItemType] helpers.
Nix unused ash::TYPE_IME_MENU. Inline GetV1ApplicationsFromController

BUG=557406
TEST=No Chrome OS shelf behavior changes or regressions.
R=jamescook@chromium.org
==========

[msw, 2016-12-02 00:41:42]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-12-02 02:19:10]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 02:19:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 02:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 02:23:11]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-12-02 02:41:52]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 02:42:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-12-02 02:59:26]

Hey James, please take a look; thanks!

https://codereview.chromium.org/2545923004/diff/40001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc (right):

https://codereview.chromium.org/2545923004/diff/40001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:301:
ash::TYPE_APP);
note: the two callers of CreateAppLauncherItem supplied
ArcAppWindowLauncherItemController (always TYPE_APP) and
ExtensionAppWindowLauncherItemController instances constructed with TYPE_APP, so
it's safe to infer that CreateAppLauncherItem callers want TYPE_APP items.

[commit-bot: I haz the power, 2016-12-02 03:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 03:14:25]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-12-02 19:27:18]

LGTM. It's great to see less duplication between ash and chrome launcher stuff.

https://codereview.chromium.org/2545923004/diff/60001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_item_types.h (left):

https://codereview.chromium.org/2545923004/diff/60001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_item_types.h:41: // The expanded IME menu in the shelf.
Thanks for cleaning this up.

https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h (right):

https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h:97: const
ash::ShelfItem fake_item_;
optional: This could be a static ash::ShelfItem inside the GetItem() function.

https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/launcher_item_controller.cc (left):

https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/launcher_item_controller.cc:26: if
(extension_misc::IsImeMenuExtensionId(app_id_))
Can you file a bug about removing this method? I think that the last remaining
caller (in ChromeNativeAppWindowViews) isn't relevant anymore now that the menu
isn't a panel.

[msw, 2016-12-02 19:37:58]

https://codereview.chromium.org/2545923004/diff/60001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_item_types.h (left):

https://codereview.chromium.org/2545923004/diff/60001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_item_types.h:41: // The expanded IME menu in the shelf.
On 2016/12/02 19:27:18, James Cook wrote:
> Thanks for cleaning this up.

Acknowledged.

https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h (right):

https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h:97: const
ash::ShelfItem fake_item_;
On 2016/12/02 19:27:18, James Cook wrote:
> optional: This could be a static ash::ShelfItem inside the GetItem() function.

I tried that first and got error: declaration requires an exit-time destructor

https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/launcher_item_controller.cc (left):

https://codereview.chromium.org/2545923004/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/launcher_item_controller.cc:26: if
(extension_misc::IsImeMenuExtensionId(app_id_))
On 2016/12/02 19:27:18, James Cook wrote:
> Can you file a bug about removing this method? I think that the last remaining
> caller (in ChromeNativeAppWindowViews) isn't relevant anymore now that the
menu
> isn't a panel.

It's also used in
chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc, but is also
likely invalid, since it's no longer a launcher item... Filed
http://crbug.com/670825

[msw, 2016-12-02 19:38:04]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:39:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 20:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 20:01:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-12-02 20:10:15]

+CC khmel@ for arc, especially arc_app_launcher_browsertest.cc

[msw, 2016-12-02 20:10:26]

The CQ bit was checked by msw@chromium.org

[msw, 2016-12-02 20:10:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2545923004/#ps80001
(title: "Rebase; remove new LauncherItemController::TYPE_APP check.")

[commit-bot: I haz the power, 2016-12-02 20:11:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 21:09:33]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480709426038340,
"parent_rev": "24017c04e2feea6c2a52c6725fe0ecb6b37b9c05", "commit_rev":
"52761578b76bacb18d1c6f8bd0c6d099286411ae"}

[commit-bot: I haz the power, 2016-12-02 21:10:01]

Description was changed from

==========
Remove LauncherItemController::type; use ShelfItem::type.

ShelfItem should contain the info needed for a shelf item.
Reduce reliance on ShelfItemDelegate/LauncherItemController.
(shrink ash<->chrome surface, prep for ShelfWindowWatcher use)

Add ChromeLauncherController::[GetItem|SetItemType] helpers.
Nix unused ash::TYPE_IME_MENU. Inline GetV1ApplicationsFromController

BUG=557406
TEST=No Chrome OS shelf behavior changes or regressions.
R=jamescook@chromium.org
==========

to

==========
Remove LauncherItemController::type; use ShelfItem::type.

ShelfItem should contain the info needed for a shelf item.
Reduce reliance on ShelfItemDelegate/LauncherItemController.
(shrink ash<->chrome surface, prep for ShelfWindowWatcher use)

Add ChromeLauncherController::[GetItem|SetItemType] helpers.
Nix unused ash::TYPE_IME_MENU. Inline GetV1ApplicationsFromController

BUG=557406
TEST=No Chrome OS shelf behavior changes or regressions.
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2016-12-02 21:10:03]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-02 21:14:08]

Description was changed from

==========
Remove LauncherItemController::type; use ShelfItem::type.

ShelfItem should contain the info needed for a shelf item.
Reduce reliance on ShelfItemDelegate/LauncherItemController.
(shrink ash<->chrome surface, prep for ShelfWindowWatcher use)

Add ChromeLauncherController::[GetItem|SetItemType] helpers.
Nix unused ash::TYPE_IME_MENU. Inline GetV1ApplicationsFromController

BUG=557406
TEST=No Chrome OS shelf behavior changes or regressions.
R=jamescook@chromium.org
==========

to

==========
Remove LauncherItemController::type; use ShelfItem::type.

ShelfItem should contain the info needed for a shelf item.
Reduce reliance on ShelfItemDelegate/LauncherItemController.
(shrink ash<->chrome surface, prep for ShelfWindowWatcher use)

Add ChromeLauncherController::[GetItem|SetItemType] helpers.
Nix unused ash::TYPE_IME_MENU. Inline GetV1ApplicationsFromController

BUG=557406
TEST=No Chrome OS shelf behavior changes or regressions.
R=jamescook@chromium.org

Committed: https://crrev.com/18242dedc63f2b5b095f6a93f04e0dca85de4292
Cr-Commit-Position: refs/heads/master@{#436014}
==========

[commit-bot: I haz the power, 2016-12-02 21:14:09]

Patchset 5 (id:??) landed as
https://crrev.com/18242dedc63f2b5b095f6a93f04e0dca85de4292
Cr-Commit-Position: refs/heads/master@{#436014}