chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc - Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type. (Closed)

Patch Set: Rebase; remove new LauncherItemController::TYPE_APP check. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

index f978a25602c47db1663f931ca11220a9ab1f3344..059ebcbb3512583fa764a9e146732539fa2961f9 100644

--- a/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

+++ b/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

@@ -79,7 +79,7 @@ AppShortcutLauncherItemController::AppShortcutLauncherItemController(

const std::string& app_id,

const std::string& launch_id,

ChromeLauncherController* controller)

- : LauncherItemController(TYPE_SHORTCUT, app_id, launch_id, controller),

+ : LauncherItemController(app_id, launch_id, controller),

chrome_launcher_controller_(controller) {

// To detect V1 applications we use their domain and match them against the

// used URL. This will also work with applications like Google Drive.

« no previous file with comments | « ash/common/shelf/shelf_view.cc ('k') | chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h » ('j') | no next file with comments »