Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2352)

Unified Diff: ash/common/shelf/shelf_view.cc

Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type. (Closed)
Patch Set: Rebase; remove new LauncherItemController::TYPE_APP check. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/shelf/shelf_view.cc
diff --git a/ash/common/shelf/shelf_view.cc b/ash/common/shelf/shelf_view.cc
index 92d5f094ec01df0cc07c3ec93b2a5bab2fab93a6..74cc4bc1d4becf8fbfdfc9ca51045e65afdcc672 100644
--- a/ash/common/shelf/shelf_view.cc
+++ b/ash/common/shelf/shelf_view.cc
@@ -597,7 +597,6 @@ void ShelfView::ButtonPressed(views::Button* sender,
case TYPE_APP_PANEL:
case TYPE_DIALOG:
- case TYPE_IME_MENU:
break;
case TYPE_UNDEFINED:
@@ -1075,8 +1074,7 @@ views::View* ShelfView::CreateViewForItem(const ShelfItem& item) {
case TYPE_APP_SHORTCUT:
case TYPE_BROWSER_SHORTCUT:
case TYPE_APP:
- case TYPE_DIALOG:
- case TYPE_IME_MENU: {
+ case TYPE_DIALOG: {
ShelfButton* button = new ShelfButton(this, this);
button->SetImage(item.image);
ReflectItemStatus(item, button);
@@ -1403,7 +1401,6 @@ bool ShelfView::SameDragType(ShelfItemType typea, ShelfItemType typeb) const {
case TYPE_APP_LIST:
case TYPE_APP:
case TYPE_DIALOG:
- case TYPE_IME_MENU:
return typeb == typea;
case TYPE_UNDEFINED:
NOTREACHED() << "ShelfItemType must be set.";
@@ -1726,8 +1723,7 @@ void ShelfView::ShelfItemChanged(int model_index, const ShelfItem& old_item) {
case TYPE_APP_SHORTCUT:
case TYPE_BROWSER_SHORTCUT:
case TYPE_APP:
- case TYPE_DIALOG:
- case TYPE_IME_MENU: {
+ case TYPE_DIALOG: {
CHECK_EQ(ShelfButton::kViewClassName, view->GetClassName());
ShelfButton* button = static_cast<ShelfButton*>(view);
ReflectItemStatus(item, button);
« no previous file with comments | « ash/common/shelf/shelf_model.cc ('k') | chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698