Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1954)

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type. (Closed)
Patch Set: Rebase; remove new LauncherItemController::TYPE_APP check. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h" 5 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/profiles/profile_manager.h" 9 #include "chrome/browser/profiles/profile_manager.h"
10 #include "chrome/browser/ui/ash/chrome_launcher_prefs.h" 10 #include "chrome/browser/ui/ash/chrome_launcher_prefs.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 } 62 }
63 63
64 ash::ShelfID ChromeLauncherControllerMus::CreateAppLauncherItem( 64 ash::ShelfID ChromeLauncherControllerMus::CreateAppLauncherItem(
65 LauncherItemController* controller, 65 LauncherItemController* controller,
66 const std::string& app_id, 66 const std::string& app_id,
67 ash::ShelfItemStatus status) { 67 ash::ShelfItemStatus status) {
68 NOTIMPLEMENTED(); 68 NOTIMPLEMENTED();
69 return ash::TYPE_UNDEFINED; 69 return ash::TYPE_UNDEFINED;
70 } 70 }
71 71
72 const ash::ShelfItem& ChromeLauncherControllerMus::GetItem(
73 ash::ShelfID id) const {
74 NOTIMPLEMENTED();
75 return fake_item_;
76 }
77
78 void ChromeLauncherControllerMus::SetItemType(ash::ShelfID id,
79 ash::ShelfItemType type) {
80 NOTIMPLEMENTED();
81 }
82
72 void ChromeLauncherControllerMus::SetItemStatus(ash::ShelfID id, 83 void ChromeLauncherControllerMus::SetItemStatus(ash::ShelfID id,
73 ash::ShelfItemStatus status) { 84 ash::ShelfItemStatus status) {
74 NOTIMPLEMENTED(); 85 NOTIMPLEMENTED();
75 } 86 }
76 87
77 void ChromeLauncherControllerMus::SetItemController( 88 void ChromeLauncherControllerMus::SetItemController(
78 ash::ShelfID id, 89 ash::ShelfID id,
79 LauncherItemController* controller) { 90 LauncherItemController* controller) {
80 NOTIMPLEMENTED(); 91 NOTIMPLEMENTED();
81 } 92 }
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 } 209 }
199 210
200 std::vector<content::WebContents*> 211 std::vector<content::WebContents*>
201 ChromeLauncherControllerMus::GetV1ApplicationsFromAppId( 212 ChromeLauncherControllerMus::GetV1ApplicationsFromAppId(
202 const std::string& app_id) { 213 const std::string& app_id) {
203 NOTIMPLEMENTED(); 214 NOTIMPLEMENTED();
204 return std::vector<content::WebContents*>(); 215 return std::vector<content::WebContents*>();
205 } 216 }
206 217
207 void ChromeLauncherControllerMus::ActivateShellApp(const std::string& app_id, 218 void ChromeLauncherControllerMus::ActivateShellApp(const std::string& app_id,
208 int index) { 219 int window_index) {
209 NOTIMPLEMENTED(); 220 NOTIMPLEMENTED();
210 } 221 }
211 222
212 bool ChromeLauncherControllerMus::IsWebContentHandledByApplication( 223 bool ChromeLauncherControllerMus::IsWebContentHandledByApplication(
213 content::WebContents* web_contents, 224 content::WebContents* web_contents,
214 const std::string& app_id) { 225 const std::string& app_id) {
215 NOTIMPLEMENTED(); 226 NOTIMPLEMENTED();
216 return false; 227 return false;
217 } 228 }
218 229
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 app_id_to_item_delegate_.insert( 315 app_id_to_item_delegate_.insert(
305 std::make_pair(app_id, std::move(delegate))); 316 std::make_pair(app_id, std::move(delegate)));
306 317
307 AppIconLoader* app_icon_loader = GetAppIconLoaderForApp(app_id); 318 AppIconLoader* app_icon_loader = GetAppIconLoaderForApp(app_id);
308 if (app_icon_loader) { 319 if (app_icon_loader) {
309 app_icon_loader->FetchImage(app_id); 320 app_icon_loader->FetchImage(app_id);
310 app_icon_loader->UpdateImage(app_id); 321 app_icon_loader->UpdateImage(app_id);
311 } 322 }
312 } 323 }
313 } 324 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698