Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type. (Closed)
Patch Set: Rebase; remove new LauncherItemController::TYPE_APP check. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
index 0576560419d0cfe700a2f7b7290c4a8913c96e2c..d4156922efdd0469185a87cffdd56f9417d617ae 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
@@ -69,6 +69,17 @@ ash::ShelfID ChromeLauncherControllerMus::CreateAppLauncherItem(
return ash::TYPE_UNDEFINED;
}
+const ash::ShelfItem& ChromeLauncherControllerMus::GetItem(
+ ash::ShelfID id) const {
+ NOTIMPLEMENTED();
+ return fake_item_;
+}
+
+void ChromeLauncherControllerMus::SetItemType(ash::ShelfID id,
+ ash::ShelfItemType type) {
+ NOTIMPLEMENTED();
+}
+
void ChromeLauncherControllerMus::SetItemStatus(ash::ShelfID id,
ash::ShelfItemStatus status) {
NOTIMPLEMENTED();
@@ -205,7 +216,7 @@ ChromeLauncherControllerMus::GetV1ApplicationsFromAppId(
}
void ChromeLauncherControllerMus::ActivateShellApp(const std::string& app_id,
- int index) {
+ int window_index) {
NOTIMPLEMENTED();
}

Powered by Google App Engine
This is Rietveld 408576698