Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h

Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type. (Closed)
Patch Set: Rebase; remove new LauncherItemController::TYPE_APP check. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
index 86971f7bea58034e46380bc7bae0e9670267dae4..7c733c4ec401d4e950e8c3b957dedeb4b4bf8c3d 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
@@ -63,6 +63,8 @@ class ChromeLauncherControllerImpl
ash::ShelfID CreateAppLauncherItem(LauncherItemController* controller,
const std::string& app_id,
ash::ShelfItemStatus status) override;
+ const ash::ShelfItem& GetItem(ash::ShelfID id) const override;
+ void SetItemType(ash::ShelfID id, ash::ShelfItemType type) override;
void SetItemStatus(ash::ShelfID id, ash::ShelfItemStatus status) override;
void SetItemController(ash::ShelfID id,
LauncherItemController* controller) override;
@@ -100,7 +102,7 @@ class ChromeLauncherControllerImpl
int event_flags) override;
std::vector<content::WebContents*> GetV1ApplicationsFromAppId(
const std::string& app_id) override;
- void ActivateShellApp(const std::string& app_id, int index) override;
+ void ActivateShellApp(const std::string& app_id, int window_index) override;
bool IsWebContentHandledByApplication(content::WebContents* web_contents,
const std::string& app_id) override;
bool ContentCanBeHandledByGmailApp(
@@ -221,10 +223,6 @@ class ChromeLauncherControllerImpl
int index,
ash::ShelfItemType shelf_item_type);
- // Enumerate all Web contents which match a given shortcut |controller|.
- std::vector<content::WebContents*> GetV1ApplicationsFromController(
- LauncherItemController* controller);
-
// Create ShelfItem for Browser Shortcut.
void CreateBrowserShortcutLauncherItem();

Powered by Google App Engine
This is Rietveld 408576698