Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/ui/ash/launcher/launcher_item_controller.cc

Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type. (Closed)
Patch Set: Rebase; remove new LauncherItemController::TYPE_APP check. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_item_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/launcher_item_controller.cc
diff --git a/chrome/browser/ui/ash/launcher/launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/launcher_item_controller.cc
index 53605f7155237efc7cf73848dfdfa3495c41076b..aba8fe133a5676e6fe6f7455633ea97ff44e7f33 100644
--- a/chrome/browser/ui/ash/launcher/launcher_item_controller.cc
+++ b/chrome/browser/ui/ash/launcher/launcher_item_controller.cc
@@ -8,12 +8,10 @@
#include "chrome/common/extensions/extension_constants.h"
LauncherItemController::LauncherItemController(
- Type type,
const std::string& app_id,
const std::string& launch_id,
ChromeLauncherController* launcher_controller)
- : type_(type),
- app_id_(app_id),
+ : app_id_(app_id),
launch_id_(launch_id),
shelf_id_(0),
launcher_controller_(launcher_controller),
@@ -21,19 +19,3 @@ LauncherItemController::LauncherItemController(
image_set_by_controller_(false) {}
LauncherItemController::~LauncherItemController() {}
-
-ash::ShelfItemType LauncherItemController::GetShelfItemType() const {
- if (extension_misc::IsImeMenuExtensionId(app_id_))
- return ash::TYPE_IME_MENU;
-
- switch (type_) {
- case LauncherItemController::TYPE_SHORTCUT:
- return ash::TYPE_APP_SHORTCUT;
- case LauncherItemController::TYPE_APP:
- return ash::TYPE_APP;
- case LauncherItemController::TYPE_APP_PANEL:
- return ash::TYPE_APP_PANEL;
- }
- NOTREACHED();
- return ash::TYPE_APP_SHORTCUT;
-}
« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_item_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698