Split //ui/display and create //ui/display/manager.

Split //ui/display and create //ui/display/manager.

Split //ui/display so that general display code stays in //ui/display
and display management code is now in //ui/display/manager. This is
necessary as //ui/base has a dependency on //ui/display and code that is
being refactored out of ash has a dependency on //ui/base, forming a
cycle.

Create //ui/display/manager target. Move the files in
src/ui/display/chromeos to src/ui/display/manager/chromeos since they
are all related to display management. Update includes and targets for
the moved files.

BUG=667344
TBR=sadrul,reveman
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d
Cr-Commit-Position: refs/heads/master@{#435703}

[kylechar, 2016-11-30 21:30:40]

Description was changed from

==========
Split //ui/display and create //ui/display/manager.

WIP.

BUG=667344
==========

to

==========
Split //ui/display and create //ui/display/manager.

WIP.

BUG=667344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-11-30 22:24:24]

Description was changed from

==========
Split //ui/display and create //ui/display/manager.

WIP.

BUG=667344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Split //ui/display and create //ui/display/manager.

Split //ui/display so that general display code stays in //ui/display
and display management code is now in //ui/display/manager. This is
necessary as //ui/base has a dependency on //ui/display and code that is
being refactored out of ash has a dependency on //ui/base, forming a
cycle.

Create //ui/display/manager target. Move the files in
src/ui/display/chromeos to src/ui/display/manager/chromeos since they
are all related to display management. Update includes and targets for
the moved files.

BUG=667344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-11-30 22:24:56]

kylechar@chromium.org changed reviewers:
+ oshima@chromium.org

[kylechar, 2016-11-30 22:24:57]

+oshima for ash/*, ui/display/* and general review.

[oshima, 2016-11-30 22:55:38]

lgtm

The split is inevitable, so thank you for doing this.
It's probably better to switch namespace (many of them are still in ui for
historical reasons) but we can do it later when we have a chance/time.

https://codereview.chromium.org/2540313002/diff/20001/ui/display/manager/disp...
File ui/display/manager/display_manager_export.h (right):

https://codereview.chromium.org/2540313002/diff/20001/ui/display/manager/disp...
ui/display/manager/display_manager_export.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
nit: 2016

[kylechar, 2016-12-01 01:04:34]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 01:04:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 01:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 01:14:56]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kylechar, 2016-12-01 02:47:44]

Patchset #3 (id:40001) has been deleted

[kylechar, 2016-12-01 03:03:33]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 03:03:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 04:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 04:56:25]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-12-01 13:46:11]

kylechar@chromium.org changed reviewers:
+ asargent@chromium.org, dalecurtis@chromium.org, lhchavez@chromium.org,
reveman@chromium.org, sadrul@chromium.org, stevenjb@chromium.org

[kylechar, 2016-12-01 13:46:12]

+asargent for chrome/browser/extensions/* and extensions/*
+stevenjb for chrome/browser/ui/webui/options/*
+lhchavez for components/arc/*
+reveman for components/exo/*
+dalecurtis for media/gpu/*
+sadrul for moved DEPS files that allows "+ui/" stuff

[kylechar, 2016-12-01 13:47:53]

Thanks oshima!

https://codereview.chromium.org/2540313002/diff/20001/ui/display/manager/disp...
File ui/display/manager/display_manager_export.h (right):

https://codereview.chromium.org/2540313002/diff/20001/ui/display/manager/disp...
ui/display/manager/display_manager_export.h:1: // Copyright 2014 The Chromium
Authors. All rights reserved.
On 2016/11/30 22:55:38, oshima wrote:
> nit: 2016

Done.

[stevenjb, 2016-12-01 16:58:46]

chrome/browser/ui/webui/options/ lgtm

[Luis Héctor Chávez, 2016-12-01 17:29:45]

components/arc/ rs-lgtm

[kylechar, 2016-12-01 18:46:16]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 18:46:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[asargent_no_longer_on_chrome, 2016-12-01 19:05:59]

extensions parts lgtm

[DaleCurtis, 2016-12-01 19:09:06]

media/ lgtm

[commit-bot: I haz the power, 2016-12-01 20:40:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 20:40:35]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-12-01 20:41:25]

Description was changed from

==========
Split //ui/display and create //ui/display/manager.

Split //ui/display so that general display code stays in //ui/display
and display management code is now in //ui/display/manager. This is
necessary as //ui/base has a dependency on //ui/display and code that is
being refactored out of ash has a dependency on //ui/base, forming a
cycle.

Create //ui/display/manager target. Move the files in
src/ui/display/chromeos to src/ui/display/manager/chromeos since they
are all related to display management. Update includes and targets for
the moved files.

BUG=667344
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Split //ui/display and create //ui/display/manager.

Split //ui/display so that general display code stays in //ui/display
and display management code is now in //ui/display/manager. This is
necessary as //ui/base has a dependency on //ui/display and code that is
being refactored out of ash has a dependency on //ui/base, forming a
cycle.

Create //ui/display/manager target. Move the files in
src/ui/display/chromeos to src/ui/display/manager/chromeos since they
are all related to display management. Update includes and targets for
the moved files.

BUG=667344
TBR=sadrul,reveman
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[kylechar, 2016-12-01 20:41:50]

TBRing reveman and sadrul.

[kylechar, 2016-12-01 20:41:59]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-12-01 20:42:00]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
stevenjb@chromium.org, lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2540313002/#ps80001
(title: "Cleanup export header.")

[commit-bot: I haz the power, 2016-12-01 20:42:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 20:50:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480624919783380,
"parent_rev": "e68d07d7aeab53b9dcec23fd154352a996d8e5b8", "commit_rev":
"34b3326c8a899d4e80ecb2752b7dc425ee9e1aa1"}

[commit-bot: I haz the power, 2016-12-01 20:51:20]

Description was changed from

==========
Split //ui/display and create //ui/display/manager.

Split //ui/display so that general display code stays in //ui/display
and display management code is now in //ui/display/manager. This is
necessary as //ui/base has a dependency on //ui/display and code that is
being refactored out of ash has a dependency on //ui/base, forming a
cycle.

Create //ui/display/manager target. Move the files in
src/ui/display/chromeos to src/ui/display/manager/chromeos since they
are all related to display management. Update includes and targets for
the moved files.

BUG=667344
TBR=sadrul,reveman
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Split //ui/display and create //ui/display/manager.

Split //ui/display so that general display code stays in //ui/display
and display management code is now in //ui/display/manager. This is
necessary as //ui/base has a dependency on //ui/display and code that is
being refactored out of ash has a dependency on //ui/base, forming a
cycle.

Create //ui/display/manager target. Move the files in
src/ui/display/chromeos to src/ui/display/manager/chromeos since they
are all related to display management. Update includes and targets for
the moved files.

BUG=667344
TBR=sadrul,reveman
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-01 20:51:22]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-12-01 20:53:16]

Description was changed from

==========
Split //ui/display and create //ui/display/manager.

Split //ui/display so that general display code stays in //ui/display
and display management code is now in //ui/display/manager. This is
necessary as //ui/base has a dependency on //ui/display and code that is
being refactored out of ash has a dependency on //ui/base, forming a
cycle.

Create //ui/display/manager target. Move the files in
src/ui/display/chromeos to src/ui/display/manager/chromeos since they
are all related to display management. Update includes and targets for
the moved files.

BUG=667344
TBR=sadrul,reveman
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Split //ui/display and create //ui/display/manager.

Split //ui/display so that general display code stays in //ui/display
and display management code is now in //ui/display/manager. This is
necessary as //ui/base has a dependency on //ui/display and code that is
being refactored out of ash has a dependency on //ui/base, forming a
cycle.

Create //ui/display/manager target. Move the files in
src/ui/display/chromeos to src/ui/display/manager/chromeos since they
are all related to display management. Update includes and targets for
the moved files.

BUG=667344
TBR=sadrul,reveman
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d
Cr-Commit-Position: refs/heads/master@{#435703}
==========

[commit-bot: I haz the power, 2016-12-01 20:53:17]

Patchset 4 (id:??) landed as
https://crrev.com/731f85f9fb45478c87a7e29cc7139c958cde174d
Cr-Commit-Position: refs/heads/master@{#435703}

[sadrul, 2016-12-02 00:53:24]

lgtm

[reveman, 2016-12-05 17:11:47]

components/exo lgtm