Roll third_party/inspector_protocol to 73028acaa3646789fd2a3bfd0d79eb2d91b696b3

Roll third_party/inspector_protocol to 73028acaa3646789fd2a3bfd0d79eb2d91b696b3

This roll includes:
  - Support config.protocol.options which defines which part of protocol definition should be generated. [1]
  - [inspector_protocol] Allow custom json parser. [2]
  - [inspector_protocol] Allow overriding specific config values. [3]
  - [inspector_protocol] Fix NoneType error when parsing config_values. [4]
  - [inspector_protocol] Support chromium code style. [5]
  - [inspector_protocol] Support features for content/ generator. [6]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported domains [7]

[1] https://codereview.chromium.org/2482993002
[2] https://codereview.chromium.org/2490733002
[3] https://codereview.chromium.org/2482093004
[4] https://codereview.chromium.org/2490823002
[5] https://codereview.chromium.org/2495353004
[6] https://codereview.chromium.org/2509573006
[7] https://codereview.chromium.org/2515343005

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/211a6a86370e476bf1dad21970a7f68c44e1ebf9
Cr-Commit-Position: refs/heads/master@{#41195}

[kozy, 2016-11-22 18:05:23]

Description was changed from

==========
Roll third_party/inspector_protocol to 73028acaa3646789fd2a3bfd0d79eb2d91b696b3

This roll includes:
  - Support config.protocol.options which defines which part of protocol
definition should be generated. [1]
  - [inspector_protocol] Allow custom json parser. [2]
  - [inspector_protocol] Allow overriding specific config values. [3]
  - [inspector_protocol] Fix NoneType error when parsing config_values. [4]
  - [inspector_protocol] Support chromium code style. [5]
  - [inspector_protocol] Support features for content/ generator. [6]

[1] https://codereview.chromium.org/2482993002
[2] https://codereview.chromium.org/2490733002
[3] https://codereview.chromium.org/2482093004
[4] https://codereview.chromium.org/2490823002
[5] https://codereview.chromium.org/2495353004
[6] https://codereview.chromium.org/2509573006

BUG=none
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to 73028acaa3646789fd2a3bfd0d79eb2d91b696b3

This roll includes:
  - Support config.protocol.options which defines which part of protocol
definition should be generated. [1]
  - [inspector_protocol] Allow custom json parser. [2]
  - [inspector_protocol] Allow overriding specific config values. [3]
  - [inspector_protocol] Fix NoneType error when parsing config_values. [4]
  - [inspector_protocol] Support chromium code style. [5]
  - [inspector_protocol] Support features for content/ generator. [6]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [7]

[1] https://codereview.chromium.org/2482993002
[2] https://codereview.chromium.org/2490733002
[3] https://codereview.chromium.org/2482093004
[4] https://codereview.chromium.org/2490823002
[5] https://codereview.chromium.org/2495353004
[6] https://codereview.chromium.org/2509573006
[7] https://codereview.chromium.org/2515343005

BUG=none
R=dgozman@chromium.org
==========

[kozy, 2016-11-22 18:06:33]

Dmitry, please take a look.

[dgozman, 2016-11-22 18:12:48]

lgtm

https://codereview.chromium.org/2523743003/diff/20001/src/inspector/v8-inspec...
File src/inspector/v8-inspector-impl.cc (right):

https://codereview.chromium.org/2523743003/diff/20001/src/inspector/v8-inspec...
src/inspector/v8-inspector-impl.cc:48: return
std::unique_ptr<V8InspectorImpl>(new V8InspectorImpl(isolate, client));
<V8Inspector>

https://codereview.chromium.org/2523743003/diff/20001/src/inspector/v8-inspec...
File src/inspector/v8-inspector-session-impl.cc (right):

https://codereview.chromium.org/2523743003/diff/20001/src/inspector/v8-inspec...
src/inspector/v8-inspector-session-impl.cc:72: m_runtimeAgent =
std::unique_ptr<V8RuntimeAgentImpl>(new V8RuntimeAgentImpl(
.reset

[kozy, 2016-11-22 18:24:31]

thanks! all done.

https://codereview.chromium.org/2523743003/diff/20001/src/inspector/v8-inspec...
File src/inspector/v8-inspector-impl.cc (right):

https://codereview.chromium.org/2523743003/diff/20001/src/inspector/v8-inspec...
src/inspector/v8-inspector-impl.cc:48: return
std::unique_ptr<V8InspectorImpl>(new V8InspectorImpl(isolate, client));
On 2016/11/22 18:12:48, dgozman wrote:
> <V8Inspector>

Done.

https://codereview.chromium.org/2523743003/diff/20001/src/inspector/v8-inspec...
File src/inspector/v8-inspector-session-impl.cc (right):

https://codereview.chromium.org/2523743003/diff/20001/src/inspector/v8-inspec...
src/inspector/v8-inspector-session-impl.cc:72: m_runtimeAgent =
std::unique_ptr<V8RuntimeAgentImpl>(new V8RuntimeAgentImpl(
On 2016/11/22 18:12:48, dgozman wrote:
> .reset

Done.

[kozy, 2016-11-22 18:24:39]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-22 18:24:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2523743003/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-11-22 18:24:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 18:57:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479839079222360,
"parent_rev": "01a97a3bae178977d69e2fab09034c27eadaab41", "commit_rev":
"2324792af8d04233437dcf63adb4209a770df589"}

[commit-bot: I haz the power, 2016-11-22 18:57:09]

Description was changed from

==========
Roll third_party/inspector_protocol to 73028acaa3646789fd2a3bfd0d79eb2d91b696b3

This roll includes:
  - Support config.protocol.options which defines which part of protocol
definition should be generated. [1]
  - [inspector_protocol] Allow custom json parser. [2]
  - [inspector_protocol] Allow overriding specific config values. [3]
  - [inspector_protocol] Fix NoneType error when parsing config_values. [4]
  - [inspector_protocol] Support chromium code style. [5]
  - [inspector_protocol] Support features for content/ generator. [6]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [7]

[1] https://codereview.chromium.org/2482993002
[2] https://codereview.chromium.org/2490733002
[3] https://codereview.chromium.org/2482093004
[4] https://codereview.chromium.org/2490823002
[5] https://codereview.chromium.org/2495353004
[6] https://codereview.chromium.org/2509573006
[7] https://codereview.chromium.org/2515343005

BUG=none
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to 73028acaa3646789fd2a3bfd0d79eb2d91b696b3

This roll includes:
  - Support config.protocol.options which defines which part of protocol
definition should be generated. [1]
  - [inspector_protocol] Allow custom json parser. [2]
  - [inspector_protocol] Allow overriding specific config values. [3]
  - [inspector_protocol] Fix NoneType error when parsing config_values. [4]
  - [inspector_protocol] Support chromium code style. [5]
  - [inspector_protocol] Support features for content/ generator. [6]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [7]

[1] https://codereview.chromium.org/2482993002
[2] https://codereview.chromium.org/2490733002
[3] https://codereview.chromium.org/2482093004
[4] https://codereview.chromium.org/2490823002
[5] https://codereview.chromium.org/2495353004
[6] https://codereview.chromium.org/2509573006
[7] https://codereview.chromium.org/2515343005

BUG=none
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-11-22 18:57:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-22 18:57:49]

Description was changed from

==========
Roll third_party/inspector_protocol to 73028acaa3646789fd2a3bfd0d79eb2d91b696b3

This roll includes:
  - Support config.protocol.options which defines which part of protocol
definition should be generated. [1]
  - [inspector_protocol] Allow custom json parser. [2]
  - [inspector_protocol] Allow overriding specific config values. [3]
  - [inspector_protocol] Fix NoneType error when parsing config_values. [4]
  - [inspector_protocol] Support chromium code style. [5]
  - [inspector_protocol] Support features for content/ generator. [6]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [7]

[1] https://codereview.chromium.org/2482993002
[2] https://codereview.chromium.org/2490733002
[3] https://codereview.chromium.org/2482093004
[4] https://codereview.chromium.org/2490823002
[5] https://codereview.chromium.org/2495353004
[6] https://codereview.chromium.org/2509573006
[7] https://codereview.chromium.org/2515343005

BUG=none
R=dgozman@chromium.org
==========

to

==========
Roll third_party/inspector_protocol to 73028acaa3646789fd2a3bfd0d79eb2d91b696b3

This roll includes:
  - Support config.protocol.options which defines which part of protocol
definition should be generated. [1]
  - [inspector_protocol] Allow custom json parser. [2]
  - [inspector_protocol] Allow overriding specific config values. [3]
  - [inspector_protocol] Fix NoneType error when parsing config_values. [4]
  - [inspector_protocol] Support chromium code style. [5]
  - [inspector_protocol] Support features for content/ generator. [6]
  - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported
domains [7]

[1] https://codereview.chromium.org/2482993002
[2] https://codereview.chromium.org/2490733002
[3] https://codereview.chromium.org/2482093004
[4] https://codereview.chromium.org/2490823002
[5] https://codereview.chromium.org/2495353004
[6] https://codereview.chromium.org/2509573006
[7] https://codereview.chromium.org/2515343005

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/211a6a86370e476bf1dad21970a7f68c44e1ebf9
Cr-Commit-Position: refs/heads/master@{#41195}
==========

[commit-bot: I haz the power, 2016-11-22 18:57:54]

Patchset 3 (id:??) landed as
https://crrev.com/211a6a86370e476bf1dad21970a7f68c44e1ebf9
Cr-Commit-Position: refs/heads/master@{#41195}