Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2490733002: [inspector_protocol] Allow custom json parser. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
kozy
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] Allow custom json parser. Drive-by: removed platform include, as it's not necessary anymore. BUG=chromium:635953 R=kozyatinskiy@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocolb27ff7bff4770cf15b1187c10636222df1340ae2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M CodeGenerator.py View 1 chunk +0 lines, -1 line 0 comments Download
M lib/Array_h.template View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/DispatcherBase_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
M lib/Forward_h.template View 1 chunk +0 lines, -1 line 0 comments Download
M lib/Object_cpp.template View 2 chunks +5 lines, -4 lines 0 comments Download
M lib/Parser_cpp.template View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/Parser_h.template View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/Values_h.template View 8 chunks +11 lines, -11 lines 0 comments Download
M templates/TypeBuilder_cpp.template View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dgozman
PTAL. Copied from https://codereview.chromium.org/2490473004/.
4 years, 1 month ago (2016-11-08 22:01:12 UTC) #2
kozy
lgtm
4 years, 1 month ago (2016-11-08 22:01:52 UTC) #3
dgozman
4 years, 1 month ago (2016-11-08 22:02:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b27ff7bff4770cf15b1187c10636222df1340ae2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698