Issue 2482993002: Support config.protocol.options which defines which part of protocol definition should be generated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2482993002: Support config.protocol.options which defines which part of protocol definition should be generated. (Closed)

Created:
4 years, 1 month ago by dgozman

Modified:
4 years, 1 month ago

Reviewers:
kozy

CC:
chromium-reviews, devtools-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
inspector_protocol

Visibility:
Public.

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -19 lines)			Patch
M	CodeGenerator.py	View	3 chunks	+51 lines, -5 lines	0 comments	Download
M	sample_config.json	View	1 chunk	+17 lines, -1 line	0 comments	Download
M	templates/TypeBuilder_cpp.template	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	templates/TypeBuilder_h.template	View	5 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

dgozman

Take a look please. Copied over from crrev.com/2475663004.

4 years, 1 month ago (2016-11-07 19:29:51 UTC) #2

dgozman

4 years, 1 month ago (2016-11-07 19:37:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3c6f5ff8ab6653b47cf226233d488701a527d761 (presubmit successful).