Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2523583005: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 This roll includes: - [inspector_protocol] Introduce protocol::Serializable [1] [1] https://codereview.chromium.org/2526603002 BUG=chromium:350797 R=dgozman@chromium.org Committed: https://crrev.com/eb3551d0a34dcc64abe871b79e9da1b19516a428 Cr-Commit-Position: refs/heads/master@{#41197}

Patch Set 1 #

Patch Set 2 : updated README.v8 #

Patch Set 3 : added default implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -128 lines) Patch
M include/v8-inspector.h View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M src/inspector/injected-script.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/inspector/v8-inspector-session-impl.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/inspector/v8-inspector-session-impl.cc View 1 2 chunks +35 lines, -6 lines 0 comments Download
M third_party/inspector_protocol/CodeGenerator.py View 1 2 chunks +15 lines, -0 lines 0 comments Download
M third_party/inspector_protocol/README.v8 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/lib/Array_h.template View 1 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/inspector_protocol/lib/DispatcherBase_cpp.template View 1 3 chunks +91 lines, -25 lines 0 comments Download
M third_party/inspector_protocol/lib/DispatcherBase_h.template View 1 1 chunk +40 lines, -0 lines 0 comments Download
M third_party/inspector_protocol/lib/FrontendChannel_h.template View 1 chunk +8 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/Maybe_h.template View 1 chunk +1 line, -1 line 0 comments Download
M third_party/inspector_protocol/lib/Object_cpp.template View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/Object_h.template View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/ValueConversions_h.template View 1 14 chunks +23 lines, -23 lines 0 comments Download
M third_party/inspector_protocol/lib/Values_cpp.template View 1 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/inspector_protocol/lib/Values_h.template View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/inspector_protocol/templates/Imported_h.template View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 1 10 chunks +33 lines, -27 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_h.template View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
kozy
v8 part of serializable. Dmitry, please take a look.
4 years, 1 month ago (2016-11-22 18:43:45 UTC) #1
dgozman
Please update the revision number and readme file. lgtm
4 years, 1 month ago (2016-11-22 23:08:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523583005/80001
4 years, 1 month ago (2016-11-22 23:57:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523583005/100001
4 years, 1 month ago (2016-11-23 00:14:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2523583005/100001
4 years, 1 month ago (2016-11-23 00:43:11 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 1 month ago (2016-11-23 00:45:36 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 00:46:06 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eb3551d0a34dcc64abe871b79e9da1b19516a428
Cr-Commit-Position: refs/heads/master@{#41197}

Powered by Google App Engine
This is Rietveld 408576698