Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2482093004: [inspector_protocol] Allow overriding specific config values. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
kozy
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] Allow overriding specific config values. This is intended to be used with dynamic paths only known at build time. BUG=none R=kozyatinskiy@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocol545a568e714053f8288543a97352f9c4f75e8417

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M CodeGenerator.py View 1 3 chunks +6 lines, -0 lines 0 comments Download
M inspector_protocol.gni View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Could you please take a look?
4 years, 1 month ago (2016-11-08 22:44:24 UTC) #2
kozy
lgtm https://codereview.chromium.org/2482093004/diff/1/CodeGenerator.py File CodeGenerator.py (right): https://codereview.chromium.org/2482093004/diff/1/CodeGenerator.py#newcode296 CodeGenerator.py:296: "create_type": "wrapUnique(new protocol::Array<%s>())" % type["raw_type"], Hm...
4 years, 1 month ago (2016-11-08 23:13:43 UTC) #3
dgozman
https://codereview.chromium.org/2482093004/diff/1/CodeGenerator.py File CodeGenerator.py (right): https://codereview.chromium.org/2482093004/diff/1/CodeGenerator.py#newcode296 CodeGenerator.py:296: "create_type": "wrapUnique(new protocol::Array<%s>())" % type["raw_type"], On 2016/11/08 23:13:43, kozyatinskiy ...
4 years, 1 month ago (2016-11-08 23:19:36 UTC) #4
dgozman
4 years, 1 month ago (2016-11-08 23:19:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
545a568e714053f8288543a97352f9c4f75e8417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698