Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2495353004: [inspector_protocol] Support chromium code style. (Closed)

Created:
4 years, 1 month ago by dgozman
Modified:
4 years, 1 month ago
Reviewers:
caseq
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] Support chromium code style. As opposite to blink style. BUG=chromium:664683 R=caseq@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocolae736f1e3ac306688c2d7feaa4f43dbdded01ed3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -62 lines) Patch
M CodeGenerator.py View 10 chunks +72 lines, -34 lines 0 comments Download
M lib/Collections_h.template View 1 chunk +1 line, -1 line 0 comments Download
M lib/ErrorSupport_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
M lib/Protocol_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
M templates/Imported_h.template View 1 chunk +6 lines, -2 lines 0 comments Download
M templates/TypeBuilder_cpp.template View 4 chunks +5 lines, -5 lines 0 comments Download
M templates/TypeBuilder_h.template View 7 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dgozman
Take a look please. Extracted from https://codereview.chromium.org/2493063005/.
4 years, 1 month ago (2016-11-15 01:33:03 UTC) #3
caseq
rs lgtm
4 years, 1 month ago (2016-11-15 01:36:52 UTC) #4
dgozman
4 years, 1 month ago (2016-11-15 17:07:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ae736f1e3ac306688c2d7feaa4f43dbdded01ed3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698