[inspector_protocol] Support features for content/ generator.

[inspector_protocol] Support features for content/ generator.

This includes:
- sendRawMessage;
- fall through from async methods;
- optional handling (returning FallThrough for NotFound error);
- Response::InvalidParams().

BUG=chromium:664683
R=caseq@chromium.org

Committed: https://chromium.googlesource.com/deps/inspector_protocol73028acaa3646789fd2a3bfd0d79eb2d91b696b3

[dgozman, 2016-11-17 21:56:33]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org

[dgozman, 2016-11-17 21:56:33]

Could you please take a look?
Extracted from https://codereview.chromium.org/2500093002.

[caseq, 2016-11-17 22:23:47]

lgtm

https://codereview.chromium.org/2509573006/diff/1/lib/DispatcherBase_cpp.temp...
File lib/DispatcherBase_cpp.template (right):

https://codereview.chromium.org/2509573006/diff/1/lib/DispatcherBase_cpp.temp...
lib/DispatcherBase_cpp.template:117: if (callbackId == m_lastCallbackId)
nit: DCHECK if not so?

[dgozman, 2016-11-17 22:26:13]

https://codereview.chromium.org/2509573006/diff/1/lib/DispatcherBase_cpp.temp...
File lib/DispatcherBase_cpp.template (right):

https://codereview.chromium.org/2509573006/diff/1/lib/DispatcherBase_cpp.temp...
lib/DispatcherBase_cpp.template:117: if (callbackId == m_lastCallbackId)
On 2016/11/17 22:23:46, caseq wrote:
> nit: DCHECK if not so?

This depends on client usage, so I'd prefer to not DCHECK but instead be on a
safe side.

[caseq, 2016-11-17 22:47:06]

On 2016/11/17 at 22:26:13, dgozman wrote:
>
https://codereview.chromium.org/2509573006/diff/1/lib/DispatcherBase_cpp.temp...
> File lib/DispatcherBase_cpp.template (right):
> 
>
https://codereview.chromium.org/2509573006/diff/1/lib/DispatcherBase_cpp.temp...
> lib/DispatcherBase_cpp.template:117: if (callbackId == m_lastCallbackId)
> On 2016/11/17 22:23:46, caseq wrote:
> > nit: DCHECK if not so?
> 
> This depends on client usage, so I'd prefer to not DCHECK but instead be on a
safe side.

That's what DCHECK()'s are for -- you're quietly discarding client's request
here and do something that goes across client's expectations based on method
name. "Safe side" is knowing early when such things happen.

[dgozman, 2016-11-18 23:18:57]

On 2016/11/17 22:47:06, caseq wrote:
> On 2016/11/17 at 22:26:13, dgozman wrote:
> >
>
https://codereview.chromium.org/2509573006/diff/1/lib/DispatcherBase_cpp.temp...
> > File lib/DispatcherBase_cpp.template (right):
> > 
> >
>
https://codereview.chromium.org/2509573006/diff/1/lib/DispatcherBase_cpp.temp...
> > lib/DispatcherBase_cpp.template:117: if (callbackId == m_lastCallbackId)
> > On 2016/11/17 22:23:46, caseq wrote:
> > > nit: DCHECK if not so?
> > 
> > This depends on client usage, so I'd prefer to not DCHECK but instead be on
a
> safe side.
> 
> That's what DCHECK()'s are for -- you're quietly discarding client's request
> here and do something that goes across client's expectations based on method
> name. "Safe side" is knowing early when such things happen.

Switched to DCHECK.

[dgozman, 2016-11-18 23:19:13]

Description was changed from

==========
[inspector_protocol] Support features for content/ generator.

This includes:
- sendRawMessage;
- fall through from async methods;
- optional handling (returning FallThrough for NotFound error);
- Response::InvalidParams().

BUG=chromium:664683
==========

to

==========
[inspector_protocol] Support features for content/ generator.

This includes:
- sendRawMessage;
- fall through from async methods;
- optional handling (returning FallThrough for NotFound error);
- Response::InvalidParams().

BUG=chromium:664683
R=caseq@chromium.org

Committed:
https://chromium.googlesource.com/deps/inspector_protocol73028acaa3646789fd2a...
==========

[dgozman, 2016-11-18 23:19:14]

Committed patchset #2 (id:20001) manually as
73028acaa3646789fd2a3bfd0d79eb2d91b696b3 (presubmit successful).