Split GrResource into GrCacheable/GrGpuObject

Split GrResource into GrCacheable/GrGpuObject

Before this change, an object needed to inherit from GrResource (and
thus be a GPU object) in order to live in the GrResourceCache. That
was a problem for caching items that weren't GPU objects themselves,
but owned GPU objects.

This change splits GrResource into two classes:

  1. GrCacheable: The base class for objects that can live in the
     GrResourceCache.

  2. GrGpuObject, which inherits from GrCacheable: The base class for
     objects that get tracked by GrGpu.

This change is purely a refactor; there is no change in functionality.

Change-Id: I3e8daeb1f123041f414aa306c1366e959ae9e39e

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14553

[Chris Dalton, 2014-04-25 20:59:01]

All the patchsets were finding the right value to use for '--similarity', to get
the correct rename detection.

Lots of changes, but it's mostly robotic and simple

[bsalomon, 2014-04-28 14:23:47]

https://codereview.chromium.org/251013002/diff/60001/include/gpu/GrGpuObject.h
File include/gpu/GrGpuObject.h (right):

https://codereview.chromium.org/251013002/diff/60001/include/gpu/GrGpuObject....
include/gpu/GrGpuObject.h:75: virtual bool isValidOnGpu() const SK_OVERRIDE {
return this->isValid(); }
The CL mostly 1gtm. My only concern is that I'm finding the isValid() and
isValidOnGpu() distinction a bit confusing. I understand the difference but it
seems a bit difficult to grok for some reason. I'm thinking isValid() needs a
clearer name: isAllocated(), isResident(), isReleased() [reverses the sense of
it], ...

[Chris Dalton, 2014-04-28 16:19:23]

https://codereview.chromium.org/251013002/diff/60001/include/gpu/GrGpuObject.h
File include/gpu/GrGpuObject.h (right):

https://codereview.chromium.org/251013002/diff/60001/include/gpu/GrGpuObject....
include/gpu/GrGpuObject.h:75: virtual bool isValidOnGpu() const SK_OVERRIDE {
return this->isValid(); }
On 2014/04/28 14:23:47, bsalomon wrote:
> The CL mostly 1gtm. My only concern is that I'm finding the isValid() and
> isValidOnGpu() distinction a bit confusing. I understand the difference but it
> seems a bit difficult to grok for some reason. I'm thinking isValid() needs a
> clearer name: isAllocated(), isResident(), isReleased() [reverses the sense of
> it], ...
> 

Done.

[bsalomon, 2014-04-28 18:14:48]

On 2014/04/28 16:19:23, Chris Dalton wrote:
> https://codereview.chromium.org/251013002/diff/60001/include/gpu/GrGpuObject.h
> File include/gpu/GrGpuObject.h (right):
> 
>
https://codereview.chromium.org/251013002/diff/60001/include/gpu/GrGpuObject....
> include/gpu/GrGpuObject.h:75: virtual bool isValidOnGpu() const SK_OVERRIDE {
> return this->isValid(); }
> On 2014/04/28 14:23:47, bsalomon wrote:
> > The CL mostly 1gtm. My only concern is that I'm finding the isValid() and
> > isValidOnGpu() distinction a bit confusing. I understand the difference but
it
> > seems a bit difficult to grok for some reason. I'm thinking isValid() needs
a
> > clearer name: isAllocated(), isResident(), isReleased() [reverses the sense
of
> > it], ...
> > 
> 
> Done.

lgtm

[Chris Dalton, 2014-05-02 18:31:49]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2014-05-02 18:32:03]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/251013002/80001

[commit-bot: I haz the power, 2014-05-02 18:37:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 18:37:34]

Retried try job too often on Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot for
step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests,
BuildTools
http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?bu...

[Chris Dalton, 2014-05-02 21:31:21]

The CQ bit was checked by cdalton@nvidia.com

[commit-bot: I haz the power, 2014-05-02 21:31:35]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/251013002/100001

[commit-bot: I haz the power, 2014-05-02 21:38:43]

Change committed as 14553