CC Animation: Make cc/animation an independent GN component.

CC Animation: Make cc/animation an independent GN component.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

(was: linux_precise_blink_rel)

Committed: https://crrev.com/3dd2089f56ece15f219edbfb83132133dc7c63d4
Cr-Commit-Position: refs/heads/master@{#433806}

[loyso (OOO), 2016-11-17 06:38:18]

Description was changed from

==========
CC Animation: Make cc/animation an independent GN target.

BUG=575043
==========

to

==========
CC Animation: Make cc/animation an independent GN target.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-11-17 06:39:28]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 06:40:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[loyso (OOO), 2016-11-17 06:43:19]

Description was changed from

==========
CC Animation: Make cc/animation an independent GN target.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Make cc/animation an independent GN target.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-11-17 06:43:20]

loyso@chromium.org changed reviewers:
+ aelias@chromium.org, khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-11-17 06:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 06:43:53]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

[loyso (OOO), 2016-11-17 06:45:29]

loyso@chromium.org changed reviewers:
+ sky@chromium.org

[loyso (OOO), 2016-11-17 06:49:37]

loyso@chromium.org changed reviewers:
+ avi@chromium.org

[loyso (OOO), 2016-11-17 06:49:59]

loyso@chromium.org changed reviewers:
+ boliu@chromium.org

[loyso (OOO), 2016-11-17 07:00:43]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 07:01:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[loyso (OOO), 2016-11-17 07:03:11]

Please, review:
Avi@ - content/
Khushal@ - blimp/
sky@ - ui/services
aelias@ - cc/ 
boliu@ - android_webview/.

[commit-bot: I haz the power, 2016-11-17 07:05:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 07:05:27]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

[Khushal, 2016-11-17 07:31:35]

lgtm

[boliu, 2016-11-17 14:50:43]

https://codereview.chromium.org/2506093003/diff/20001/android_webview/BUILD.gn
File android_webview/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/20001/android_webview/BUILD.g...
android_webview/BUILD.gn:476: "//cc/animation",
this is actually not correct I believe

a target should only need to declare its *direct* dependencies. afaict I don't
see any android_webview code including things from cc/animation?

If cc/animation is a dependency of cc/surfaces, then it should be declared a
dependency of cc/surfaces and that will be transitively pulled in here

[aelias_OOO_until_Jul13, 2016-11-17 20:08:22]

https://codereview.chromium.org/2506093003/diff/20001/cc/animation/BUILD.gn
File cc/animation/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/20001/cc/animation/BUILD.gn#n...
cc/animation/BUILD.gn:51: if (!is_debug && (is_win || is_android)) {
Please move these lines of duplicate logic into a .gni file and share them
across cc/BUILD.gn, cc/surfaces/BUILD.gn and this.

[loyso (OOO), 2016-11-17 23:45:09]

https://codereview.chromium.org/2506093003/diff/20001/android_webview/BUILD.gn
File android_webview/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/20001/android_webview/BUILD.g...
android_webview/BUILD.gn:476: "//cc/animation",
On 2016/11/17 14:50:43, boliu wrote:
> this is actually not correct I believe
> 
> a target should only need to declare its *direct* dependencies. afaict I don't
> see any android_webview code including things from cc/animation?
> 
> If cc/animation is a dependency of cc/surfaces, then it should be declared a
> dependency of cc/surfaces and that will be transitively pulled in here

Done.

https://codereview.chromium.org/2506093003/diff/20001/cc/animation/BUILD.gn
File cc/animation/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/20001/cc/animation/BUILD.gn#n...
cc/animation/BUILD.gn:51: if (!is_debug && (is_win || is_android)) {
On 2016/11/17 20:08:22, aelias wrote:
> Please move these lines of duplicate logic into a .gni file and share them
> across cc/BUILD.gn, cc/surfaces/BUILD.gn and this.
cc/surfaces logic is slightly different. it's max for android only, not
including win. Is that intentional?

[aelias_OOO_until_Jul13, 2016-11-18 00:13:34]

https://codereview.chromium.org/2506093003/diff/20001/cc/animation/BUILD.gn
File cc/animation/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/20001/cc/animation/BUILD.gn#n...
cc/animation/BUILD.gn:51: if (!is_debug && (is_win || is_android)) {
On 2016/11/17 at 23:45:09, loyso wrote:
> On 2016/11/17 20:08:22, aelias wrote:
> > Please move these lines of duplicate logic into a .gni file and share them
> > across cc/BUILD.gn, cc/surfaces/BUILD.gn and this.
> cc/surfaces logic is slightly different. it's max for android only, not
including win. Is that intentional?

I think it's almost certainly not intentional and avoiding this kind of
accidental divergence is why I'd like to avoid duplicating the lines.  Looks
like scottmg@, a Windows engineer, added this in the .gyp file in
https://codereview.chromium.org/187043002, and then when the root CC gn file was
created, that turned into an is_win.

[loyso (OOO), 2016-11-18 01:33:01]

Description was changed from

==========
CC Animation: Make cc/animation an independent GN target.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Make cc/animation an independent GN component.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[loyso (OOO), 2016-11-18 02:05:42]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 02:07:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 02:19:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:19:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[loyso (OOO), 2016-11-18 02:36:53]

https://codereview.chromium.org/2506093003/diff/20001/cc/animation/BUILD.gn
File cc/animation/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/20001/cc/animation/BUILD.gn#n...
cc/animation/BUILD.gn:51: if (!is_debug && (is_win || is_android)) {
On 2016/11/18 00:13:33, aelias wrote:
> On 2016/11/17 at 23:45:09, loyso wrote:
> > On 2016/11/17 20:08:22, aelias wrote:
> > > Please move these lines of duplicate logic into a .gni file and share them
> > > across cc/BUILD.gn, cc/surfaces/BUILD.gn and this.
> > cc/surfaces logic is slightly different. it's max for android only, not
> including win. Is that intentional?
> 
> I think it's almost certainly not intentional and avoiding this kind of
> accidental divergence is why I'd like to avoid duplicating the lines.  Looks
> like scottmg@, a Windows engineer, added this in the .gyp file in
> https://codereview.chromium.org/187043002, and then when the root CC gn file
was
> created, that turned into an is_win.

Done. We could use template("cc_component") approach in GN but this is beyond
the scope of this CL, imho.

[aelias_OOO_until_Jul13, 2016-11-18 02:57:18]

lgtm

[loyso (OOO), 2016-11-18 04:15:11]

PTAL!
Avi@ - content/
sky@ - ui/, services/ui/

[loyso (OOO), 2016-11-18 04:15:24]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 04:16:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 04:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 04:22:13]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[loyso (OOO), 2016-11-18 05:08:27]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 05:09:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 05:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 05:14:16]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2016-11-18 16:36:49]

On 2016/11/18 04:15:11, loyso wrote:
> PTAL!
> Avi@ - content/
> sky@ - ui/, services/ui/

As was earlier mentioned I don't see any includes in ui or services/ui of
cc/animation. Why doe the BUILD.gn files need to be changed?

[Avi (use Gerrit), 2016-11-18 17:09:37]

On 2016/11/18 16:36:49, sky wrote:
> On 2016/11/18 04:15:11, loyso wrote:
> > PTAL!
> > Avi@ - content/
> > sky@ - ui/, services/ui/
> 
> As was earlier mentioned I don't see any includes in ui or services/ui of
> cc/animation. Why doe the BUILD.gn files need to be changed?

Same here. I see that content/browser and content/renderer have instances of
"cc/animation" but content/common and content/test don't. Why do they need
these?

[Khushal, 2016-11-18 21:20:24]

Took another look and looks like some targets in blimp also don't need this dep.

https://codereview.chromium.org/2506093003/diff/100001/blimp/client/app/BUILD.gn
File blimp/client/app/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/100001/blimp/client/app/BUILD...
blimp/client/app/BUILD.gn:34: "//cc/animation",
Not needed.

https://codereview.chromium.org/2506093003/diff/100001/blimp/client/core/rend...
File blimp/client/core/render_widget/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/100001/blimp/client/core/rend...
blimp/client/core/render_widget/BUILD.gn:79: "//cc/animation",
Not needed.

https://codereview.chromium.org/2506093003/diff/100001/blimp/engine/BUILD.gn
File blimp/engine/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/100001/blimp/engine/BUILD.gn#...
blimp/engine/BUILD.gn:215: "//cc/animation",
Not needed.

[loyso (OOO), 2016-11-21 06:12:20]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 06:12:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 06:13:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 06:13:39]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[loyso (OOO), 2016-11-21 06:42:51]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 06:43:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 06:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 06:43:57]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[loyso (OOO), 2016-11-21 06:44:25]

loyso@chromium.org changed reviewers:
+ jbroman@chromium.org

[loyso (OOO), 2016-11-21 06:45:11]

loyso@chromium.org changed reviewers:
+ enne@chromium.org

[loyso (OOO), 2016-11-21 06:47:54]

PTAL:
Avi@ - content/
Khushal@ - blimp/
sky@ - ui/
enne@ - cc/ GN templates
jbroman@ - WebKit platform.

https://codereview.chromium.org/2506093003/diff/100001/blimp/client/app/BUILD.gn
File blimp/client/app/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/100001/blimp/client/app/BUILD...
blimp/client/app/BUILD.gn:34: "//cc/animation",
On 2016/11/18 21:20:23, Khushal wrote:
> Not needed.

Done.

https://codereview.chromium.org/2506093003/diff/100001/blimp/client/core/rend...
File blimp/client/core/render_widget/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/100001/blimp/client/core/rend...
blimp/client/core/render_widget/BUILD.gn:79: "//cc/animation",
On 2016/11/18 21:20:23, Khushal wrote:
> Not needed.

Done.

https://codereview.chromium.org/2506093003/diff/100001/blimp/engine/BUILD.gn
File blimp/engine/BUILD.gn (right):

https://codereview.chromium.org/2506093003/diff/100001/blimp/engine/BUILD.gn#...
blimp/engine/BUILD.gn:215: "//cc/animation",
On 2016/11/18 21:20:23, Khushal wrote:
> Not needed.

Done.

[loyso (OOO), 2016-11-21 06:49:45]

On 2016/11/18 02:57:18, aelias_OOO_until_Dec1 wrote:
> lgtm
It didn't work so I have to go with GN templates.

[Khushal, 2016-11-21 08:25:28]

blimp lgtm again.

[Avi (use Gerrit), 2016-11-21 14:46:53]

The two content build files lgtm.

[jbroman, 2016-11-21 15:32:57]

platform lgtm

[sky, 2016-11-21 16:58:13]

LGTM

[enne (OOO), 2016-11-21 18:09:41]

lgtm

[loyso (OOO), 2016-11-22 03:31:04]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 03:31:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 03:33:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 03:33:17]

Dry run: Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[loyso (OOO), 2016-11-22 03:41:43]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2016-11-22 03:41:44]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2506093003/#ps150001
(title: "Remove redundant cc test_support dependencies.")

[commit-bot: I haz the power, 2016-11-22 03:42:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 03:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 03:43:49]

Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

[loyso (OOO), 2016-11-22 03:54:27]

Description was changed from

==========
CC Animation: Make cc/animation an independent GN component.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
CC Animation: Make cc/animation an independent GN component.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

(was: linux_precise_blink_rel)
==========

[loyso (OOO), 2016-11-22 03:54:40]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 03:54:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Khushal, 2016-11-22 04:52:05]

On 2016/11/22 03:43:49, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)

Use master.tryserver.blink:linux_trusty_blink_rel instead. Presubmit has
changed, but this patch still has the old bot link.

[commit-bot: I haz the power, 2016-11-22 05:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 05:03:56]

Dry run: This issue passed the CQ dry run.

[loyso (OOO), 2016-11-22 05:14:02]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-11-22 05:14:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 05:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 05:17:43]

Failed to apply patch for cc/animation/animation_curve.h:
While running git apply --index -p1;
  error: patch failed: cc/animation/animation_curve.h:26
  error: cc/animation/animation_curve.h: patch does not apply

Patch:       cc/animation/animation_curve.h
Index: cc/animation/animation_curve.h
diff --git a/cc/animation/animation_curve.h b/cc/animation/animation_curve.h
index
c52ff180039af8609514d0877615430e927c209f..f6721314108b32eafb3974035d164560f557b75a
100644
--- a/cc/animation/animation_curve.h
+++ b/cc/animation/animation_curve.h
@@ -8,7 +8,7 @@
 #include <memory>
 
 #include "base/time/time.h"
-#include "cc/base/cc_export.h"
+#include "cc/animation/animation_export.h"
 #include "cc/output/filter_operations.h"
 #include "ui/gfx/transform.h"
 
@@ -26,7 +26,7 @@ class TransformAnimationCurve;
 class TransformOperations;
 
 // An animation curve is a function that returns a value given a time.
-class CC_EXPORT AnimationCurve {
+class CC_ANIMATION_EXPORT AnimationCurve {
  public:
   enum CurveType { COLOR, FLOAT, TRANSFORM, FILTER, SCROLL_OFFSET };
 
@@ -45,7 +45,7 @@ class CC_EXPORT AnimationCurve {
   ScrollOffsetAnimationCurve* ToScrollOffsetAnimationCurve();
 };
 
-class CC_EXPORT ColorAnimationCurve : public AnimationCurve {
+class CC_ANIMATION_EXPORT ColorAnimationCurve : public AnimationCurve {
  public:
   ~ColorAnimationCurve() override {}
 
@@ -55,7 +55,7 @@ class CC_EXPORT ColorAnimationCurve : public AnimationCurve {
   CurveType Type() const override;
 };
 
-class CC_EXPORT FloatAnimationCurve : public AnimationCurve {
+class CC_ANIMATION_EXPORT FloatAnimationCurve : public AnimationCurve {
  public:
   ~FloatAnimationCurve() override {}
 
@@ -65,7 +65,7 @@ class CC_EXPORT FloatAnimationCurve : public AnimationCurve {
   CurveType Type() const override;
 };
 
-class CC_EXPORT TransformAnimationCurve : public AnimationCurve {
+class CC_ANIMATION_EXPORT TransformAnimationCurve : public AnimationCurve {
  public:
   ~TransformAnimationCurve() override {}
 
@@ -99,7 +99,7 @@ class CC_EXPORT TransformAnimationCurve : public
AnimationCurve {
   CurveType Type() const override;
 };
 
-class CC_EXPORT FilterAnimationCurve : public AnimationCurve {
+class CC_ANIMATION_EXPORT FilterAnimationCurve : public AnimationCurve {
  public:
   ~FilterAnimationCurve() override {}

[loyso (OOO), 2016-11-22 05:27:38]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2016-11-22 05:27:38]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
sky@chromium.org, jbroman@chromium.org, avi@chromium.org, enne@chromium.org,
khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2506093003/#ps170001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-11-22 05:27:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 07:11:05]

CQ is committing da patch.

Bot data: {"patchset_id": 170001, "attempt_start_ts": 1479792458092410,
"parent_rev": "aeb06dc0c50ab90c274fd47bb63ed805b14cf149", "commit_rev":
"4f4b9df9bff2927f6864ebb3d4ac41512a7aac2e"}

[commit-bot: I haz the power, 2016-11-22 07:11:29]

Description was changed from

==========
CC Animation: Make cc/animation an independent GN component.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

(was: linux_precise_blink_rel)
==========

to

==========
CC Animation: Make cc/animation an independent GN component.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

(was: linux_precise_blink_rel)
==========

[commit-bot: I haz the power, 2016-11-22 07:11:31]

Committed patchset #10 (id:170001)

[commit-bot: I haz the power, 2016-11-22 07:13:03]

Description was changed from

==========
CC Animation: Make cc/animation an independent GN component.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

(was: linux_precise_blink_rel)
==========

to

==========
CC Animation: Make cc/animation an independent GN component.

BUG=575043
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

(was: linux_precise_blink_rel)

Committed: https://crrev.com/3dd2089f56ece15f219edbfb83132133dc7c63d4
Cr-Commit-Position: refs/heads/master@{#433806}
==========

[commit-bot: I haz the power, 2016-11-22 07:13:05]

Patchset 10 (id:??) landed as
https://crrev.com/3dd2089f56ece15f219edbfb83132133dc7c63d4
Cr-Commit-Position: refs/heads/master@{#433806}