Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 187043002: Turn optimize up to 11 for cc (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Turn optimize up to 11 for cc To the MAXXXXXXX! We can do more 'max' targets now that we're on vs2013 with the amd64_x86 toolchain. Test if this helps the regression that appears to have been caused by the ordering of .objs on the link line a while back. (This cannot be merged to before 35.) R=jamesr@chromium.org BUG=331225 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M cc/cc.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
6 years, 9 months ago (2014-03-04 21:32:51 UTC) #1
jamesr
lgtm why won't this work with 2010? do you think it'll blow up the linker?
6 years, 9 months ago (2014-03-04 21:40:16 UTC) #2
scottmg
On 2014/03/04 21:40:16, jamesr wrote: > lgtm > > why won't this work with 2010? ...
6 years, 9 months ago (2014-03-04 21:44:38 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 9 months ago (2014-03-04 21:44:41 UTC) #4
jamesr
On 2014/03/04 21:44:38, scottmg wrote: > On 2014/03/04 21:40:16, jamesr wrote: > > lgtm > ...
6 years, 9 months ago (2014-03-04 21:45:38 UTC) #5
scottmg
On 2014/03/04 21:45:38, jamesr wrote: > On 2014/03/04 21:44:38, scottmg wrote: > > On 2014/03/04 ...
6 years, 9 months ago (2014-03-04 21:46:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/187043002/1
6 years, 9 months ago (2014-03-04 21:46:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/187043002/1
6 years, 9 months ago (2014-03-05 01:00:06 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 09:53:30 UTC) #9
Message was sent while issue was closed.
Change committed as 254987

Powered by Google App Engine
This is Rietveld 408576698