CC Animation: Make cc/animation an independent GN component.

cc/animation/BUILD.gn

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+component("animation") {
+  output_name = "cc_animation"
+  sources = [
+    "animation.cc",
+    "animation.h",
+    "animation_curve.cc",
+    "animation_curve.h",
+    "animation_delegate.h",
+    "animation_events.cc",
+    "animation_events.h",
+    "animation_export.h",
+    "animation_host.cc",
+    "animation_host.h",
+    "animation_id_provider.cc",
+    "animation_id_provider.h",
+    "animation_player.cc",
+    "animation_player.h",
+    "animation_timeline.cc",
+    "animation_timeline.h",
+    "element_animations.cc",
+    "element_animations.h",
+    "keyframed_animation_curve.cc",
+    "keyframed_animation_curve.h",
+    "scroll_offset_animation_curve.cc",
+    "scroll_offset_animation_curve.h",
+    "scroll_offset_animations.cc",
+    "scroll_offset_animations.h",
+    "scroll_offset_animations_impl.cc",
+    "scroll_offset_animations_impl.h",
+    "timing_function.cc",
+    "timing_function.h",
+    "transform_operation.cc",
+    "transform_operation.h",
+    "transform_operations.cc",
+    "transform_operations.h",
+  ]
+
+  defines = [ "CC_ANIMATION_IMPLEMENTATION=1" ]
+
+  deps = [
+    "//base",
+    "//cc",
+    "//ui/gfx",
+    "//ui/gfx/geometry",
+  ]
+
+  if (!is_debug && (is_win || is_android)) {

[aelias_OOO_until_Jul13, 2016/11/17 20:08:22]

Please move these lines of duplicate logic into a .gni file and share them
across cc/BUILD.gn, cc/surfaces/BUILD.gn and this.

[loyso (OOO), 2016/11/17 23:45:09]

cc/surfaces logic is slightly different. it's max for android only, not
including win. Is that intentional?

[aelias_OOO_until_Jul13, 2016/11/18 00:13:33]

I think it's almost certainly not intentional and avoiding this kind of
accidental divergence is why I'd like to avoid duplicating the lines.  Looks
like scottmg@, a Windows engineer, added this in the .gyp file in
https://codereview.chromium.org/187043002, and then when the root CC gn file was
created, that turned into an is_win.

[loyso (OOO), 2016/11/18 02:36:53]

Done. We could use template("cc_component") approach in GN but this is beyond
the scope of this CL, imho.

+    configs -= [ "//build/config/compiler:default_optimization" ]
+    configs += [ "//build/config/compiler:optimize_max" ]
+  }
+}