GN: Always check for bad items.

GN: Always check for bad items.

Previous checking for most types of errors in the GN introspection commands was
disabled. The reason was that it can be convenient to ask for certain types
of information which GN can provide even if there are errors elsewhere in the
build.

Unfortunately, not checking for bad items can leave the build graph in an
inconsistent state. In the case of missing dependencies, a target will never
be resolved which means most of the information the tools will return about it
will be missing or incorrect which is very surprising and confusing.

As a result, it seems best to always ensure things are in a consistent state
before running any introspection calculations.

Committed: https://crrev.com/f77e13a490ea98bed6f136661fa778ba3972b8e1
Cr-Commit-Position: refs/heads/master@{#431667}

[brettw, 2016-11-11 18:21:49]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-11-11 18:21:49]

https://codereview.chromium.org/2492273002/diff/1/tools/gn/command_args.cc
File tools/gn/command_args.cc (left):

https://codereview.chromium.org/2492273002/diff/1/tools/gn/command_args.cc#ol...
tools/gn/command_args.cc:234:
setup.build_settings().set_check_for_bad_items(false);
This is the only non-introspection disabling of the checking. But DoSetup
doesn't do any checking anyway (the build is not run in this case), so the flag
is not used.

[brettw, 2016-11-11 18:21:54]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 18:22:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 18:39:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 18:39:44]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-11-11 20:19:07]

Description was changed from

==========
GN: Always check for bad items.

Previous checking for most types of errors in the GN introspection commands was
disabled. The reason was that it can be convenient to ask for certain types
of information which GN can provide even if there are errors elsewhere in the
build.

Unfortunately, not checking for bad items can leave the build graph in an
inconsistent state. In the case of unresolved dependencies, a target will never
be resolved which means most of the information the tools will return about it
will be missing or incorrect. The result can be completely incorrect results
for the introspection commands.

As a result, it seems best to always ensure things are in a consistent state
before running any introspection calculations.
==========

to

==========
GN: Always check for bad items.

Previous checking for most types of errors in the GN introspection commands was
disabled. The reason was that it can be convenient to ask for certain types
of information which GN can provide even if there are errors elsewhere in the
build.

Unfortunately, not checking for bad items can leave the build graph in an
inconsistent state. In the case of missing dependencies, a target will never
be resolved which means most of the information the tools will return about it
will be missing or incorrect which is very surprising and confusing.

As a result, it seems best to always ensure things are in a consistent state
before running any introspection calculations.
==========

[Dirk Pranke, 2016-11-11 22:10:28]

lgtm

[brettw, 2016-11-11 22:12:29]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:13:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:25:13]

Description was changed from

==========
GN: Always check for bad items.

Previous checking for most types of errors in the GN introspection commands was
disabled. The reason was that it can be convenient to ask for certain types
of information which GN can provide even if there are errors elsewhere in the
build.

Unfortunately, not checking for bad items can leave the build graph in an
inconsistent state. In the case of missing dependencies, a target will never
be resolved which means most of the information the tools will return about it
will be missing or incorrect which is very surprising and confusing.

As a result, it seems best to always ensure things are in a consistent state
before running any introspection calculations.
==========

to

==========
GN: Always check for bad items.

Previous checking for most types of errors in the GN introspection commands was
disabled. The reason was that it can be convenient to ask for certain types
of information which GN can provide even if there are errors elsewhere in the
build.

Unfortunately, not checking for bad items can leave the build graph in an
inconsistent state. In the case of missing dependencies, a target will never
be resolved which means most of the information the tools will return about it
will be missing or incorrect which is very surprising and confusing.

As a result, it seems best to always ensure things are in a consistent state
before running any introspection calculations.
==========

[commit-bot: I haz the power, 2016-11-11 22:25:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-11 22:44:24]

Description was changed from

==========
GN: Always check for bad items.

Previous checking for most types of errors in the GN introspection commands was
disabled. The reason was that it can be convenient to ask for certain types
of information which GN can provide even if there are errors elsewhere in the
build.

Unfortunately, not checking for bad items can leave the build graph in an
inconsistent state. In the case of missing dependencies, a target will never
be resolved which means most of the information the tools will return about it
will be missing or incorrect which is very surprising and confusing.

As a result, it seems best to always ensure things are in a consistent state
before running any introspection calculations.
==========

to

==========
GN: Always check for bad items.

Previous checking for most types of errors in the GN introspection commands was
disabled. The reason was that it can be convenient to ask for certain types
of information which GN can provide even if there are errors elsewhere in the
build.

Unfortunately, not checking for bad items can leave the build graph in an
inconsistent state. In the case of missing dependencies, a target will never
be resolved which means most of the information the tools will return about it
will be missing or incorrect which is very surprising and confusing.

As a result, it seems best to always ensure things are in a consistent state
before running any introspection calculations.

Committed: https://crrev.com/f77e13a490ea98bed6f136661fa778ba3972b8e1
Cr-Commit-Position: refs/heads/master@{#431667}
==========

[commit-bot: I haz the power, 2016-11-11 22:44:25]

Patchset 1 (id:??) landed as
https://crrev.com/f77e13a490ea98bed6f136661fa778ba3972b8e1
Cr-Commit-Position: refs/heads/master@{#431667}