Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/command_analyze.cc

Issue 2492273002: GN: Always check for bad items. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/build_settings.cc ('k') | tools/gn/command_args.cc » ('j') | tools/gn/command_args.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_analyze.cc
diff --git a/tools/gn/command_analyze.cc b/tools/gn/command_analyze.cc
index ee3774ccdb77b302802317d8a2d4d9627c359f0a..6fd582356097f55d8f3326fe36c977b25a565422 100644
--- a/tools/gn/command_analyze.cc
+++ b/tools/gn/command_analyze.cc
@@ -107,7 +107,6 @@ int RunAnalyze(const std::vector<std::string>& args) {
}
Setup* setup = new Setup;
- setup->build_settings().set_check_for_bad_items(false);
if (!setup->DoSetup(args[0], false) || !setup->Run())
return 1;
« no previous file with comments | « tools/gn/build_settings.cc ('k') | tools/gn/command_args.cc » ('j') | tools/gn/command_args.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698