Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Unified Diff: tools/gn/build_settings.cc

Issue 2492273002: GN: Always check for bad items. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/build_settings.cc
diff --git a/tools/gn/build_settings.cc b/tools/gn/build_settings.cc
index 14f1aa8697b393334c326d594cc0c2693fa3e21d..3fac976202ad1f5125d2485826e5ec99c8a471a3 100644
--- a/tools/gn/build_settings.cc
+++ b/tools/gn/build_settings.cc
@@ -9,8 +9,7 @@
#include "base/files/file_util.h"
#include "tools/gn/filesystem_utils.h"
-BuildSettings::BuildSettings()
- : check_for_bad_items_(true) {
+BuildSettings::BuildSettings() {
}
BuildSettings::BuildSettings(const BuildSettings& other)
@@ -20,8 +19,7 @@ BuildSettings::BuildSettings(const BuildSettings& other)
python_path_(other.python_path_),
build_config_file_(other.build_config_file_),
build_dir_(other.build_dir_),
- build_args_(other.build_args_),
- check_for_bad_items_(true) {
+ build_args_(other.build_args_) {
}
BuildSettings::~BuildSettings() {
« no previous file with comments | « tools/gn/build_settings.h ('k') | tools/gn/command_analyze.cc » ('j') | tools/gn/command_args.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698