GN: Always check for bad items.

tools/gn/setup.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/setup.h"
 
 #include <stdlib.h>
 #include <algorithm>
 #include <sstream>
 #include <utility>
@@ skipping 312 matching lines @@
 void Setup::RunPreMessageLoop() {
   // Load the root build file.
   loader_->Load(root_build_file_, LocationRange(), Label());
 
   // Will be decremented with the loader is drained.
   g_scheduler->IncrementWorkCount();
 }
 
 bool Setup::RunPostMessageLoop() {
   Err err;
-  if (build_settings_.check_for_bad_items()) {
-    if (!builder_.CheckForBadItems(&err)) {
-      err.PrintToStdout();
+  if (!builder_.CheckForBadItems(&err)) {
+    err.PrintToStdout();
+    return false;
+  }
+
+  if (!build_settings_.build_args().VerifyAllOverridesUsed(&err)) {
+    // TODO(brettw) implement a system to have a different marker for
+    // warnings. Until we have a better system, print the error but don't
+    // return failure unless requested on the command line.
+    err.PrintToStdout();
+    if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+            switches::kFailOnUnusedArgs))
       return false;
-    }
-
-    if (!build_settings_.build_args().VerifyAllOverridesUsed(&err)) {
-      // TODO(brettw) implement a system to have a different marker for
-      // warnings. Until we have a better system, print the error but don't
-      // return failure unless requested on the command line.
-      err.PrintToStdout();
-      if (base::CommandLine::ForCurrentProcess()->HasSwitch(
-              switches::kFailOnUnusedArgs))
-        return false;
-      return true;
-    }
+    return true;
   }
 
   if (check_public_headers_) {
     std::vector<const Target*> all_targets = builder_.GetAllResolvedTargets();
     std::vector<const Target*> to_check;
     if (check_patterns()) {
       commands::FilterTargetsByPatterns(all_targets, *check_patterns(),
                                         &to_check);
     } else {
       to_check = all_targets;
@@ skipping 376 matching lines @@
       if (err.has_error()) {
         err.PrintToStdout();
         return false;
       }
     }
     build_settings_.set_exec_script_whitelist(std::move(whitelist));
   }
 
   return true;
 }