Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/gn/command_args.cc

Issue 2492273002: GN: Always check for bad items. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/command_analyze.cc ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/command_args.cc
diff --git a/tools/gn/command_args.cc b/tools/gn/command_args.cc
index 374a274a73919d3ad2599b9515d96e184512a826..1b81135be3d9ff23e632380568d956c8ec4661b5 100644
--- a/tools/gn/command_args.cc
+++ b/tools/gn/command_args.cc
@@ -118,7 +118,6 @@ void PrintArgHelp(const base::StringPiece& name, const Value& value) {
int ListArgs(const std::string& build_dir) {
Setup* setup = new Setup;
- setup->build_settings().set_check_for_bad_items(false);
if (!setup->DoSetup(build_dir, false) || !setup->Run())
return 1;
@@ -231,7 +230,6 @@ int EditArgsFile(const std::string& build_dir) {
// Scope the setup. We only use it for some basic state. We'll do the
// "real" build below in the gen command.
Setup setup;
- setup.build_settings().set_check_for_bad_items(false);
brettw 2016/11/11 18:21:49 This is the only non-introspection disabling of th
// Don't fill build arguments. We're about to edit the file which supplies
// these in the first place.
setup.set_fill_arguments(false);
« no previous file with comments | « tools/gn/command_analyze.cc ('k') | tools/gn/command_desc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698